From: fweisbec@gmail.com (Frederic Weisbecker)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] cpustat: use accessor functions for get/set/add
Date: Fri, 22 Feb 2013 15:03:08 +0100 [thread overview]
Message-ID: <20130222140306.GA18149@somewhere.redhat.com> (raw)
In-Reply-To: <1361541531.26780.57.camel@laptop>
On Fri, Feb 22, 2013 at 02:58:51PM +0100, Peter Zijlstra wrote:
> On Fri, 2013-02-22 at 14:38 +0100, Frederic Weisbecker wrote:
> > Looks good, just a minor neat:
> >
> > On Thu, Feb 21, 2013 at 09:56:43PM -0800, Kevin Hilman wrote:
> > > diff --git a/include/linux/kernel_stat.h b/include/linux/kernel_stat.h
> > > index 66b7078..df8ad75 100644
> > > --- a/include/linux/kernel_stat.h
> > > +++ b/include/linux/kernel_stat.h
> > > @@ -32,7 +32,7 @@ enum cpu_usage_stat {
> > > };
> > >
> > > struct kernel_cpustat {
> > > - u64 cpustat[NR_STATS];
> > > + u64 _cpustat[NR_STATS];
> >
> > Why do you need the underscore?
>
> To make sure there's nobody still referencing the data directly instead
> of through the accessors.
Good point!
WARNING: multiple messages have this Message-ID (diff)
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Kevin Hilman <khilman@linaro.org>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linaro-kernel@lists.linaro.org
Subject: Re: [PATCH 1/2] cpustat: use accessor functions for get/set/add
Date: Fri, 22 Feb 2013 15:03:08 +0100 [thread overview]
Message-ID: <20130222140306.GA18149@somewhere.redhat.com> (raw)
In-Reply-To: <1361541531.26780.57.camel@laptop>
On Fri, Feb 22, 2013 at 02:58:51PM +0100, Peter Zijlstra wrote:
> On Fri, 2013-02-22 at 14:38 +0100, Frederic Weisbecker wrote:
> > Looks good, just a minor neat:
> >
> > On Thu, Feb 21, 2013 at 09:56:43PM -0800, Kevin Hilman wrote:
> > > diff --git a/include/linux/kernel_stat.h b/include/linux/kernel_stat.h
> > > index 66b7078..df8ad75 100644
> > > --- a/include/linux/kernel_stat.h
> > > +++ b/include/linux/kernel_stat.h
> > > @@ -32,7 +32,7 @@ enum cpu_usage_stat {
> > > };
> > >
> > > struct kernel_cpustat {
> > > - u64 cpustat[NR_STATS];
> > > + u64 _cpustat[NR_STATS];
> >
> > Why do you need the underscore?
>
> To make sure there's nobody still referencing the data directly instead
> of through the accessors.
Good point!
next prev parent reply other threads:[~2013-02-22 14:03 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 5:56 [PATCH 0/2] cpustat: use atomic operations to read/update stats Kevin Hilman
2013-02-22 5:56 ` Kevin Hilman
2013-02-22 5:56 ` [PATCH 1/2] cpustat: use accessor functions for get/set/add Kevin Hilman
2013-02-22 5:56 ` Kevin Hilman
2013-02-22 6:21 ` Viresh Kumar
2013-02-22 6:21 ` Viresh Kumar
2013-02-22 7:17 ` Amit Kucheria
2013-02-22 7:17 ` Amit Kucheria
2013-02-22 7:50 ` Viresh Kumar
2013-02-22 7:50 ` Viresh Kumar
2013-02-22 12:34 ` Frederic Weisbecker
2013-02-22 12:34 ` Frederic Weisbecker
2013-02-22 15:14 ` Kevin Hilman
2013-02-22 15:14 ` Kevin Hilman
2013-02-22 13:38 ` Frederic Weisbecker
2013-02-22 13:38 ` Frederic Weisbecker
2013-02-22 13:58 ` Peter Zijlstra
2013-02-22 13:58 ` Peter Zijlstra
2013-02-22 14:03 ` Frederic Weisbecker [this message]
2013-02-22 14:03 ` Frederic Weisbecker
2013-02-22 5:56 ` [PATCH 2/2] cpustat: convert to atomic operations Kevin Hilman
2013-02-22 5:56 ` Kevin Hilman
2013-02-22 8:46 ` [PATCH 0/2] cpustat: use atomic operations to read/update stats Peter Zijlstra
2013-02-22 8:46 ` Peter Zijlstra
2013-02-22 12:50 ` Frederic Weisbecker
2013-02-22 12:50 ` Frederic Weisbecker
2013-02-22 13:48 ` Peter Zijlstra
2013-02-22 13:48 ` Peter Zijlstra
2013-02-22 13:54 ` Ingo Molnar
2013-02-22 13:54 ` Ingo Molnar
2013-02-22 14:04 ` Peter Zijlstra
2013-02-22 14:04 ` Peter Zijlstra
2013-02-22 14:16 ` Ingo Molnar
2013-02-22 14:16 ` Ingo Molnar
2013-02-22 14:25 ` Peter Zijlstra
2013-02-22 14:25 ` Peter Zijlstra
2013-02-22 14:05 ` Peter Zijlstra
2013-02-22 14:05 ` Peter Zijlstra
2013-02-22 14:15 ` Frederic Weisbecker
2013-02-22 14:15 ` Frederic Weisbecker
2013-02-22 14:09 ` Peter Zijlstra
2013-02-22 14:09 ` Peter Zijlstra
2013-02-22 14:18 ` Ingo Molnar
2013-02-22 14:18 ` Ingo Molnar
2013-02-22 14:21 ` Eric Dumazet
2013-02-22 14:21 ` Eric Dumazet
2013-02-22 14:23 ` Frederic Weisbecker
2013-02-22 14:23 ` Frederic Weisbecker
2013-02-22 19:01 ` Kevin Hilman
2013-02-22 19:01 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130222140306.GA18149@somewhere.redhat.com \
--to=fweisbec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.