* [PATCH TINYCOMPRESS 4/14] compress: Change running from bitfield to plain int
@ 2013-02-10 0:08 Richard Fitzgerald
2013-02-22 15:59 ` [PATCH TINYCOMPRESS 4/14 v2] " Richard Fitzgerald
0 siblings, 1 reply; 2+ messages in thread
From: Richard Fitzgerald @ 2013-02-10 0:08 UTC (permalink / raw)
To: vinod.koul; +Cc: alsa-devel
Declaring running as a single-bit bitfield does not save any space
or give any coding advantages, but does leave potential opportunities
for the compiler to be inefficient in how it handles bitfields compared
to how it would handle a machine int.
diff --git a/compress.c b/compress.c
index fa2d43f..c4f215c 100644
--- a/compress.c
+++ b/compress.c
@@ -82,7 +82,7 @@ struct compress {
unsigned int flags;
char error[COMPR_ERR_MAX];
struct compr_config *config;
- int running:1;
+ int running;
};
static int oops(struct compress *compress, int e, const char *fmt, ...)
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH TINYCOMPRESS 4/14 v2] compress: Change running from bitfield to plain int
2013-02-10 0:08 [PATCH TINYCOMPRESS 4/14] compress: Change running from bitfield to plain int Richard Fitzgerald
@ 2013-02-22 15:59 ` Richard Fitzgerald
0 siblings, 0 replies; 2+ messages in thread
From: Richard Fitzgerald @ 2013-02-22 15:59 UTC (permalink / raw)
To: vinod.koul; +Cc: alsa-devel
Declaring running as a single-bit bitfield does not save any space
or give any coding advantages, but does leave potential opportunities
for the compiler to be inefficient in how it handles bitfields compared
to how it would handle a machine int.
---
compress.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/compress.c b/compress.c
index 3cd0f85..d09e161 100644
--- a/compress.c
+++ b/compress.c
@@ -82,7 +82,7 @@ struct compress {
unsigned int flags;
char error[COMPR_ERR_MAX];
struct compr_config *config;
- unsigned int running:1;
+ int running;
};
static int oops(struct compress *compress, int e, const char *fmt, ...)
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-22 15:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-10 0:08 [PATCH TINYCOMPRESS 4/14] compress: Change running from bitfield to plain int Richard Fitzgerald
2013-02-22 15:59 ` [PATCH TINYCOMPRESS 4/14 v2] " Richard Fitzgerald
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.