From: Olaf Hering <olaf@aepfle.de>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH 2 of 7] tools/xc: handle tty output differently in stdiostream_progress
Date: Fri, 22 Feb 2013 18:06:42 +0100 [thread overview]
Message-ID: <20130222170642.GA25362@aepfle.de> (raw)
In-Reply-To: <20775.42298.906250.582926@mariner.uk.xensource.com>
On Fri, Feb 22, Ian Jackson wrote:
> Olaf Hering writes ("[Xen-devel] [PATCH 2 of 7] tools/xc: handle tty output differently in stdiostream_progress"):
> > tools/xc: handle tty output differently in stdiostream_progress
> >
> > If the output goes to a tty, rewind the cursor and print everything in a
> > single line as it was done up to now. If the output goes to a file or
> > pipe print a newline after each progress output. This will fix logging
> > of progress messages from xc_save to xend.log.
> >
> > To support XTL_STDIOSTREAM_SHOW_PID or XTL_STDIOSTREAM_SHOW_DATE print
> > the output via vmessage if the output is not a tty.
>
> Can we lift the call to isatty out of the loop by calling it at
> setup ?
>
> Calling it continually is undesirable not really for performance
> reasons but because it always trashes errno and because it will make
> strace output more noisy.
Ok, I will prepare a patch. I think that series is already applied.
Olaf
next prev parent reply other threads:[~2013-02-22 17:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 15:52 [PATCH 0 of 7] various changes for xm migrate logging Olaf Hering
2013-02-13 15:52 ` [PATCH 1 of 7] tools/xc: fix logic error in stdiostream_progress Olaf Hering
2013-02-22 17:03 ` Ian Jackson
2013-02-13 15:53 ` [PATCH 2 of 7] tools/xc: handle tty output differently " Olaf Hering
2013-02-22 17:04 ` Ian Jackson
2013-02-22 17:06 ` Olaf Hering [this message]
2013-02-22 17:10 ` Ian Jackson
2013-02-13 15:53 ` [PATCH 3 of 7] tools/xc: turn XCFLAGS_* into shifts Olaf Hering
2013-02-13 15:53 ` [PATCH 4 of 7] tools/xc: restore logging in xc_save Olaf Hering
2013-02-13 15:53 ` [PATCH 5 of 7] tools/xc: log pid in xc_save/xc_restore output Olaf Hering
2013-02-13 15:53 ` [PATCH 6 of 7] xl: correct help text of xl migrate Olaf Hering
2013-02-13 15:53 ` [PATCH 7 of 7] libxl: pass debug flag down to libxl_domain_suspend Olaf Hering
2013-02-15 13:38 ` [PATCH 0 of 7] various changes for xm migrate logging Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130222170642.GA25362@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.