From: Dave Chinner <david@fromorbit.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: Brian Foster <bfoster@redhat.com>, xfs@oss.sgi.com
Subject: Re: [PATCH v4 0/6] speculative preallocation quota throttling
Date: Sat, 23 Feb 2013 12:50:15 +1100 [thread overview]
Message-ID: <20130223015015.GH26081@dastard> (raw)
In-Reply-To: <5127D060.5050806@sgi.com>
On Fri, Feb 22, 2013 at 02:09:04PM -0600, Mark Tinguely wrote:
>
> -- since I am being a grouch ... ---
> I wish I had caught in the review for commit a1e16c26 that
> xfs_iomap_eof_prealloc_initial_size() is returning an int rather
> than xfs_fsblock_t for consistency.
Which is a bug, not an inconsistency. It means that alloc_blocks may
not return the right thing at the 2^31/2^32 FSB boundary.
Don't grouch like you can't possibly fix it, just send a patch. :P
The code isn't upstream yet, so we've got the entire 3.9-rc cycle to
fix it... :)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-02-23 1:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 15:10 [PATCH v4 0/6] speculative preallocation quota throttling Brian Foster
2013-02-20 15:10 ` [PATCH v4 1/6] xfs: reorganize xfs_iomap_prealloc_size to remove indentation Brian Foster
2013-02-22 17:07 ` Mark Tinguely
2013-02-22 18:08 ` Brian Foster
2013-02-22 18:22 ` Mark Tinguely
2013-02-20 15:10 ` [PATCH v4 2/6] xfs: push rounddown_pow_of_two() to after prealloc throttle Brian Foster
2013-02-20 15:10 ` [PATCH v4 3/6] xfs: pass xfs_dquot to xfs_qm_adjust_dqlimits() instead of xfs_disk_dquot_t Brian Foster
2013-02-20 15:10 ` [PATCH v4 4/6] xfs: xfs_dquot prealloc throttling watermarks and low free space Brian Foster
2013-02-20 15:10 ` [PATCH v4 5/6] xfs: add quota-driven speculative preallocation throttling Brian Foster
2013-02-25 21:44 ` Mark Tinguely
2013-02-25 22:14 ` Dave Chinner
2013-02-25 22:38 ` Mark Tinguely
2013-02-20 15:10 ` [PATCH v4 6/6] xfs: xfs_iomap_prealloc_size() tracepoint Brian Foster
2013-02-22 20:09 ` [PATCH v4 0/6] speculative preallocation quota throttling Mark Tinguely
2013-02-23 1:50 ` Dave Chinner [this message]
[not found] ` <512BC90A.4090206@sgi.com>
2013-02-25 20:47 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130223015015.GH26081@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.