All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Tinguely <tinguely@sgi.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v4 0/6] speculative preallocation quota throttling
Date: Fri, 22 Feb 2013 14:09:04 -0600	[thread overview]
Message-ID: <5127D060.5050806@sgi.com> (raw)
In-Reply-To: <1361373019-30891-1-git-send-email-bfoster@redhat.com>

On 02/20/13 09:10, Brian Foster wrote:
> Hi all,
>
> Here is v4 of the speculative preallocation quota throttling set. Patch 3 of v3
> is dropped due to a redundancy and a few changes are made to the threshold
> management code (patch 4/6). The remaining patches are unchanged from v3.
>
> Brian
>
> v4:
> - Drop patch 3/7 from v3 (xfs: cap prealloc size to free space before shift).
> - Several updates to patch 4/6:
>    - Rename xfs_dquot_init_prealloc() to xfs_dquot_set_prealloc_limits().
>    - Unroll the prealloc threshold loop and remove the increment def.
>    - Fix up some comments.
> v3:
> - Rebased on top of updated speculative preallocation algorithm.
> v2:
> - Fix up xfs_iomap_prealloc_size() rounding (patch 2).
> - Add pre-calculated fields to xfs_dquot to support throttling.
> - Move to logarithmic (shift) throttler and finer tuned trigger/throttle logic.
>
> Brian Foster (6):
>    xfs: reorganize xfs_iomap_prealloc_size to remove indentation
>    xfs: push rounddown_pow_of_two() to after prealloc throttle
>    xfs: pass xfs_dquot to xfs_qm_adjust_dqlimits() instead of
>      xfs_disk_dquot_t
>    xfs: xfs_dquot prealloc throttling watermarks and low free space
>    xfs: add quota-driven speculative preallocation throttling
>    xfs: xfs_iomap_prealloc_size() tracepoint
>
>   fs/xfs/xfs_dquot.c       |   44 ++++++++++++-
>   fs/xfs/xfs_dquot.h       |   14 ++++-
>   fs/xfs/xfs_iomap.c       |  161 +++++++++++++++++++++++++++++++++++++---------
>   fs/xfs/xfs_qm.c          |    2 +-
>   fs/xfs/xfs_qm_syscalls.c |    1 +
>   fs/xfs/xfs_trace.h       |   24 +++++++
>   fs/xfs/xfs_trans_dquot.c |    2 +-
>   7 files changed, 212 insertions(+), 36 deletions(-)
>

The rest of the series looks good to me. Consider it Review-by: me.

The tracing in patch 6 says how much, but not why, BUT I think the why
would require multiple tracepoints, so I okay with it.

	-- since I am being a grouch ... ---
I wish I had caught in the review for commit a1e16c26 that 
xfs_iomap_eof_prealloc_initial_size() is returning an int rather than 
xfs_fsblock_t for consistency.

--Mark.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2013-02-22 20:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-20 15:10 [PATCH v4 0/6] speculative preallocation quota throttling Brian Foster
2013-02-20 15:10 ` [PATCH v4 1/6] xfs: reorganize xfs_iomap_prealloc_size to remove indentation Brian Foster
2013-02-22 17:07   ` Mark Tinguely
2013-02-22 18:08     ` Brian Foster
2013-02-22 18:22       ` Mark Tinguely
2013-02-20 15:10 ` [PATCH v4 2/6] xfs: push rounddown_pow_of_two() to after prealloc throttle Brian Foster
2013-02-20 15:10 ` [PATCH v4 3/6] xfs: pass xfs_dquot to xfs_qm_adjust_dqlimits() instead of xfs_disk_dquot_t Brian Foster
2013-02-20 15:10 ` [PATCH v4 4/6] xfs: xfs_dquot prealloc throttling watermarks and low free space Brian Foster
2013-02-20 15:10 ` [PATCH v4 5/6] xfs: add quota-driven speculative preallocation throttling Brian Foster
2013-02-25 21:44   ` Mark Tinguely
2013-02-25 22:14     ` Dave Chinner
2013-02-25 22:38       ` Mark Tinguely
2013-02-20 15:10 ` [PATCH v4 6/6] xfs: xfs_iomap_prealloc_size() tracepoint Brian Foster
2013-02-22 20:09 ` Mark Tinguely [this message]
2013-02-23  1:50   ` [PATCH v4 0/6] speculative preallocation quota throttling Dave Chinner
     [not found] ` <512BC90A.4090206@sgi.com>
2013-02-25 20:47   ` Brian Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5127D060.5050806@sgi.com \
    --to=tinguely@sgi.com \
    --cc=bfoster@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.