From: Michael Ellerman <michael@ellerman.id.au>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: Andi Kleen <ak@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
robert.richter@amd.com, Anton Blanchard <anton@au1.ibm.com>,
linux-kernel@vger.kernel.org,
Stephane Eranian <eranian@google.com>,
linuxppc-dev@ozlabs.org, Ingo Molnar <mingo@redhat.com>,
Paul Mackerras <paulus@samba.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH 5/6][v4]: perf: Create a sysfs entry for Power event format
Date: Wed, 27 Feb 2013 12:17:25 +1100 [thread overview]
Message-ID: <20130227011725.GA5819@concordia> (raw)
In-Reply-To: <20130226200343.GA21543@us.ibm.com>
On Tue, Feb 26, 2013 at 12:03:43PM -0800, Sukadev Bhattiprolu wrote:
> Michael Ellerman [michael@ellerman.id.au] wrote:
> | On Tue, Jan 22, 2013 at 10:26:13PM -0800, Sukadev Bhattiprolu wrote:
> | >
> | > [PATCH 5/6][v4]: perf: Create a sysfs entry for Power event format
> | >
> | > Create a sysfs entry, '/sys/bus/event_source/devices/cpu/format/event'
> | > which describes the format of a POWER cpu.
> |
> | Did this patch go upstream? I don't see it.
>
> Hmm, patches 1..4,6 are in linux-tip and Arnaldo's trees but patch 5 is
> in neither.
I suspect Arnaldo was either waiting for an ACK from Ben, or was
expecting Ben to take it?
> | > The format of the event is the same for all POWER cpus at least in
> | > (Power6, Power7), so bulk of this change is common in the code common
> | > to POWER cpus.
> |
> | No. The event format is different on most POWER cpus, in particular it
> | is different on Power6 and Power7, and will be different again on
> | Power8.
>
> Sigh. The port of this patchset to Power6 has not started yet.
It should hardly require a port, it's about five lines. But it doesn't
matter for now.
> But this patchset does work on Power7 correct ?
Yes, and without it the rest of the series is essentially useless. So I
guess it's better than nothing and we should get it in, we can fix it up
later to work across different chips.
Ben can you grab it, it's all arch/powerpc.
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <michael@ellerman.id.au>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
Andi Kleen <ak@linux.intel.com>,
robert.richter@amd.com, Anton Blanchard <anton@au1.ibm.com>,
linux-kernel@vger.kernel.org,
Stephane Eranian <eranian@google.com>,
linuxppc-dev@ozlabs.org,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Jiri Olsa <jolsa@redhat.com>,
benh@kernel.crashing.org
Subject: Re: [PATCH 5/6][v4]: perf: Create a sysfs entry for Power event format
Date: Wed, 27 Feb 2013 12:17:25 +1100 [thread overview]
Message-ID: <20130227011725.GA5819@concordia> (raw)
In-Reply-To: <20130226200343.GA21543@us.ibm.com>
On Tue, Feb 26, 2013 at 12:03:43PM -0800, Sukadev Bhattiprolu wrote:
> Michael Ellerman [michael@ellerman.id.au] wrote:
> | On Tue, Jan 22, 2013 at 10:26:13PM -0800, Sukadev Bhattiprolu wrote:
> | >
> | > [PATCH 5/6][v4]: perf: Create a sysfs entry for Power event format
> | >
> | > Create a sysfs entry, '/sys/bus/event_source/devices/cpu/format/event'
> | > which describes the format of a POWER cpu.
> |
> | Did this patch go upstream? I don't see it.
>
> Hmm, patches 1..4,6 are in linux-tip and Arnaldo's trees but patch 5 is
> in neither.
I suspect Arnaldo was either waiting for an ACK from Ben, or was
expecting Ben to take it?
> | > The format of the event is the same for all POWER cpus at least in
> | > (Power6, Power7), so bulk of this change is common in the code common
> | > to POWER cpus.
> |
> | No. The event format is different on most POWER cpus, in particular it
> | is different on Power6 and Power7, and will be different again on
> | Power8.
>
> Sigh. The port of this patchset to Power6 has not started yet.
It should hardly require a port, it's about five lines. But it doesn't
matter for now.
> But this patchset does work on Power7 correct ?
Yes, and without it the rest of the series is essentially useless. So I
guess it's better than nothing and we should get it in, we can fix it up
later to work across different chips.
Ben can you grab it, it's all arch/powerpc.
cheers
next prev parent reply other threads:[~2013-02-27 1:17 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 6:22 [PATCH 0/6][v4]: perf: Make POWER7 events available in sysfs Sukadev Bhattiprolu
2013-01-23 6:22 ` Sukadev Bhattiprolu
2013-01-23 6:23 ` [PATCH 1/6][v4]: perf/Power7: Use macros to identify perf events Sukadev Bhattiprolu
2013-01-23 6:23 ` Sukadev Bhattiprolu
2013-02-01 10:59 ` [tip:perf/core] " tip-bot for Sukadev Bhattiprolu
2013-01-23 6:24 ` [PATCH 2/6][v4]: perf: Make EVENT_ATTR global Sukadev Bhattiprolu
2013-01-23 6:24 ` Sukadev Bhattiprolu
2013-02-01 11:00 ` [tip:perf/core] " tip-bot for Sukadev Bhattiprolu
2013-01-23 6:24 ` [PATCH 3/6][v4]: perf/POWER7: Make generic event translations available in sysfs Sukadev Bhattiprolu
2013-01-23 6:24 ` Sukadev Bhattiprolu
2013-02-01 11:01 ` [tip:perf/core] " tip-bot for Sukadev Bhattiprolu
2013-01-23 6:25 ` [PATCH 4/6][v4]: perf/POWER7: Make some POWER7 events " Sukadev Bhattiprolu
2013-01-23 6:25 ` Sukadev Bhattiprolu
2013-02-01 11:02 ` [tip:perf/core] " tip-bot for Sukadev Bhattiprolu
2013-01-23 6:26 ` [PATCH 5/6][v4]: perf: Create a sysfs entry for Power event format Sukadev Bhattiprolu
2013-01-23 6:26 ` Sukadev Bhattiprolu
2013-02-26 5:26 ` Michael Ellerman
2013-02-26 5:26 ` Michael Ellerman
2013-02-26 20:03 ` Sukadev Bhattiprolu
2013-02-26 20:03 ` Sukadev Bhattiprolu
2013-02-27 1:17 ` Michael Ellerman [this message]
2013-02-27 1:17 ` Michael Ellerman
2013-03-06 5:48 ` Sukadev Bhattiprolu
2013-03-06 5:48 ` Sukadev Bhattiprolu
2013-03-12 9:27 ` Paul Mackerras
2013-03-12 9:27 ` Paul Mackerras
2013-03-13 0:15 ` Michael Ellerman
2013-03-13 0:15 ` Michael Ellerman
2013-03-18 10:57 ` [tip:perf/urgent] perf/POWER7: Create a sysfs format entry for Power7 events tip-bot for Sukadev Bhattiprolu
2013-02-27 1:27 ` [PATCH 5/6][v4]: perf: Create a sysfs entry for Power event format Michael Ellerman
2013-02-27 1:27 ` Michael Ellerman
2013-01-23 6:26 ` [PATCH 6/6][v4]: perf: Document the ABI of perf sysfs entries Sukadev Bhattiprolu
2013-01-23 6:26 ` Sukadev Bhattiprolu
2013-02-01 11:04 ` [tip:perf/core] " tip-bot for Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130227011725.GA5819@concordia \
--to=michael@ellerman.id.au \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=ak@linux.intel.com \
--cc=anton@au1.ibm.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=robert.richter@amd.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.