All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Kyungsik Lee <kyungsik.lee@lge.com>,
	"Markus F.X.J. Oberhumer" <markus@oberhumer.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Michal Marek <mmarek@suse.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	x86@kernel.org, celinux-dev@lists.celinuxforum.org,
	Nicolas Pitre <nico@fluxnic.net>,
	Nitin Gupta <nitingupta910@gmail.com>,
	Richard Purdie <rpurdie@openedhand.com>,
	Josh Triplett <josh@joshtriplett.org>,
	Joe Millenbach <jmillenbach@gmail.com>,
	David Sterba <dsterba@suse.cz>,
	Richard Cochran <richardcochran@gmail.com>,
	Albin Tonnerre <albin.tonnerre@free-electrons.com>,
	Egon Alter <egon.alter@gmx.net>,
	hyojun.im@lge.com, chan.jeong@lge.com,
	raphael.andy.lee@gmail.com
Subject: Re: [RFC PATCH v2 0/4] Add support for LZ4-compressed kernel
Date: Wed, 27 Feb 2013 14:21:54 -0800	[thread overview]
Message-ID: <20130227142154.f1f40048.akpm@linux-foundation.org> (raw)
In-Reply-To: <20130227095139.GX17833@n2100.arm.linux.org.uk>

On Wed, 27 Feb 2013 09:51:39 +0000
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:

> On Wed, Feb 27, 2013 at 04:36:47PM +0900, Kyungsik Lee wrote:
> > Compiler: Linaro ARM gcc 4.6.2
> > 2. ARMv7, 1.7GHz based board
> >    Kernel: linux 3.7
> >    Uncompressed Kernel Size: 14MB
> >          Compressed Size  Decompression Speed
> >     LZO  6.0MB            34.1MB/s            Old
> >          ----------------------------------------
> >          6.0MB            34.7MB/s            New
> >          6.0MB            52.2MB/s(UA)
> >     =============================================
> >     LZ4  6.5MB            86.7MB/s
> > UA: Unaligned memory Access support
> 
> That is pretty conclusive - it shows an 8% increase in image size vs a
> 66% increase in decompression speed.  It will take a _lot_ to offset
> that increase in decompression speed.
> 
> So, what I think is that yes, we should accept LZ4 and drop LZO from
> the kernel - the "fast but may not be small" compression title has
> clearly been taken by LZ4.
> 
> Akpm - what's your thoughts?

It sounds like we should merge both.

I've sent Linus a little reminder for Markus's 3.9 pull request.  Let's
get down and review and test this new code?

David's review comments were useful.

I'd like to also see a Kconfig patch which makes x86 and arm kernels
default to the new LZ4 code.  Then I can sneak that patch into
linux-next so the new code will get some testing.  If we don't do that,
very few people will run it.

WARNING: multiple messages have this Message-ID (diff)
From: akpm@linux-foundation.org (Andrew Morton)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v2 0/4] Add support for LZ4-compressed kernel
Date: Wed, 27 Feb 2013 14:21:54 -0800	[thread overview]
Message-ID: <20130227142154.f1f40048.akpm@linux-foundation.org> (raw)
In-Reply-To: <20130227095139.GX17833@n2100.arm.linux.org.uk>

On Wed, 27 Feb 2013 09:51:39 +0000
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:

> On Wed, Feb 27, 2013 at 04:36:47PM +0900, Kyungsik Lee wrote:
> > Compiler: Linaro ARM gcc 4.6.2
> > 2. ARMv7, 1.7GHz based board
> >    Kernel: linux 3.7
> >    Uncompressed Kernel Size: 14MB
> >          Compressed Size  Decompression Speed
> >     LZO  6.0MB            34.1MB/s            Old
> >          ----------------------------------------
> >          6.0MB            34.7MB/s            New
> >          6.0MB            52.2MB/s(UA)
> >     =============================================
> >     LZ4  6.5MB            86.7MB/s
> > UA: Unaligned memory Access support
> 
> That is pretty conclusive - it shows an 8% increase in image size vs a
> 66% increase in decompression speed.  It will take a _lot_ to offset
> that increase in decompression speed.
> 
> So, what I think is that yes, we should accept LZ4 and drop LZO from
> the kernel - the "fast but may not be small" compression title has
> clearly been taken by LZ4.
> 
> Akpm - what's your thoughts?

It sounds like we should merge both.

I've sent Linus a little reminder for Markus's 3.9 pull request.  Let's
get down and review and test this new code?

David's review comments were useful.

I'd like to also see a Kconfig patch which makes x86 and arm kernels
default to the new LZ4 code.  Then I can sneak that patch into
linux-next so the new code will get some testing.  If we don't do that,
very few people will run it.

  parent reply	other threads:[~2013-02-27 22:21 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-26  6:24 [RFC PATCH v2 0/4] Add support for LZ4-compressed kernel Kyungsik Lee
2013-02-26  6:24 ` Kyungsik Lee
2013-02-26  6:24 ` [RFC PATCH v2 1/4] decompressor: Add LZ4 decompressor module Kyungsik Lee
2013-02-26  6:24   ` Kyungsik Lee
2013-02-26 13:12   ` David Sterba
2013-02-26 13:12     ` David Sterba
2013-02-27  4:38     ` Kyungsik Lee
2013-02-27  4:38       ` Kyungsik Lee
2013-02-26  6:24 ` [RFC PATCH v2 2/4] lib: Add support for LZ4-compressed kernel Kyungsik Lee
2013-02-26  6:24   ` Kyungsik Lee
2013-02-26 14:00   ` David Sterba
2013-02-26 14:00     ` David Sterba
2013-02-28  5:22     ` Kyungsik Lee
2013-02-28  5:22       ` Kyungsik Lee
2013-02-26  6:24 ` [RFC PATCH v2 3/4] arm: " Kyungsik Lee
2013-02-26  6:24   ` Kyungsik Lee
2013-02-26  6:24 ` [RFC PATCH v2 4/4] x86: " Kyungsik Lee
2013-02-26  6:24   ` Kyungsik Lee
2013-02-26 20:33 ` [RFC PATCH v2 0/4] " Markus F.X.J. Oberhumer
2013-02-26 20:33   ` Markus F.X.J. Oberhumer
2013-02-26 20:59   ` Nicolas Pitre
2013-02-26 20:59     ` Nicolas Pitre
2013-02-26 21:58     ` Peter Korsgaard
2013-02-26 21:58       ` Peter Korsgaard
2013-02-26 22:09       ` Nicolas Pitre
2013-02-26 22:09         ` Nicolas Pitre
2013-02-26 22:10       ` Russell King - ARM Linux
2013-02-26 22:10         ` Russell King - ARM Linux
2013-02-27  1:40         ` Joe Perches
2013-02-27  1:40           ` Joe Perches
2013-02-27  9:56           ` Russell King - ARM Linux
2013-02-27  9:56             ` Russell King - ARM Linux
2013-02-27 15:49             ` Joe Perches
2013-02-27 15:49               ` Joe Perches
2013-02-27 16:08               ` Nicolas Pitre
2013-02-27 16:08                 ` Nicolas Pitre
2013-02-27 16:08                 ` Nicolas Pitre
2013-02-27 16:31               ` Russell King - ARM Linux
2013-02-27 16:31                 ` Russell King - ARM Linux
2013-02-27 16:53                 ` Borislav Petkov
2013-02-27 16:53                   ` Borislav Petkov
2013-02-27 17:04                 ` Joe Perches
2013-02-27 17:04                   ` Joe Perches
2013-02-27 17:16                   ` Nicolas Pitre
2013-02-27 17:16                     ` Nicolas Pitre
2013-02-27 17:39                     ` Joe Perches
2013-02-27 17:39                       ` Joe Perches
2013-02-27 17:52                       ` Nicolas Pitre
2013-02-27 17:52                         ` Nicolas Pitre
2013-02-27 17:57                       ` Russell King - ARM Linux
2013-02-27 17:57                         ` Russell King - ARM Linux
2013-02-27 17:36                   ` Russell King - ARM Linux
2013-02-27 17:36                     ` Russell King - ARM Linux
2013-02-28  4:22                     ` Joe Perches
2013-02-28  4:22                       ` Joe Perches
2013-02-27  7:36   ` Kyungsik Lee
2013-02-27  7:36     ` Kyungsik Lee
2013-02-27  9:51     ` Russell King - ARM Linux
2013-02-27  9:51       ` Russell King - ARM Linux
2013-02-27 10:20       ` Johannes Stezenbach
2013-02-27 10:20         ` Johannes Stezenbach
2013-02-27 15:35         ` Nicolas Pitre
2013-02-27 15:35           ` Nicolas Pitre
2013-02-27 13:23       ` Kyungsik Lee
2013-02-27 13:23         ` Kyungsik Lee
2013-02-27 22:21       ` Andrew Morton [this message]
2013-02-27 22:21         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130227142154.f1f40048.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=albin.tonnerre@free-electrons.com \
    --cc=celinux-dev@lists.celinuxforum.org \
    --cc=chan.jeong@lge.com \
    --cc=dsterba@suse.cz \
    --cc=egon.alter@gmx.net \
    --cc=hpa@zytor.com \
    --cc=hyojun.im@lge.com \
    --cc=jmillenbach@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=kyungsik.lee@lge.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=markus@oberhumer.com \
    --cc=mingo@redhat.com \
    --cc=mmarek@suse.cz \
    --cc=nico@fluxnic.net \
    --cc=nitingupta910@gmail.com \
    --cc=raphael.andy.lee@gmail.com \
    --cc=richardcochran@gmail.com \
    --cc=rpurdie@openedhand.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.