All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eliezer Tamir <eliezer.tamir@linux.jf.intel.com>
To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: Dave Miller <davem@davemloft.net>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	e1000-devel@lists.sourceforge.net,
	Willem de Bruijn <willemb@google.com>,
	Andi Kleen <andi@firstfloor.org>, HPA <hpa@zytor.com>,
	Eliezer Tamir <eliezer@tamir.org.il>
Subject: [RFC PATCH 2/5] tcp: add TCP support for low latency receive poll.
Date: Wed, 27 Feb 2013 09:56:01 -0800	[thread overview]
Message-ID: <20130227175601.10611.99536.stgit@gitlad.jf.intel.com> (raw)
In-Reply-To: <20130227175549.10611.82188.stgit@gitlad.jf.intel.com>

an example of how one could add support for ndo_ll_poll to TCP.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Eliezer Tamir <eliezer.tamir@linux.intel.com>
---

 net/ipv4/Kconfig     |   11 +++++++++++
 net/ipv4/tcp.c       |   20 ++++++++++++++++++++
 net/ipv4/tcp_input.c |    4 ++++
 3 files changed, 35 insertions(+), 0 deletions(-)

diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index e52f011..9796aba 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -414,6 +414,17 @@ config INET_LL_RX_POLL
 
 	  If unsure, say N.
 
+config INET_LL_TCP_POLL
+	bool "Low Latency TCP Receive Poll"
+	depends on INET_LL_RX_POLL
+	default n
+	---help---
+	  TCP support for Low Latency TCP Queue Poll.
+	  (For network cards tht support this option.)
+	  Add support to the TCP stack for direct polling of the network card.
+
+	  If unsure, say N.
+
 config INET_DIAG
 	tristate "INET: socket monitoring interface"
 	default y
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 47e854f..e3d1a8e 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -279,6 +279,7 @@
 
 #include <asm/uaccess.h>
 #include <asm/ioctls.h>
+#include <net/ll_poll.h>
 
 int sysctl_tcp_fin_timeout __read_mostly = TCP_FIN_TIMEOUT;
 
@@ -1475,6 +1476,17 @@ int tcp_read_sock(struct sock *sk, read_descriptor_t *desc,
 
 	if (sk->sk_state == TCP_LISTEN)
 		return -ENOTCONN;
+
+#ifdef CONFIG_INET_LL_TCP_POLL
+/* TODO: what do we do if the state changes after sk_poll_ll()? */
+	if (sk_valid_ll(sk) && skb_queue_empty(&sk->sk_receive_queue)
+		&& (sk->sk_state == TCP_ESTABLISHED)) {
+
+		release_sock(sk);
+		sk_poll_ll(sk);
+		lock_sock(sk);
+	}
+#endif
 	while ((skb = tcp_recv_skb(sk, seq, &offset)) != NULL) {
 		if (offset < skb->len) {
 			int used;
@@ -1513,6 +1525,7 @@ int tcp_read_sock(struct sock *sk, read_descriptor_t *desc,
 			if (offset + 1 != skb->len)
 				continue;
 		}
+		sk_mark_ll(sk, skb);
 		if (tcp_hdr(skb)->fin) {
 			sk_eat_skb(sk, skb, false);
 			++seq;
@@ -1560,6 +1573,12 @@ int tcp_recvmsg(struct kiocb *iocb, struct sock *sk, struct msghdr *msg,
 	struct sk_buff *skb;
 	u32 urg_hole = 0;
 
+#ifdef CONFIG_INET_LL_TCP_POLL
+	if (sk_valid_ll(sk) && skb_queue_empty(&sk->sk_receive_queue)
+	    && (sk->sk_state == TCP_ESTABLISHED))
+		sk_poll_ll(sk);
+#endif
+
 	lock_sock(sk);
 
 	err = -ENOTCONN;
@@ -1864,6 +1883,7 @@ do_prequeue:
 					break;
 				}
 			}
+			sk_mark_ll(sk, skb);
 		}
 
 		*seq += used;
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index a759e19..5c40bd3 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -74,6 +74,7 @@
 #include <linux/ipsec.h>
 #include <asm/unaligned.h>
 #include <net/netdma.h>
+#include <net/ll_poll.h>
 
 int sysctl_tcp_timestamps __read_mostly = 1;
 int sysctl_tcp_window_scaling __read_mostly = 1;
@@ -4618,6 +4619,7 @@ static void tcp_data_queue(struct sock *sk, struct sk_buff *skb)
 				tp->copied_seq += chunk;
 				eaten = (chunk == skb->len);
 				tcp_rcv_space_adjust(sk);
+				sk_mark_ll(sk, skb);
 			}
 			local_bh_disable();
 		}
@@ -5185,6 +5187,7 @@ static int tcp_copy_to_iovec(struct sock *sk, struct sk_buff *skb, int hlen)
 		tp->ucopy.len -= chunk;
 		tp->copied_seq += chunk;
 		tcp_rcv_space_adjust(sk);
+		sk_mark_ll(sk, skb);
 	}
 
 	local_bh_disable();
@@ -5244,6 +5247,7 @@ static bool tcp_dma_try_early_copy(struct sock *sk, struct sk_buff *skb,
 		tp->ucopy.len -= chunk;
 		tp->copied_seq += chunk;
 		tcp_rcv_space_adjust(sk);
+		sk_mark_ll(sk, skb);
 
 		if ((tp->ucopy.len == 0) ||
 		    (tcp_flag_word(tcp_hdr(skb)) & TCP_FLAG_PSH) ||


  parent reply	other threads:[~2013-02-27 17:55 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-27 17:55 [RFC PATCH 0/5] net: low latency Ethernet device polling Eliezer Tamir
2013-02-27 17:55 ` [RFC PATCH 1/5] net: implement support for low latency socket polling Eliezer Tamir
2013-03-03 18:35   ` Eric Dumazet
2013-03-03 19:21     ` Andi Kleen
2013-03-03 21:20       ` Eric Dumazet
2013-03-04  3:55         ` Andi Kleen
2013-03-04  8:43     ` Eliezer Tamir
2013-03-04 14:52       ` Eric Dumazet
2013-03-04 15:28         ` Eliezer Tamir
2013-03-04 16:15           ` Eric Dumazet
2013-03-04  7:23   ` Cong Wang
2013-03-05 16:43   ` Ben Hutchings
2013-03-05 16:43     ` Ben Hutchings
2013-03-05 17:15     ` Eliezer Tamir
2013-03-05 19:57       ` David Miller
2013-03-05 19:55     ` David Miller
2013-03-05 20:03       ` H. Peter Anvin
2013-03-05 20:03         ` H. Peter Anvin
2013-02-27 17:56 ` Eliezer Tamir [this message]
2013-03-05 17:13   ` [RFC PATCH 2/5] tcp: add TCP support for low latency receive poll Ben Hutchings
2013-03-05 17:13     ` Ben Hutchings
2013-02-27 17:56 ` [RFC PATCH 3/5] ixgbe: Add support for ndo_ll_poll Eliezer Tamir
2013-02-27 18:41   ` Eric Dumazet
2013-02-27 19:20     ` Eliezer Tamir
2013-03-05 17:26   ` Ben Hutchings
2013-03-05 17:26     ` Ben Hutchings
2013-03-05 17:28     ` Ben Hutchings
2013-03-05 17:28       ` Ben Hutchings
2013-03-05 17:36       ` Eric Dumazet
2013-03-05 17:36         ` Eric Dumazet
2013-02-27 17:56 ` [RFC PATCH 4/5] ixgbe: add extra stats " Eliezer Tamir
2013-02-27 17:56 ` [RFC PATCH 5/5] ixgbe: kprobes latency test module Eliezer Tamir
2013-02-27 18:07 ` [RFC PATCH 0/5] net: low latency Ethernet device polling Eliezer Tamir
2013-02-27 18:07   ` Eliezer Tamir
2013-02-27 18:13 ` Stephen Hemminger
2013-02-27 18:47   ` Tom Herbert
2013-02-27 19:17     ` Eliezer Tamir
2013-03-04 22:34       ` Ben Hutchings
2013-02-27 19:58 ` Rick Jones
2013-02-27 20:40   ` Eliezer Tamir
2013-02-27 21:42     ` Ben Greear
2013-02-28  8:38       ` Eliezer Tamir
2013-03-01 21:24 ` David Miller
2013-03-01 22:57   ` Tom Herbert
2013-03-02 17:02   ` Eliezer Tamir
2013-03-04  7:37 ` Cong Wang
2013-03-04  7:37   ` Cong Wang
2013-03-04  8:19   ` Eliezer Tamir
2013-03-04  8:46     ` Eliezer Tamir
2013-03-04 17:19 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130227175601.10611.99536.stgit@gitlad.jf.intel.com \
    --to=eliezer.tamir@linux.jf.intel.com \
    --cc=andi@firstfloor.org \
    --cc=davem@davemloft.net \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=eliezer@tamir.org.il \
    --cc=hpa@zytor.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.