From: Oleg Nesterov <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Andrey Vagin <avagin-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
criu-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Roland McGrath <roland-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
"Paul E. McKenney"
<paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Dave Jones <davej-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Michael Kerrisk (man-pages)"
<mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Pavel Emelyanov <xemul-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>,
Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Pedro Alves <palves-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 1/2] ptrace: add ability to retrieve signals without removing from a queue (v3)
Date: Wed, 27 Feb 2013 19:38:50 +0100 [thread overview]
Message-ID: <20130227183850.GA6042@redhat.com> (raw)
In-Reply-To: <1361975829-1738-1-git-send-email-avagin-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
On 02/27, Andrey Vagin wrote:
>
> +struct ptrace_peeksiginfo_args {
> + __u64 off; /* from which siginfo to start */
Cough... You are optimist. You want to handle the case when the
tracee has 1 << 33 or more pending sigqueues. OK good luck ;)
Looks correct, just one nit.
> + for (i = 0; i < arg.nr; i++) {
> ...
> + data += sizeof(siginfo_t);
> +
> + if (signal_pending(current)) {
> + i++; /* accounting the current siginfo */
> + break;
> + }
Imho, this is confusing. Just do
for (i = 0; i < arg.nr; ) {
...
data += sizeof(siginfo_t);
i++;
if (signal_pending(current))
break;
Oleg.
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: Andrey Vagin <avagin@openvz.org>
Cc: linux-kernel@vger.kernel.org, criu@openvz.org,
linux-api@vger.kernel.org, Roland McGrath <roland@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
David Howells <dhowells@redhat.com>,
Dave Jones <davej@redhat.com>,
"Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>,
Pavel Emelyanov <xemul@parallels.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH 1/2] ptrace: add ability to retrieve signals without removing from a queue (v3)
Date: Wed, 27 Feb 2013 19:38:50 +0100 [thread overview]
Message-ID: <20130227183850.GA6042@redhat.com> (raw)
In-Reply-To: <1361975829-1738-1-git-send-email-avagin@openvz.org>
On 02/27, Andrey Vagin wrote:
>
> +struct ptrace_peeksiginfo_args {
> + __u64 off; /* from which siginfo to start */
Cough... You are optimist. You want to handle the case when the
tracee has 1 << 33 or more pending sigqueues. OK good luck ;)
Looks correct, just one nit.
> + for (i = 0; i < arg.nr; i++) {
> ...
> + data += sizeof(siginfo_t);
> +
> + if (signal_pending(current)) {
> + i++; /* accounting the current siginfo */
> + break;
> + }
Imho, this is confusing. Just do
for (i = 0; i < arg.nr; ) {
...
data += sizeof(siginfo_t);
i++;
if (signal_pending(current))
break;
Oleg.
next prev parent reply other threads:[~2013-02-27 18:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 14:37 [PATCH 1/2] ptrace: add ability to retrieve signals without removing from a queue (v3) Andrey Vagin
2013-02-27 14:37 ` Andrey Vagin
[not found] ` <1361975829-1738-1-git-send-email-avagin-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2013-02-27 14:37 ` [PATCH 2/2] selftest: add a test case for PTRACE_PEEKSIGINFO Andrey Vagin
2013-02-27 14:37 ` Andrey Vagin
2013-02-27 18:38 ` Oleg Nesterov [this message]
2013-02-27 18:38 ` [PATCH 1/2] ptrace: add ability to retrieve signals without removing from a queue (v3) Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130227183850.GA6042@redhat.com \
--to=oleg-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=avagin-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
--cc=criu-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
--cc=davej-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=palves-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=roland-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=xemul-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.