From: Arnd Bergmann <arnd@arndb.de>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
Vinod Koul <vinod.koul@intel.com>,
Marek Vasut <marek.vasut@gmail.com>,
Fabio Estevam <fabio.estevam@freescale.com>,
Huang Shijie <b32955@freescale.com>, Chris Ball <cjb@laptop.org>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH 04/12] mmc: mxs-mmc: move to use generic DMA helper
Date: Wed, 27 Feb 2013 20:54:18 +0000 [thread overview]
Message-ID: <201302272054.18829.arnd@arndb.de> (raw)
In-Reply-To: <1361978748-25281-5-git-send-email-shawn.guo@linaro.org>
On Wednesday 27 February 2013, Shawn Guo wrote:
> Required properties:
> - compatible: Should be "fsl,<chip>-mmc". The supported chips include
> imx23 and imx28.
> -- interrupts: Should contain ERROR and DMA interrupts
> -- fsl,ssp-dma-channel: APBH DMA channel for the SSP
> +- interrupts: Should contain ERROR interrupt number
> +- dmas: DMA specifier, consisting of a phandle to DMA controller node
> + and SSP DMA channel ID.
> + Refer to dma.txt and fsl-mxs-dma.txt for details.
I wonder if we should leave support for old device trees files around,
at least for a while. Your patch removes a lot of unnecessary code if
we decide not to worry about backwards compatibility here, but I could
imagine that we see a few surprises here.
> +- dma-names: Must be "ssp".
I would prefer calling this "data" rather than "ssp". The name only
has local significance in the ssp device, so calling the channel
"ssp" seems wrong.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/12] mmc: mxs-mmc: move to use generic DMA helper
Date: Wed, 27 Feb 2013 20:54:18 +0000 [thread overview]
Message-ID: <201302272054.18829.arnd@arndb.de> (raw)
In-Reply-To: <1361978748-25281-5-git-send-email-shawn.guo@linaro.org>
On Wednesday 27 February 2013, Shawn Guo wrote:
> Required properties:
> - compatible: Should be "fsl,<chip>-mmc". The supported chips include
> imx23 and imx28.
> -- interrupts: Should contain ERROR and DMA interrupts
> -- fsl,ssp-dma-channel: APBH DMA channel for the SSP
> +- interrupts: Should contain ERROR interrupt number
> +- dmas: DMA specifier, consisting of a phandle to DMA controller node
> + and SSP DMA channel ID.
> + Refer to dma.txt and fsl-mxs-dma.txt for details.
I wonder if we should leave support for old device trees files around,
at least for a while. Your patch removes a lot of unnecessary code if
we decide not to worry about backwards compatibility here, but I could
imagine that we see a few surprises here.
> +- dma-names: Must be "ssp".
I would prefer calling this "data" rather than "ssp". The name only
has local significance in the ssp device, so calling the channel
"ssp" seems wrong.
Arnd
next prev parent reply other threads:[~2013-02-27 20:54 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 15:25 [PATCH 00/12] ARM: mxs: move to generic DMA device tree binding Shawn Guo
2013-02-27 15:25 ` [PATCH 01/12] ARM: dts: add generic DMA device tree binding for mxs-dma Shawn Guo
2013-02-27 20:36 ` Arnd Bergmann
2013-02-28 6:39 ` Shawn Guo
2013-02-28 10:48 ` Arnd Bergmann
2013-02-27 15:25 ` [PATCH 02/12] dma: mxs-dma: use devm_* managed functions Shawn Guo
2013-02-27 15:25 ` [PATCH 03/12] dma: mxs-dma: move to generic device tree binding Shawn Guo
2013-02-27 20:50 ` Arnd Bergmann
2013-02-28 7:24 ` Shawn Guo
2013-02-27 15:25 ` [PATCH 04/12] mmc: mxs-mmc: move to use generic DMA helper Shawn Guo
2013-02-27 15:25 ` Shawn Guo
2013-02-27 20:54 ` Arnd Bergmann [this message]
2013-02-27 20:54 ` Arnd Bergmann
2013-02-28 8:28 ` Shawn Guo
2013-02-28 8:28 ` Shawn Guo
2013-02-28 10:50 ` Arnd Bergmann
2013-02-28 10:50 ` Arnd Bergmann
2013-02-27 15:25 ` [PATCH 05/12] spi: mxs-spi: " Shawn Guo
2013-02-27 15:25 ` Shawn Guo
2013-03-02 23:17 ` Grant Likely
2013-03-02 23:17 ` Grant Likely
[not found] ` <1361978748-25281-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-02-27 15:25 ` [PATCH 06/12] i2c: i2c-mxs: " Shawn Guo
2013-02-27 15:25 ` Shawn Guo
2013-02-27 15:25 ` [PATCH 07/12] mtd: gpmi: " Shawn Guo
2013-02-27 15:25 ` Shawn Guo
2013-02-28 8:39 ` Huang Shijie
2013-02-28 8:39 ` Huang Shijie
2013-03-01 1:14 ` Shawn Guo
2013-03-01 1:14 ` Shawn Guo
2013-03-08 13:19 ` Artem Bityutskiy
2013-03-08 13:19 ` Artem Bityutskiy
2013-03-08 14:06 ` Arnd Bergmann
2013-03-08 14:06 ` Arnd Bergmann
2013-03-11 7:32 ` Artem Bityutskiy
2013-03-11 7:32 ` Artem Bityutskiy
2013-03-08 16:26 ` Huang Shijie
2013-03-08 16:26 ` Huang Shijie
2013-03-11 3:03 ` Shawn Guo
2013-03-11 3:03 ` Shawn Guo
2013-02-27 15:25 ` [PATCH 08/12] serial: mxs-auart: " Shawn Guo
2013-02-27 15:25 ` Shawn Guo
2013-02-27 15:25 ` [PATCH 09/12] ASoC: dmaengine_pcm: support use of " Shawn Guo
2013-02-27 15:25 ` Shawn Guo
2013-02-27 21:02 ` Arnd Bergmann
2013-02-27 21:02 ` Arnd Bergmann
2013-02-28 8:09 ` Shawn Guo
2013-02-28 8:09 ` Shawn Guo
2013-03-01 10:23 ` Mark Brown
2013-03-01 10:23 ` Mark Brown
2013-03-04 8:37 ` Shawn Guo
2013-03-04 8:37 ` Shawn Guo
2013-02-27 15:25 ` [PATCH 10/12] ASoC: mxs: move to use " Shawn Guo
2013-02-27 15:25 ` Shawn Guo
2013-02-27 15:25 ` [PATCH 11/12] dma: mxs-dma: remove code left from generic DMA binding conversion Shawn Guo
2013-02-27 15:25 ` [PATCH 12/12] ARM: dts: remove mxs-dma channel interrupt number from client nodes Shawn Guo
2013-02-27 21:05 ` [PATCH 00/12] ARM: mxs: move to generic DMA device tree binding Arnd Bergmann
2013-02-28 19:20 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201302272054.18829.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=b32955@freescale.com \
--cc=cjb@laptop.org \
--cc=fabio.estevam@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=shawn.guo@linaro.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.