From: Borislav Petkov <bp@alien8.de>
To: "Yu, Fenghua" <fenghua.yu@intel.com>, "H. Peter Anvin" <hpa@zytor.com>
Cc: "H. Peter Anvin" <hpa@linux.intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [GIT PULL] x86/microcode for v3.9-rc1
Date: Fri, 1 Mar 2013 00:52:38 +0100 [thread overview]
Message-ID: <20130228235238.GF9767@pd.tnic> (raw)
In-Reply-To: <3E5A0FA7E9CA944F9D5414FEC6C71220528AAA95@ORSMSX105.amr.corp.intel.com>
On Thu, Feb 28, 2013 at 11:28:06PM +0000, Yu, Fenghua wrote:
>> gcc is warning that the function is using lots of stack. In the
>> context that it is running in this is most likely not a problem
>> given how small the overrun is, but it might be worthwhile to see if
>> there is anything which can be moved out to static storage or some
>> other variant.
>>
>> Static storage is tricky to use in this context since it runs in
>> flat linear mode (without paging, and therefore without the +3 GB
>> offset) on 32 bits.
>
> The errors might be related to the arrays defined
> mc_saved_tmp[MAX_UCODE_COUNT].
>
> Could you send your .config to me so that I can reproduce the issue?
> I don't see the issue in my build environment and in Fengguang's test
> environment.
Ok, forget it. It was some local .config file corruption which caused
include/generated/autoconf.h and include/config/auto.conf to have a line
CONFIG_FRAME_WARN=1024
which would cause the warnings.
The 1024 ceiling value is also consistent with the warnings complaining
about something being > 1024 bytes.
Default CONFIG_FRAME_WARN on x86_64 is 2048 which explains why those
warnings never trigger on 64-bit.
So, we all can relax ourselves, especially I :-)
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-02-28 23:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 4:56 [GIT PULL] x86/microcode for v3.9-rc1 H. Peter Anvin
2013-02-28 23:16 ` Borislav Petkov
2013-02-28 23:22 ` H. Peter Anvin
2013-02-28 23:28 ` Yu, Fenghua
2013-02-28 23:52 ` Borislav Petkov [this message]
2013-03-01 0:09 ` Yu, Fenghua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130228235238.GF9767@pd.tnic \
--to=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.