From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Fenghua Yu <fenghua.yu@intel.com>, Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [GIT PULL] x86/microcode for v3.9-rc1
Date: Thu, 28 Feb 2013 15:22:58 -0800 [thread overview]
Message-ID: <512FE6D2.7070704@zytor.com> (raw)
In-Reply-To: <20130228231608.GA17468@pd.tnic>
On 02/28/2013 03:16 PM, Borislav Petkov wrote:
>
> Some strange build warnings I get here:
>
> arch/x86/kernel/microcode_intel_early.c: In function `get_matching_model_microcode.isra.3.constprop.9':
> arch/x86/kernel/microcode_intel_early.c:366:1: warning: the frame size of 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=]
> arch/x86/kernel/microcode_intel_early.c: In function `save_mc_for_early':
> arch/x86/kernel/microcode_intel_early.c:550:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=]
>
> What's up?
>
gcc is warning that the function is using lots of stack. In the context
that it is running in this is most likely not a problem given how small
the overrun is, but it might be worthwhile to see if there is anything
which can be moved out to static storage or some other variant.
Static storage is tricky to use in this context since it runs in flat
linear mode (without paging, and therefore without the +3 GB offset) on
32 bits.
-hpa
next prev parent reply other threads:[~2013-02-28 23:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 4:56 [GIT PULL] x86/microcode for v3.9-rc1 H. Peter Anvin
2013-02-28 23:16 ` Borislav Petkov
2013-02-28 23:22 ` H. Peter Anvin [this message]
2013-02-28 23:28 ` Yu, Fenghua
2013-02-28 23:52 ` Borislav Petkov
2013-03-01 0:09 ` Yu, Fenghua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512FE6D2.7070704@zytor.com \
--to=hpa@zytor.com \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.