From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] shmem: fix build regression
Date: Fri, 1 Mar 2013 00:37:41 +0000 [thread overview]
Message-ID: <20130301003740.GS4503@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20130228163111.5d61d391.akpm@linux-foundation.org>
On Thu, Feb 28, 2013 at 04:31:11PM -0800, Andrew Morton wrote:
> -#ifndef CONFIG_MMU
> - error = ramfs_nommu_expand_for_mapping(inode, size);
> - res = ERR_PTR(error);
> - if (error)
> +
> + res = ERR_PTR(ramfs_nommu_expand_for_mapping(inode, size));
> + if (IS_ERR(res))
> goto put_dentry;
My variant of fix leaves #ifndef in place and makes the check if (res) goto...
I'm not opposed to killing the ifndef, but I think it should be a separate
patch.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] shmem: fix build regression
Date: Fri, 1 Mar 2013 00:37:41 +0000 [thread overview]
Message-ID: <20130301003740.GS4503@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20130228163111.5d61d391.akpm@linux-foundation.org>
On Thu, Feb 28, 2013 at 04:31:11PM -0800, Andrew Morton wrote:
> -#ifndef CONFIG_MMU
> - error = ramfs_nommu_expand_for_mapping(inode, size);
> - res = ERR_PTR(error);
> - if (error)
> +
> + res = ERR_PTR(ramfs_nommu_expand_for_mapping(inode, size));
> + if (IS_ERR(res))
> goto put_dentry;
My variant of fix leaves #ifndef in place and makes the check if (res) goto...
I'm not opposed to killing the ifndef, but I think it should be a separate
patch.
next prev parent reply other threads:[~2013-03-01 0:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 23:17 [PATCH] shmem: fix build regression Wolfram Sang
2013-02-28 23:17 ` Wolfram Sang
2013-03-01 0:31 ` Andrew Morton
2013-03-01 0:31 ` Andrew Morton
2013-03-01 0:37 ` Al Viro [this message]
2013-03-01 0:37 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130301003740.GS4503@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.