All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Linus Walleij <linus.walleij@linaro.org>,
	Thomas Abraham <thomas.abraham@linaro.org>
Cc: linux-samsung-soc@vger.kernel.org,
	Kukjin Kim <kgene.kim@samsung.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: S3C24XX: handle s3c2412 eints using new infrastructure
Date: Sat, 02 Mar 2013 20:10:04 +0000	[thread overview]
Message-ID: <20130302201004.95D033E20E9@localhost> (raw)
In-Reply-To: <CACRpkdZ5dxyXhrNUJDEzPoDOGRn_50ZuaHW4ZpguSyApQvh7hw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]

On Fri, 15 Feb 2013 15:48:52 +0100, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Tue, Feb 12, 2013 at 1:05 AM, Heiko Stübner <heiko@sntech.de> wrote:
> 
> > The s3c2412 handles the eints 0 to 3 different than all the other SoCs
> > of the 24xx range. These eints must be acked and masked in the regular
> > bits as well as the bits 0 to 3 of the eint registers, which are unused
> > on the other SoCs.
> >
> > This of course can be realized using the new infrastructure with the
> > eint bits in the main register being the parent interrupts of the
> > same bits in the eint register.
> >
> > The s3c2412 therefore gets its own IRQ_EINT0 to 4 constants that
> > reside in the newly created gap before IRQ_EINT4. gpio-samsung, as the
> > only user of these is modified to return the correct values when
> > handling gpio_to_irq requests on s3c2412 based machines.
> >
> > Due to lack of hardware this is compile tested only, but should
> > hopefully work as intended.
> >
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> 
> We definately need an ACK from some Samsung maintainer for
> this patch...

Pish, I'm not taking this. It's all arch/arm code with a 6 line
drivers/gpio change. Instead:

Acked-by: Grant Likely <grant.likely@secretlab.ca>

g.


[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: S3C24XX: handle s3c2412 eints using new infrastructure
Date: Sat, 02 Mar 2013 20:10:04 +0000	[thread overview]
Message-ID: <20130302201004.95D033E20E9@localhost> (raw)
In-Reply-To: <CACRpkdZ5dxyXhrNUJDEzPoDOGRn_50ZuaHW4ZpguSyApQvh7hw@mail.gmail.com>

On Fri, 15 Feb 2013 15:48:52 +0100, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Tue, Feb 12, 2013 at 1:05 AM, Heiko St??bner <heiko@sntech.de> wrote:
> 
> > The s3c2412 handles the eints 0 to 3 different than all the other SoCs
> > of the 24xx range. These eints must be acked and masked in the regular
> > bits as well as the bits 0 to 3 of the eint registers, which are unused
> > on the other SoCs.
> >
> > This of course can be realized using the new infrastructure with the
> > eint bits in the main register being the parent interrupts of the
> > same bits in the eint register.
> >
> > The s3c2412 therefore gets its own IRQ_EINT0 to 4 constants that
> > reside in the newly created gap before IRQ_EINT4. gpio-samsung, as the
> > only user of these is modified to return the correct values when
> > handling gpio_to_irq requests on s3c2412 based machines.
> >
> > Due to lack of hardware this is compile tested only, but should
> > hopefully work as intended.
> >
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> 
> We definately need an ACK from some Samsung maintainer for
> this patch...

Pish, I'm not taking this. It's all arch/arm code with a 6 line
drivers/gpio change. Instead:

Acked-by: Grant Likely <grant.likely@secretlab.ca>

g.

  parent reply	other threads:[~2013-03-02 20:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-12  0:02 [PATCH 0/3] ARM: S3C24XX: integrate special s3c2412 eint handling Heiko Stübner
2013-02-12  0:02 ` Heiko Stübner
2013-02-12  0:03 ` [PATCH 1/3] ARM: S3C24XX: include first 4 bits of the eint register in irq mapping Heiko Stübner
2013-02-12  0:03   ` Heiko Stübner
2013-02-12  0:03 ` [PATCH 2/3] ARM: S3C24XX: add soc_is_s3c2412 option Heiko Stübner
2013-02-12  0:03   ` Heiko Stübner
2013-02-12  0:05 ` [PATCH 3/3] ARM: S3C24XX: handle s3c2412 eints using new infrastructure Heiko Stübner
2013-02-12  0:05   ` Heiko Stübner
2013-02-15 14:48   ` Linus Walleij
2013-02-15 14:48     ` Linus Walleij
2013-02-15 15:26     ` Heiko Stübner
2013-02-15 15:26       ` Heiko Stübner
2013-03-02 20:10     ` Grant Likely [this message]
2013-03-02 20:10       ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130302201004.95D033E20E9@localhost \
    --to=grant.likely@secretlab.ca \
    --cc=kgene.kim@samsung.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=thomas.abraham@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.