From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org,
stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Don't clobber crtc->fb when queue_flip fails
Date: Sun, 3 Mar 2013 19:52:33 +0100 [thread overview]
Message-ID: <20130303185233.GS9021@phenom.ffwll.local> (raw)
In-Reply-To: <20130222151300.GH23278@cantiga.alporthouse.com>
On Fri, Feb 22, 2013 at 03:13:00PM +0000, Chris Wilson wrote:
> On Fri, Feb 22, 2013 at 04:53:38PM +0200, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Restore crtc->fb to the old framebuffer if queue_flip fails.
> >
> > While at it, kill the pointless intel_fb temp variable.
> >
> > v2: Update crtc->fb before queue_flip and restore it back
> > after a failure.
> >
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Lgtm, either v1 or v2 gets my
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> (with a slight preference towards v2 for the sake of paranoia)
Picked up for -fixes, thanks for the patch. And can I wish for an i-g-t
for this?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-03-03 18:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 14:53 [PATCH v2] drm/i915: Don't clobber crtc->fb when queue_flip fails ville.syrjala
2013-02-22 15:13 ` [Intel-gfx] " Chris Wilson
2013-03-03 18:52 ` Daniel Vetter [this message]
2013-03-04 12:47 ` Ville Syrjälä
2013-02-25 13:25 ` Mika Kuoppala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130303185233.GS9021@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.