All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Ben Hutchings <ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
Cc: Greg KH
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	stable <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	shuahkhan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	shuah.khan-VXdhtT5mjnY@public.gmane.org
Subject: Re: [PATCH 3.2] iommu/amd: Initialize device table after dma_ops
Date: Sun, 3 Mar 2013 23:58:28 +0100	[thread overview]
Message-ID: <20130303225828.GA22602@8bytes.org> (raw)
In-Reply-To: <1362265235.3768.156.camel-nDn/Rdv9kqW9Jme8/bJn5UCKIB8iOfG2tUK59QYPAWc@public.gmane.org>

Hi Ben,

On Sat, Mar 02, 2013 at 11:00:35PM +0000, Ben Hutchings wrote:
> I'm not convinced about this backport, because the order of
> initialisation already changed a lot after 3.2 and before the upstream
> commit.  So I'm going to wait for Joerg to confirm that this makes sense
> before adding it to the patch queue.

The patch looks good, it fixes a race condition during amd_iommu
initialization. I'll also gave the backport a test to be sure it
doesn't break anything.

Thanks,

	Joerg

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: shuah.khan@hp.com, iommu@lists.linux-foundation.org,
	LKML <linux-kernel@vger.kernel.org>,
	stable <stable@vger.kernel.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	shuahkhan@gmail.com
Subject: Re: [PATCH 3.2] iommu/amd: Initialize device table after dma_ops
Date: Sun, 3 Mar 2013 23:58:28 +0100	[thread overview]
Message-ID: <20130303225828.GA22602@8bytes.org> (raw)
In-Reply-To: <1362265235.3768.156.camel@deadeye.wl.decadent.org.uk>

Hi Ben,

On Sat, Mar 02, 2013 at 11:00:35PM +0000, Ben Hutchings wrote:
> I'm not convinced about this backport, because the order of
> initialisation already changed a lot after 3.2 and before the upstream
> commit.  So I'm going to wait for Joerg to confirm that this makes sense
> before adding it to the patch queue.

The patch looks good, it fixes a race condition during amd_iommu
initialization. I'll also gave the backport a test to be sure it
doesn't break anything.

Thanks,

	Joerg



  parent reply	other threads:[~2013-03-03 22:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-28 21:39 [PATCH 3.2] iommu/amd: Initialize device table after dma_ops Shuah Khan
2013-02-28 21:39 ` Shuah Khan
2013-03-02 23:00 ` Ben Hutchings
     [not found]   ` <1362265235.3768.156.camel-nDn/Rdv9kqW9Jme8/bJn5UCKIB8iOfG2tUK59QYPAWc@public.gmane.org>
2013-03-03 22:58     ` Joerg Roedel [this message]
2013-03-03 22:58       ` Joerg Roedel
     [not found]       ` <20130303225828.GA22602-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-03-17  3:42         ` Ben Hutchings
2013-03-17  3:42           ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130303225828.GA22602@8bytes.org \
    --to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
    --cc=ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=shuah.khan-VXdhtT5mjnY@public.gmane.org \
    --cc=shuahkhan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.