* [PATCH] pch_dma: Use GFP_ATOMIC because called from interrupt context
@ 2013-02-12 2:25 Tomoya MORINAGA
2013-02-20 2:26 ` Tomoya MORINAGA
0 siblings, 1 reply; 4+ messages in thread
From: Tomoya MORINAGA @ 2013-02-12 2:25 UTC (permalink / raw)
To: Dan Williams, Vinod Koul, linux-kernel; +Cc: Tomoya MORINAGA
pdc_desc_get() is called from pd_prep_slave_sg, and the function is
called from interrupt context(e.g. Uart driver "pch_uart.c").
In fact, I saw kernel error message.
So, GFP_ATOMIC must be used not GFP_NOIO.
Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
---
drivers/dma/pch_dma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
index 987ab5c..d5cbd44 100644
--- a/drivers/dma/pch_dma.c
+++ b/drivers/dma/pch_dma.c
@@ -476,7 +476,7 @@ static struct pch_dma_desc *pdc_desc_get(struct pch_dma_chan *pd_chan)
dev_dbg(chan2dev(&pd_chan->chan), "scanned %d descriptors\n", i);
if (!ret) {
- ret = pdc_alloc_desc(&pd_chan->chan, GFP_NOIO);
+ ret = pdc_alloc_desc(&pd_chan->chan, GFP_ATOMIC);
if (ret) {
spin_lock(&pd_chan->lock);
pd_chan->descs_allocated++;
--
1.7.4.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] pch_dma: Use GFP_ATOMIC because called from interrupt context
2013-02-12 2:25 [PATCH] pch_dma: Use GFP_ATOMIC because called from interrupt context Tomoya MORINAGA
@ 2013-02-20 2:26 ` Tomoya MORINAGA
2013-02-20 5:57 ` Vinod Koul
2013-03-04 4:57 ` Vinod Koul
0 siblings, 2 replies; 4+ messages in thread
From: Tomoya MORINAGA @ 2013-02-20 2:26 UTC (permalink / raw)
To: Vinod Koul, linux-kernel
Hi
Could you review this patch ?
8 days have passed...
thanks,
tomoya
On Tue, Feb 12, 2013 at 11:25 AM, Tomoya MORINAGA <tomoya.rohm@gmail.com> wrote:
> pdc_desc_get() is called from pd_prep_slave_sg, and the function is
> called from interrupt context(e.g. Uart driver "pch_uart.c").
> In fact, I saw kernel error message.
> So, GFP_ATOMIC must be used not GFP_NOIO.
>
> Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
> ---
> drivers/dma/pch_dma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
> index 987ab5c..d5cbd44 100644
> --- a/drivers/dma/pch_dma.c
> +++ b/drivers/dma/pch_dma.c
> @@ -476,7 +476,7 @@ static struct pch_dma_desc *pdc_desc_get(struct pch_dma_chan *pd_chan)
> dev_dbg(chan2dev(&pd_chan->chan), "scanned %d descriptors\n", i);
>
> if (!ret) {
> - ret = pdc_alloc_desc(&pd_chan->chan, GFP_NOIO);
> + ret = pdc_alloc_desc(&pd_chan->chan, GFP_ATOMIC);
> if (ret) {
> spin_lock(&pd_chan->lock);
> pd_chan->descs_allocated++;
> --
> 1.7.4.4
--
ROHM Co., Ltd.
tomoya
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pch_dma: Use GFP_ATOMIC because called from interrupt context
2013-02-20 2:26 ` Tomoya MORINAGA
@ 2013-02-20 5:57 ` Vinod Koul
2013-03-04 4:57 ` Vinod Koul
1 sibling, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2013-02-20 5:57 UTC (permalink / raw)
To: Tomoya MORINAGA; +Cc: linux-kernel
On Wed, Feb 20, 2013 at 11:26:54AM +0900, Tomoya MORINAGA wrote:
> Hi
>
> Could you review this patch ?
> 8 days have passed...
Sorry looks like I missed it. I have queued it up and will apply after -rc1
--
~Vinod
>
> thanks,
> tomoya
>
> On Tue, Feb 12, 2013 at 11:25 AM, Tomoya MORINAGA <tomoya.rohm@gmail.com> wrote:
> > pdc_desc_get() is called from pd_prep_slave_sg, and the function is
> > called from interrupt context(e.g. Uart driver "pch_uart.c").
> > In fact, I saw kernel error message.
> > So, GFP_ATOMIC must be used not GFP_NOIO.
> >
> > Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
> > ---
> > drivers/dma/pch_dma.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
> > index 987ab5c..d5cbd44 100644
> > --- a/drivers/dma/pch_dma.c
> > +++ b/drivers/dma/pch_dma.c
> > @@ -476,7 +476,7 @@ static struct pch_dma_desc *pdc_desc_get(struct pch_dma_chan *pd_chan)
> > dev_dbg(chan2dev(&pd_chan->chan), "scanned %d descriptors\n", i);
> >
> > if (!ret) {
> > - ret = pdc_alloc_desc(&pd_chan->chan, GFP_NOIO);
> > + ret = pdc_alloc_desc(&pd_chan->chan, GFP_ATOMIC);
> > if (ret) {
> > spin_lock(&pd_chan->lock);
> > pd_chan->descs_allocated++;
> > --
> > 1.7.4.4
>
> --
> ROHM Co., Ltd.
> tomoya
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pch_dma: Use GFP_ATOMIC because called from interrupt context
2013-02-20 2:26 ` Tomoya MORINAGA
2013-02-20 5:57 ` Vinod Koul
@ 2013-03-04 4:57 ` Vinod Koul
1 sibling, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2013-03-04 4:57 UTC (permalink / raw)
To: Tomoya MORINAGA; +Cc: linux-kernel
> On Tue, Feb 12, 2013 at 11:25 AM, Tomoya MORINAGA <tomoya.rohm@gmail.com> wrote:
> > pdc_desc_get() is called from pd_prep_slave_sg, and the function is
> > called from interrupt context(e.g. Uart driver "pch_uart.c").
> > In fact, I saw kernel error message.
> > So, GFP_ATOMIC must be used not GFP_NOIO.
> >
> > Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Applied, thanks
> > ---
> > drivers/dma/pch_dma.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
> > index 987ab5c..d5cbd44 100644
> > --- a/drivers/dma/pch_dma.c
> > +++ b/drivers/dma/pch_dma.c
> > @@ -476,7 +476,7 @@ static struct pch_dma_desc *pdc_desc_get(struct pch_dma_chan *pd_chan)
> > dev_dbg(chan2dev(&pd_chan->chan), "scanned %d descriptors\n", i);
> >
> > if (!ret) {
> > - ret = pdc_alloc_desc(&pd_chan->chan, GFP_NOIO);
> > + ret = pdc_alloc_desc(&pd_chan->chan, GFP_ATOMIC);
> > if (ret) {
> > spin_lock(&pd_chan->lock);
> > pd_chan->descs_allocated++;
> > --
> > 1.7.4.4
>
> --
> ROHM Co., Ltd.
> tomoya
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-04 4:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-12 2:25 [PATCH] pch_dma: Use GFP_ATOMIC because called from interrupt context Tomoya MORINAGA
2013-02-20 2:26 ` Tomoya MORINAGA
2013-02-20 5:57 ` Vinod Koul
2013-03-04 4:57 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.