From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: rjw@sisk.pl, Steve.Bannister@arm.com, linux-pm@vger.kernel.org,
Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com>,
Liviu.Dudau@arm.com, linux-kernel@vger.kernel.org,
cpufreq@vger.kernel.org, robin.randhawa@arm.com,
linux-arm-kernel@lists.infradead.org,
mark.hambleton@broadcom.com, linaro-kernel@lists.linaro.org,
charles.garcia-tobin@arm.com
Subject: Re: [PATCH] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue
Date: Tue, 5 Mar 2013 10:52:51 +0000 [thread overview]
Message-ID: <20130305105251.GL17833@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <f20e3c5e822c4bd28a3b71264d73143cc1f850b0.1362458878.git.viresh.kumar@linaro.org>
On Tue, Mar 05, 2013 at 12:52:41PM +0800, Viresh Kumar wrote:
> +static void put_cluster_clk_and_freq_table(u32 cluster)
> +{
> + if (!atomic_dec_return(&cluster_usage[cluster])) {
> + clk_put(clk[cluster]);
> + clk[cluster] = NULL;
What's the point in setting the clk to NULL?
> +static int get_cluster_clk_and_freq_table(u32 cluster)
> +{
> + char name[9] = "cluster";
> + int count;
> +
> + if (atomic_inc_return(&cluster_usage[cluster]) != 1)
> + return 0;
> +
> + freq_table[cluster] = arm_bL_ops->get_freq_tbl(cluster, &count);
> + if (!freq_table[cluster])
> + goto atomic_dec;
> +
> + name[7] = cluster + '0';
> + clk[cluster] = clk_get(NULL, name);
> + if (!IS_ERR_OR_NULL(clk[cluster])) {
NAK. Two reasons.
1. IS_ERR_OR_NULL. You know about this, it's been on the list several
times.
2. Maybe clk_get_sys() rather than clk_get() and use a sensible device
name ("cpu-cluster.%u" maybe) rather than a connection name with a
NULL device?
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue
Date: Tue, 5 Mar 2013 10:52:51 +0000 [thread overview]
Message-ID: <20130305105251.GL17833@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <f20e3c5e822c4bd28a3b71264d73143cc1f850b0.1362458878.git.viresh.kumar@linaro.org>
On Tue, Mar 05, 2013 at 12:52:41PM +0800, Viresh Kumar wrote:
> +static void put_cluster_clk_and_freq_table(u32 cluster)
> +{
> + if (!atomic_dec_return(&cluster_usage[cluster])) {
> + clk_put(clk[cluster]);
> + clk[cluster] = NULL;
What's the point in setting the clk to NULL?
> +static int get_cluster_clk_and_freq_table(u32 cluster)
> +{
> + char name[9] = "cluster";
> + int count;
> +
> + if (atomic_inc_return(&cluster_usage[cluster]) != 1)
> + return 0;
> +
> + freq_table[cluster] = arm_bL_ops->get_freq_tbl(cluster, &count);
> + if (!freq_table[cluster])
> + goto atomic_dec;
> +
> + name[7] = cluster + '0';
> + clk[cluster] = clk_get(NULL, name);
> + if (!IS_ERR_OR_NULL(clk[cluster])) {
NAK. Two reasons.
1. IS_ERR_OR_NULL. You know about this, it's been on the list several
times.
2. Maybe clk_get_sys() rather than clk_get() and use a sensible device
name ("cpu-cluster.%u" maybe) rather than a connection name with a
NULL device?
next prev parent reply other threads:[~2013-03-05 10:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 4:52 [PATCH] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue Viresh Kumar
2013-03-05 4:52 ` Viresh Kumar
2013-03-05 10:52 ` Russell King - ARM Linux [this message]
2013-03-05 10:52 ` Russell King - ARM Linux
2013-03-05 16:38 ` Viresh Kumar
2013-03-05 16:38 ` Viresh Kumar
2013-03-06 17:25 ` Russell King - ARM Linux
2013-03-06 17:25 ` Russell King - ARM Linux
2013-03-06 23:09 ` Viresh Kumar
2013-03-06 23:09 ` Viresh Kumar
2013-03-07 0:32 ` Viresh Kumar
2013-03-07 0:32 ` Viresh Kumar
2013-03-07 0:49 ` Harvey Harrison
2013-03-07 0:49 ` Harvey Harrison
2013-03-07 1:46 ` Viresh Kumar
2013-03-07 1:46 ` Viresh Kumar
2013-03-07 0:51 ` Russell King - ARM Linux
2013-03-07 0:51 ` Russell King - ARM Linux
2013-03-07 2:03 ` Viresh Kumar
2013-03-07 2:03 ` Viresh Kumar
2013-03-07 11:49 ` Russell King - ARM Linux
2013-03-07 11:49 ` Russell King - ARM Linux
2013-03-07 17:04 ` Viresh Kumar
2013-03-07 17:04 ` Viresh Kumar
2013-03-07 1:46 ` Olof Johansson
2013-03-07 1:46 ` Olof Johansson
2013-03-07 1:50 ` Olof Johansson
2013-03-07 1:50 ` Olof Johansson
2013-03-07 2:29 ` Viresh Kumar
2013-03-07 2:29 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130305105251.GL17833@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Liviu.Dudau@arm.com \
--cc=Steve.Bannister@arm.com \
--cc=charles.garcia-tobin@arm.com \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.hambleton@broadcom.com \
--cc=rjw@sisk.pl \
--cc=robin.randhawa@arm.com \
--cc=sudeep.karkadanagesha@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.