All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Sander Eikelenboom <linux@eikelenboom.it>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: Re: linux-3.9-rc1: WARNING: at drivers/pci/pci.c:1397 pci_disable_device+0x88/0xa0() Device pciback disabling already-disabled device
Date: Tue, 5 Mar 2013 11:20:28 -0500	[thread overview]
Message-ID: <20130305162028.GD15668@phenom.dumpdata.com> (raw)
In-Reply-To: <79369661.20130304234323@eikelenboom.it>

On Mon, Mar 04, 2013 at 11:43:23PM +0100, Sander Eikelenboom wrote:
> Hi Konrad,
> 
> While shuting down a HVM guest with pci devices passed through i get this one below ...
> Both dom0 and domU run the same linux-3.9-rc1 (+ Thomas Gleixner patches)

OK, that one looks pretty easy to fix:
> [  759.027692] Hardware name: MS-7640
> [  759.034233] Device pciback
> [  759.034233] disabling already-disabled device
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Could you try the below patch please?

diff --git a/drivers/xen/xen-pciback/pciback_ops.c b/drivers/xen/xen-pciback/pciback_ops.c
index 37c1f82..b98cf0c 100644
--- a/drivers/xen/xen-pciback/pciback_ops.c
+++ b/drivers/xen/xen-pciback/pciback_ops.c
@@ -113,7 +113,8 @@ void xen_pcibk_reset_device(struct pci_dev *dev)
 		if (dev->msi_enabled)
 			pci_disable_msi(dev);
 #endif
-		pci_disable_device(dev);
+		if (pci_is_enabled(dev))
+			pci_disable_device(dev);
 
 		pci_write_config_word(dev, PCI_COMMAND, 0);

  reply	other threads:[~2013-03-05 16:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-04 22:43 linux-3.9-rc1: WARNING: at drivers/pci/pci.c:1397 pci_disable_device+0x88/0xa0() Device pciback disabling already-disabled device Sander Eikelenboom
2013-03-05 16:20 ` Konrad Rzeszutek Wilk [this message]
2013-03-05 17:28   ` Sander Eikelenboom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130305162028.GD15668@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=linux@eikelenboom.it \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.