From: Andrew Shewmaker <agshew@gmail.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
alan@lxorguk.ukuu.org.uk, simon.jeons@gmail.com,
ric.masonn@gmail.com
Subject: [PATCH v4 001/002] mm: limit growth of 3% hardcoded other user reserve
Date: Tue, 5 Mar 2013 18:38:12 -0500 [thread overview]
Message-ID: <20130305233811.GA1948@localhost.localdomain> (raw)
Limit the growth of the memory reserved for other processes
to the smaller of 3% or 8MB.
This affects only OVERCOMMIT_NEVER.
Signed-off-by: Andrew Shewmaker <agshew@gmail.com>
---
Rebased onto v3.8-mmotm-2013-03-01-15-50
No longer assumes 4kb pages.
Code duplicated for nommu.
diff --git a/mm/mmap.c b/mm/mmap.c
index 49dc7d5..4eb2b1a 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -184,9 +184,11 @@ int __vm_enough_memory(struct mm_struct *mm, long pages, int cap_sys_admin)
allowed += total_swap_pages;
/* Don't let a single process grow too big:
- leave 3% of the size of this process for other processes */
+ * leave the smaller of 3% of the size of this process
+ * or 8MB for other processes
+ */
if (mm)
- allowed -= mm->total_vm / 32;
+ allowed -= min(mm->total_vm / 32, 1 << (23 - PAGE_SHIFT));
if (percpu_counter_read_positive(&vm_committed_as) < allowed)
return 0;
diff --git a/mm/nommu.c b/mm/nommu.c
index f5d57a3..a93d214 100644
--- a/mm/nommu.c
+++ b/mm/nommu.c
@@ -1945,9 +1945,11 @@ int __vm_enough_memory(struct mm_struct *mm, long pages, int cap_sys_admin)
allowed += total_swap_pages;
/* Don't let a single process grow too big:
- leave 3% of the size of this process for other processes */
+ * leave the smaller of 3% of the size of this process
+ * or 8MB for other processes
+ */
if (mm)
- allowed -= mm->total_vm / 32;
+ allowed -= min(mm->total_vm / 32, 1 << (23 - PAGE_SHIFT));
if (percpu_counter_read_positive(&vm_committed_as) < allowed)
return 0;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Shewmaker <agshew@gmail.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
alan@lxorguk.ukuu.org.uk, simon.jeons@gmail.com,
ric.masonn@gmail.com
Subject: [PATCH v4 001/002] mm: limit growth of 3% hardcoded other user reserve
Date: Tue, 5 Mar 2013 18:38:12 -0500 [thread overview]
Message-ID: <20130305233811.GA1948@localhost.localdomain> (raw)
Limit the growth of the memory reserved for other processes
to the smaller of 3% or 8MB.
This affects only OVERCOMMIT_NEVER.
Signed-off-by: Andrew Shewmaker <agshew@gmail.com>
---
Rebased onto v3.8-mmotm-2013-03-01-15-50
No longer assumes 4kb pages.
Code duplicated for nommu.
diff --git a/mm/mmap.c b/mm/mmap.c
index 49dc7d5..4eb2b1a 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -184,9 +184,11 @@ int __vm_enough_memory(struct mm_struct *mm, long pages, int cap_sys_admin)
allowed += total_swap_pages;
/* Don't let a single process grow too big:
- leave 3% of the size of this process for other processes */
+ * leave the smaller of 3% of the size of this process
+ * or 8MB for other processes
+ */
if (mm)
- allowed -= mm->total_vm / 32;
+ allowed -= min(mm->total_vm / 32, 1 << (23 - PAGE_SHIFT));
if (percpu_counter_read_positive(&vm_committed_as) < allowed)
return 0;
diff --git a/mm/nommu.c b/mm/nommu.c
index f5d57a3..a93d214 100644
--- a/mm/nommu.c
+++ b/mm/nommu.c
@@ -1945,9 +1945,11 @@ int __vm_enough_memory(struct mm_struct *mm, long pages, int cap_sys_admin)
allowed += total_swap_pages;
/* Don't let a single process grow too big:
- leave 3% of the size of this process for other processes */
+ * leave the smaller of 3% of the size of this process
+ * or 8MB for other processes
+ */
if (mm)
- allowed -= mm->total_vm / 32;
+ allowed -= min(mm->total_vm / 32, 1 << (23 - PAGE_SHIFT));
if (percpu_counter_read_positive(&vm_committed_as) < allowed)
return 0;
next reply other threads:[~2013-03-05 23:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 23:38 Andrew Shewmaker [this message]
2013-03-05 23:38 ` [PATCH v4 001/002] mm: limit growth of 3% hardcoded other user reserve Andrew Shewmaker
2013-03-05 23:46 ` Simon Jeons
2013-03-05 23:46 ` Simon Jeons
2013-03-06 0:37 ` Andrew Shewmaker
2013-03-06 0:37 ` Andrew Shewmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130305233811.GA1948@localhost.localdomain \
--to=agshew@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ric.masonn@gmail.com \
--cc=simon.jeons@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.