From: "Heiko Stübner" <heiko@sntech.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Thomas Abraham <thomas.abraham@linaro.org>,
alsa-devel@alsa-project.org, lrg@ti.com,
jassisinghbrar@gmail.com, linus.walleij@linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
t.figa@samsung.com, patches@linaro.org
Subject: Re: [PATCH] ASoC: samsung: let device core setup the default pin configuration
Date: Wed, 6 Mar 2013 12:42:09 +0100 [thread overview]
Message-ID: <201303061242.09978.heiko@sntech.de> (raw)
In-Reply-To: <20130306113741.GA19556@opensource.wolfsonmicro.com>
Am Mittwoch, 6. März 2013, 12:37:43 schrieb Mark Brown:
> On Wed, Mar 06, 2013 at 05:25:51PM +0530, Thomas Abraham wrote:
> > With device core now able to setup the default pin configuration,
> > the pin configuration code based on the deprecated Samsung specific
> > gpio bindings in i2s driver is removed.
>
> There's rather a lot of non-DT Samsung platforms...
I think the real non-dt platforms won't be affected.
+ if (i2s_pdata->cfg_gpio && i2s_pdata->cfg_gpio(pdev)) {
+ dev_err(&pdev->dev, "Unable to configure gpio\n");
+ ret = -EINVAL;
+ goto err;
is still there for them.
What is going away is the deprecated non-pinctrl way to setup the pins on dt
platforms.
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: samsung: let device core setup the default pin configuration
Date: Wed, 6 Mar 2013 12:42:09 +0100 [thread overview]
Message-ID: <201303061242.09978.heiko@sntech.de> (raw)
In-Reply-To: <20130306113741.GA19556@opensource.wolfsonmicro.com>
Am Mittwoch, 6. M?rz 2013, 12:37:43 schrieb Mark Brown:
> On Wed, Mar 06, 2013 at 05:25:51PM +0530, Thomas Abraham wrote:
> > With device core now able to setup the default pin configuration,
> > the pin configuration code based on the deprecated Samsung specific
> > gpio bindings in i2s driver is removed.
>
> There's rather a lot of non-DT Samsung platforms...
I think the real non-dt platforms won't be affected.
+ if (i2s_pdata->cfg_gpio && i2s_pdata->cfg_gpio(pdev)) {
+ dev_err(&pdev->dev, "Unable to configure gpio\n");
+ ret = -EINVAL;
+ goto err;
is still there for them.
What is going away is the deprecated non-pinctrl way to setup the pins on dt
platforms.
next prev parent reply other threads:[~2013-03-06 11:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 11:55 [PATCH] ASoC: samsung: let device core setup the default pin configuration Thomas Abraham
2013-03-06 11:55 ` Thomas Abraham
2013-03-06 11:37 ` Mark Brown
2013-03-06 11:37 ` Mark Brown
2013-03-06 11:42 ` Heiko Stübner [this message]
2013-03-06 11:42 ` Heiko Stübner
2013-03-06 11:49 ` Mark Brown
2013-03-06 11:49 ` Mark Brown
2013-03-06 11:52 ` Thomas Abraham
2013-03-06 11:52 ` Thomas Abraham
2013-03-07 8:14 ` Linus Walleij
2013-03-07 8:14 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303061242.09978.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jassisinghbrar@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lrg@ti.com \
--cc=patches@linaro.org \
--cc=t.figa@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.