From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: David Brown <davidb@codeaurora.org>
Cc: Kenneth Heitke <kheitke@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/6] platform-drivers: msm: add single-wire serial bus interface (SSBI) driver
Date: Thu, 7 Mar 2013 14:01:17 +0800 [thread overview]
Message-ID: <20130307060117.GA31687@kroah.com> (raw)
In-Reply-To: <8yawqtjvl8y.fsf@huya.qualcomm.com>
On Wed, Mar 06, 2013 at 09:20:45PM -0800, David Brown wrote:
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
>
> > On Wed, Mar 06, 2013 at 04:29:42PM -0800, David Brown wrote:
> >> +menu "Qualcomm MSM SSBI bus support"
> >> + depends on ARCH_MSM
> >
> > Why?
>
> In the sense that ARCH_MSM are the only devices that ever were, or ever
> will be made with this device. It doesn't strictly depend on it, but do
> we want to clutter the config for everything else.
It's not "clutter". You want me to build this on other platforms, to
catch api and other types of build breakages. This is the way for
almost all Linux drivers.
> >> +config MSM_SSBI
> >> + bool "Qualcomm Single-wire Serial Bus Interface (SSBI)"
> >
> > Why can't this be a module?
>
> Without this device, the PMIC drivers won't work, regulators can't be
> turned on, and most of the other devices won't work. I can try if it
> can still be made a module, and it might be good at exercising the
> deferred probe mechanism.
If the PMIC drivers are dependant on the symbols in this module, there
should not be any problems, right?
> So, a deeper question. I've resent this driver with minimal change.
> I've also made some other changes as patches afterwards. Do we want
> these squashed into a single patch, or the initial one (not authored by
> me) followed by updates?
To preserve the authorship, you might want to fix this stuff with
follow-on patches. As long as the original patch can build properly.
> >> +static struct platform_driver msm_ssbi_driver = {
> >> + .probe = msm_ssbi_probe,
> >> + .remove = __exit_p(msm_ssbi_remove),
> >
> > You just oopsed if someone unbound your device from the driver from
> > userspace. Not good.
>
> I did catch this one in a later patch :-) I can clean it up in the
> driver, though, since it looks like some more work needs to go into
> this.
Yes, but it's very close, fix this all up and resend your series and all
should be fine.
Nice job,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] platform-drivers: msm: add single-wire serial bus interface (SSBI) driver
Date: Thu, 7 Mar 2013 14:01:17 +0800 [thread overview]
Message-ID: <20130307060117.GA31687@kroah.com> (raw)
In-Reply-To: <8yawqtjvl8y.fsf@huya.qualcomm.com>
On Wed, Mar 06, 2013 at 09:20:45PM -0800, David Brown wrote:
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
>
> > On Wed, Mar 06, 2013 at 04:29:42PM -0800, David Brown wrote:
> >> +menu "Qualcomm MSM SSBI bus support"
> >> + depends on ARCH_MSM
> >
> > Why?
>
> In the sense that ARCH_MSM are the only devices that ever were, or ever
> will be made with this device. It doesn't strictly depend on it, but do
> we want to clutter the config for everything else.
It's not "clutter". You want me to build this on other platforms, to
catch api and other types of build breakages. This is the way for
almost all Linux drivers.
> >> +config MSM_SSBI
> >> + bool "Qualcomm Single-wire Serial Bus Interface (SSBI)"
> >
> > Why can't this be a module?
>
> Without this device, the PMIC drivers won't work, regulators can't be
> turned on, and most of the other devices won't work. I can try if it
> can still be made a module, and it might be good at exercising the
> deferred probe mechanism.
If the PMIC drivers are dependant on the symbols in this module, there
should not be any problems, right?
> So, a deeper question. I've resent this driver with minimal change.
> I've also made some other changes as patches afterwards. Do we want
> these squashed into a single patch, or the initial one (not authored by
> me) followed by updates?
To preserve the authorship, you might want to fix this stuff with
follow-on patches. As long as the original patch can build properly.
> >> +static struct platform_driver msm_ssbi_driver = {
> >> + .probe = msm_ssbi_probe,
> >> + .remove = __exit_p(msm_ssbi_remove),
> >
> > You just oopsed if someone unbound your device from the driver from
> > userspace. Not good.
>
> I did catch this one in a later patch :-) I can clean it up in the
> driver, though, since it looks like some more work needs to go into
> this.
Yes, but it's very close, fix this all up and resend your series and all
should be fine.
Nice job,
greg k-h
next prev parent reply other threads:[~2013-03-07 6:01 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 0:29 [PATCH 0/6] Qualcomm SSBI bus driver David Brown
2013-03-07 0:29 ` David Brown
2013-03-07 0:29 ` [PATCH 1/6] platform-drivers: msm: add single-wire serial bus interface (SSBI) driver David Brown
2013-03-07 0:29 ` David Brown
2013-03-07 1:30 ` Greg Kroah-Hartman
2013-03-07 1:30 ` Greg Kroah-Hartman
2013-03-07 5:20 ` David Brown
2013-03-07 5:20 ` David Brown
2013-03-07 6:01 ` Greg Kroah-Hartman [this message]
2013-03-07 6:01 ` Greg Kroah-Hartman
2013-03-07 10:05 ` Sekhar Nori
2013-03-07 10:05 ` Sekhar Nori
2013-03-07 10:05 ` Sekhar Nori
2013-03-07 18:45 ` David Brown
2013-03-07 18:45 ` David Brown
2013-03-07 18:45 ` David Brown
2013-03-07 18:50 ` David Brown
2013-03-07 18:50 ` David Brown
2013-03-07 23:29 ` Greg Kroah-Hartman
2013-03-07 23:29 ` Greg Kroah-Hartman
2013-03-12 6:51 ` David Brown
2013-03-12 6:51 ` David Brown
2013-03-12 13:27 ` Greg Kroah-Hartman
2013-03-12 13:27 ` Greg Kroah-Hartman
2013-03-07 0:29 ` [PATCH 2/6] SSBI: Convert SSBI to device tree David Brown
2013-03-07 0:29 ` David Brown
2013-03-07 0:29 ` David Brown
2013-03-07 0:29 ` [PATCH 3/6] ssbi: Fix exit mismatch in remove function David Brown
2013-03-07 0:29 ` David Brown
2013-03-07 1:30 ` Greg Kroah-Hartman
2013-03-07 1:30 ` Greg Kroah-Hartman
2013-03-07 5:21 ` David Brown
2013-03-07 5:21 ` David Brown
2013-03-07 0:29 ` [PATCH 4/6] ssbi: Use regular init level David Brown
2013-03-07 0:29 ` David Brown
2013-03-07 0:29 ` [PATCH 5/6] ARM: msm: enable SSBI driver in defconfig David Brown
2013-03-07 0:29 ` David Brown
2013-03-07 0:29 ` David Brown
2013-03-07 0:29 ` [PATCH 6/6] RFC: SSBI: Simple pm8058 test driver David Brown
2013-03-07 0:29 ` David Brown
2013-03-12 18:41 ` [PATCH v2 0/11] Qualcomm SSBI bus driver David Brown
2013-03-12 18:41 ` David Brown
2013-03-12 18:41 ` [PATCH v2 01/11] platform-drivers: msm: add single-wire serial bus interface (SSBI) driver David Brown
2013-03-12 18:41 ` David Brown
2013-03-12 18:41 ` [PATCH v2 02/11] fix: Use EXPORT_SYMBOL_GPL David Brown
2013-03-12 18:41 ` David Brown
2013-03-12 18:41 ` David Brown
2013-03-12 18:41 ` [PATCH v2 03/11] ssbi: Fix exit mismatch in remove function David Brown
2013-03-12 18:41 ` David Brown
2013-03-12 18:41 ` David Brown
2013-03-12 18:41 ` [PATCH v2 04/11] ssbi: Allow compilation as a module David Brown
2013-03-12 18:41 ` David Brown
2013-03-12 18:41 ` [PATCH v2 05/11] SSBI: Convert SSBI to device tree David Brown
2013-03-12 18:41 ` David Brown
2013-03-12 20:46 ` Stephen Boyd
2013-03-12 20:46 ` Stephen Boyd
2013-03-12 18:41 ` [PATCH v2 06/11] ssbi: Comment the use of udelay() David Brown
2013-03-12 18:41 ` David Brown
2013-03-12 18:41 ` [PATCH v2 07/11] ssbi: Use regular init level David Brown
2013-03-12 18:41 ` David Brown
2013-03-12 18:41 ` David Brown
2013-03-12 20:26 ` Stephen Boyd
2013-03-12 20:26 ` Stephen Boyd
2013-03-12 18:41 ` [PATCH v2 08/11] ssbi: Remove extraneous logging David Brown
2013-03-12 18:41 ` David Brown
2013-03-12 18:41 ` [PATCH v2 09/11] SSBI: Remove MSM_ prefix from SSBI drivers David Brown
2013-03-12 18:41 ` David Brown
2013-03-12 18:41 ` [PATCH v2 10/11] MAINTAINERS: add ssbi David Brown
2013-03-12 18:41 ` David Brown
2013-03-12 18:41 ` David Brown
2013-03-25 17:40 ` [PATCH v2 0/11] Qualcomm SSBI bus driver Greg Kroah-Hartman
2013-03-25 17:40 ` Greg Kroah-Hartman
2013-03-12 20:12 ` [PATCH v2 11/11] RFC: SSBI: Simple pm8058 test driver David Brown
2013-03-12 20:12 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130307060117.GA31687@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davidb@codeaurora.org \
--cc=kheitke@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.