* Problem mounting efivarfs in 3.9
@ 2013-03-07 14:56 Seth Forshee
2013-03-07 15:00 ` shea
2013-03-07 15:02 ` Matt Fleming
0 siblings, 2 replies; 6+ messages in thread
From: Seth Forshee @ 2013-03-07 14:56 UTC (permalink / raw)
To: Matt Fleming; +Cc: linux-kernel, linux-efi, stable
Hi Matt,
I found myself unable to mount efivarfs on one of my machines in 3.9.
This is due to your patch to be more aggressive about validating
filenames. This machine had some crash dumps from pstore, which start
with "dump-type". However now efivars expects the guid to follow the
first '-' character, despite the fact that the efivars pstore code is
creating the file names starting with dump-type. Since these names fail
the validation the mount fails.
These changes are now in some of the stable releases as well (3.8.x at
minumum).
Thanks,
Seth
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Problem mounting efivarfs in 3.9
2013-03-07 14:56 Problem mounting efivarfs in 3.9 Seth Forshee
@ 2013-03-07 15:00 ` shea
2013-03-07 15:02 ` Matt Fleming
1 sibling, 0 replies; 6+ messages in thread
From: shea-yfkUTty7RcRWk0Htik3J/w @ 2013-03-07 15:00 UTC (permalink / raw)
To: Matt Fleming, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-efi-u79uwXL29TY76Z2rM5mHXA, stable-u79uwXL29TY76Z2rM5mHXA
Hi Seth,
On 2013-03-07 09:56, Seth Forshee wrote:
> Hi Matt,
>
> I found myself unable to mount efivarfs on one of my machines in 3.9.
> This is due to your patch to be more aggressive about validating
> filenames. This machine had some crash dumps from pstore, which start
> with "dump-type". However now efivars expects the guid to follow the
> first '-' character, despite the fact that the efivars pstore code is
> creating the file names starting with dump-type. Since these names
> fail
> the validation the mount fails.
>
A fix for this is already in mfleming/efi.git:
http://git.kernel.org/cgit/linux/kernel/git/mfleming/efi.git/commit/?h=urgent&id=123abd76edf56c02a76b46d3d673897177ef067b
. It's included in the efi-for-3.9-rc2 tag, and cc'd stable.
Cheers,
Shea Levy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Problem mounting efivarfs in 3.9
@ 2013-03-07 15:00 ` shea
0 siblings, 0 replies; 6+ messages in thread
From: shea @ 2013-03-07 15:00 UTC (permalink / raw)
To: Matt Fleming, linux-kernel, linux-efi, stable
Hi Seth,
On 2013-03-07 09:56, Seth Forshee wrote:
> Hi Matt,
>
> I found myself unable to mount efivarfs on one of my machines in 3.9.
> This is due to your patch to be more aggressive about validating
> filenames. This machine had some crash dumps from pstore, which start
> with "dump-type". However now efivars expects the guid to follow the
> first '-' character, despite the fact that the efivars pstore code is
> creating the file names starting with dump-type. Since these names
> fail
> the validation the mount fails.
>
A fix for this is already in mfleming/efi.git:
http://git.kernel.org/cgit/linux/kernel/git/mfleming/efi.git/commit/?h=urgent&id=123abd76edf56c02a76b46d3d673897177ef067b
. It's included in the efi-for-3.9-rc2 tag, and cc'd stable.
Cheers,
Shea Levy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Problem mounting efivarfs in 3.9
2013-03-07 14:56 Problem mounting efivarfs in 3.9 Seth Forshee
2013-03-07 15:00 ` shea
@ 2013-03-07 15:02 ` Matt Fleming
[not found] ` <1362668558.15011.203.camel-ZqTwcBeJ+wsBof6jY8KHXm7IUlhRatedral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
1 sibling, 1 reply; 6+ messages in thread
From: Matt Fleming @ 2013-03-07 15:02 UTC (permalink / raw)
To: Seth Forshee; +Cc: linux-kernel, linux-efi, stable, H. Peter Anvin, Ingo Molnar
On Thu, 2013-03-07 at 08:56 -0600, Seth Forshee wrote:
> Hi Matt,
>
> I found myself unable to mount efivarfs on one of my machines in 3.9.
> This is due to your patch to be more aggressive about validating
> filenames. This machine had some crash dumps from pstore, which start
> with "dump-type". However now efivars expects the guid to follow the
> first '-' character, despite the fact that the efivars pstore code is
> creating the file names starting with dump-type. Since these names fail
> the validation the mount fails.
A patch to allow pstore names is in the pull request I sent to Peter and
Ingo yesterday,
http://marc.info/?l=linux-kernel&m=136258373231608&w=2
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-03-07 15:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-07 14:56 Problem mounting efivarfs in 3.9 Seth Forshee
2013-03-07 15:00 ` shea-yfkUTty7RcRWk0Htik3J/w
2013-03-07 15:00 ` shea
2013-03-07 15:02 ` Matt Fleming
[not found] ` <1362668558.15011.203.camel-ZqTwcBeJ+wsBof6jY8KHXm7IUlhRatedral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-03-07 15:09 ` Seth Forshee
2013-03-07 15:09 ` Seth Forshee
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.