From: "Michael S. Tsirkin" <mst@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Anthony Liguori" <aliguori@us.ibm.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
libvir-list@redhat.com, "Stefan Hajnoczi" <stefanha@gmail.com>,
qemu-devel@nongnu.org, "Luiz Capitulino" <lcapitulino@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v4] qdev: DEVICE_DELETED event
Date: Thu, 7 Mar 2013 22:23:09 +0200 [thread overview]
Message-ID: <20130307202309.GA13088@redhat.com> (raw)
In-Reply-To: <87d2vbx9rz.fsf@blackfin.pond.sub.org>
On Thu, Mar 07, 2013 at 08:57:52PM +0100, Markus Armbruster wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
>
> > libvirt has a long-standing bug: when removing the device,
> > it can request removal but does not know when the
> > removal completes. Add an event so we can fix this in a robust way.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> Speaking as the acting QMP maintainer, just to avoid misunderstandings:
> there's disagreement on the event's design, namely when it should fire,
> and how it should name the device. I don't want the discussion
> preempted by a commit.
Yes, you are asking for more functionality, but can I add this in a
follow-up commit please? I prefer this patch as is, as it can be
backported to stable branches and downstreams. Upstream a follow up
patch can add fields and more triggers which won't apply to any
downstreams.
This patch will help resolve a set of serious long-standing bugs,
see e.g.
https://bugzilla.redhat.com/show_bug.cgi?id=813748
--
MST
next prev parent reply other threads:[~2013-03-07 20:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 18:46 [Qemu-devel] [PATCH v4] qdev: DEVICE_DELETED event Michael S. Tsirkin
2013-03-07 19:57 ` Markus Armbruster
2013-03-07 20:23 ` Michael S. Tsirkin [this message]
2013-03-08 7:58 ` Markus Armbruster
2013-03-08 13:36 ` Anthony Liguori
2013-03-11 17:39 ` Michael S. Tsirkin
2013-03-11 19:26 ` Anthony Liguori
2013-03-11 19:35 ` Michael S. Tsirkin
2013-03-10 9:30 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130307202309.GA13088@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=libvir-list@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.