[meta-browser][PATCH 0/1] chromium: add support for x86-64

[meta-browser][PATCH 0/1] chromium: add support for x86-64

[Laurentiu Palcu]

Hi,

I gave chromium a test on x86 architecture and, apparently, there was no
support for x86-64. So, I added it (didn't do much actually, just copied
the i586 gypi files and changed the target_arch to x64), built
core-image-sato for qemux86-64, and ran chrome. It worked just fine.

I also removed gtk+-native from the dependencies (there's no need for
the native gtk) and added gtk+ instead (this one is needed).

Please, review it and/or give it a test.

Thanks,
Laurentiu

Laurentiu Palcu (1):
  chromium: add support for x86-64

 .../chromium-24.0.1312.52/x86-64/include.gypi      |    5 +++++
 .../chromium-24.0.1312.52/x86-64/oe-defaults.gypi  |   15 +++++++++++++++
 recipes-browser/chromium/chromium_24.0.1312.52.bb  |    3 ++-
 3 files changed, 22 insertions(+), 1 deletion(-)
 create mode 100644 recipes-browser/chromium/chromium-24.0.1312.52/x86-64/include.gypi
 create mode 100644 recipes-browser/chromium/chromium-24.0.1312.52/x86-64/oe-defaults.gypi

-- 
1.7.9.5

[meta-browser][PATCH 1/1] chromium: add support for x86-64

[Laurentiu Palcu]

Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
---
 .../chromium-24.0.1312.52/x86-64/include.gypi      |    5 +++++
 .../chromium-24.0.1312.52/x86-64/oe-defaults.gypi  |   15 +++++++++++++++
 recipes-browser/chromium/chromium_24.0.1312.52.bb  |    3 ++-
 3 files changed, 22 insertions(+), 1 deletion(-)
 create mode 100644 recipes-browser/chromium/chromium-24.0.1312.52/x86-64/include.gypi
 create mode 100644 recipes-browser/chromium/chromium-24.0.1312.52/x86-64/oe-defaults.gypi

diff --git a/recipes-browser/chromium/chromium-24.0.1312.52/x86-64/include.gypi b/recipes-browser/chromium/chromium-24.0.1312.52/x86-64/include.gypi
new file mode 100644
index 0000000..c2e2a7d
--- /dev/null
+++ b/recipes-browser/chromium/chromium-24.0.1312.52/x86-64/include.gypi
@@ -0,0 +1,5 @@
+{
+  'variables': {
+    'target_arch': 'x64',
+  }
+}
diff --git a/recipes-browser/chromium/chromium-24.0.1312.52/x86-64/oe-defaults.gypi b/recipes-browser/chromium/chromium-24.0.1312.52/x86-64/oe-defaults.gypi
new file mode 100644
index 0000000..0a6e8e8
--- /dev/null
+++ b/recipes-browser/chromium/chromium-24.0.1312.52/x86-64/oe-defaults.gypi
@@ -0,0 +1,15 @@
+{
+  'variables': {
+    'use_system_bzip2': 1,
+    'disable_nacl': 1,
+    'proprietary_codecs': 0,
+    'v8_use_snapshot': 1,
+    'use_system_ffmpeg': 0,
+    'linux_use_tcmalloc': 1,
+    'linux_link_kerberos': 0,
+    'use_kerberos': 0,
+    'use_cups': 0,
+    'use_gnome_keyring': 0,
+    'linux_link_gnome_keyring': 0,
+  }, 
+}
diff --git a/recipes-browser/chromium/chromium_24.0.1312.52.bb b/recipes-browser/chromium/chromium_24.0.1312.52.bb
index 85d4173..3976a71 100644
--- a/recipes-browser/chromium/chromium_24.0.1312.52.bb
+++ b/recipes-browser/chromium/chromium_24.0.1312.52.bb
@@ -1,7 +1,7 @@
 DESCRIPTION = "Chromium browser"
 LICENSE = "BSD"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=0750f191c9bbf46869b70508e7eb455b"
-DEPENDS = "xextproto cairo nss gtk+-native zlib-native libav libxi libgnome-keyring libxss cups ninja-native"
+DEPENDS = "xextproto cairo nss gtk+ zlib-native libav libxi libgnome-keyring libxss cups ninja-native"
 
 SRC_URI = "http://commondatastorage.googleapis.com/chromium-browser-official/${P}.tar.bz2 \
         file://include.gypi \
@@ -14,6 +14,7 @@ SRC_URI = "http://commondatastorage.googleapis.com/chromium-browser-official/${P
 # include.gypi exists only for armv6 and armv7a and there isn't something like COMPATIBLE_ARCH afaik
 COMPATIBLE_MACHINE = "(-)"
 COMPATIBLE_MACHINE_i586 = "(.*)"
+COMPATIBLE_MACHINE_x86-64 = "(.*)"
 COMPATIBLE_MACHINE_armv6 = "(.*)"
 COMPATIBLE_MACHINE_armv7a = "(.*)"
 
-- 
1.7.9.5

Re: [meta-browser][PATCH 0/1] chromium: add support for x86-64

[Eric Bénard]

Hi Laurentiu,

Le Fri,  8 Mar 2013 14:47:05 +0200,
Laurentiu Palcu <laurentiu.palcu@intel.com> a écrit :
> I gave chromium a test on x86 architecture and, apparently, there was no
> support for x86-64. So, I added it (didn't do much actually, just copied
> the i586 gypi files and changed the target_arch to x64), built
> core-image-sato for qemux86-64, and ran chrome. It worked just fine.
> 
> I also removed gtk+-native from the dependencies (there's no need for
> the native gtk) and added gtk+ instead (this one is needed).
> 
thanks I splitted the change in 2 patches and pushed it.

Eric