From: Dave Jones <davej@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: BUG_ON(nd->inode != parent->d_inode);
Date: Fri, 8 Mar 2013 16:04:32 -0500 [thread overview]
Message-ID: <20130308210432.GA21500@redhat.com> (raw)
In-Reply-To: <CA+55aFyE12rZ3DZUtTkonPjbcQiZNdAmys7w5zf7_Xry2z=-2A@mail.gmail.com>
On Fri, Mar 08, 2013 at 11:47:54AM -0800, Linus Torvalds wrote:
> On Fri, Mar 8, 2013 at 11:36 AM, Dave Jones <davej@redhat.com> wrote:
> >
> > I changed it to do this..
> >
> > diff --git a/fs/namei.c b/fs/namei.c
> > index 961bc12..c1ca29e 100644
> > --- a/fs/namei.c
> > +++ b/fs/namei.c
> > @@ -689,8 +689,6 @@ void nd_jump_link(struct nameidata *nd, struct path *path)
> > nd->path = *path;
> > nd->inode = nd->path.dentry->d_inode;
> > nd->flags |= LOOKUP_JUMPED;
> > -
> > - BUG_ON(nd->inode->i_op->follow_link);
> > }
> >
> > static inline void put_link(struct nameidata *nd, struct path *link, void *cookie)
> > @@ -1438,7 +1436,13 @@ static int lookup_slow(struct nameidata *nd, struct path *path)
> > int err;
> >
> > parent = nd->path.dentry;
> > - BUG_ON(nd->inode != parent->d_inode);
> > +
> > + if (WARN_ON(nd->inode != parent->d_inode)) {
> > + printk("%s -> %p (%s)\n", parent->d_name.name, path->dentry, nd->last.name);
> > + return -EINVAL;
> > + }
>
> Ok, it might be nice to print out the path dentry name if it has one,
> but it may well be that this only happens with negative dentries in
> proc or sysfs, since you said that you just added testing of that..
>
> > And now I'm getting a different BUG_ON
>
> Heh. It's the same BUG_ON(), it's just replicated (and "parent" is
> called "dir" here).
>
> Maybe you can make the WARN_ON_ONCE() version be a macro, because that
> test exists in multiple places: unlazy_walk, complete_walk,
> lookup_slow and do_last (and walk_component in a different guise).
queue up the sad trombone noises.
One of the things trinity passes syscalls is a page of deformed unicode.
Apparently this page is so fucked up, that it crashes *printk*.
Dave
[ 131.811418] WARNING: at fs/namei.c:2746 do_last+0xdb5/0xec0()
[ 131.812156] Hardware name: GA-MA78GM-S2H
[ 131.812659] Modules linked in: netrom(+) ax25 caif_socket caif irda crc_ccitt ipx af_802154 p8023 p8022 decnet appletalk psnap x25 llc af_rxrpc rds atm pppoe pppox ppp_generic slhc phonet nfc can_raw can lockd sunrpc ip6t_REJECT nf_conntrack_ipv6 nf_defrag_ipv6 xt_conntrack nf_conntrack ip6table_filter ip6_tables snd_hda_codec_realtek snd_hda_intel snd_hda_codec btusb bluetooth snd_pcm microcode snd_page_alloc rfkill snd_timer snd serio_raw edac_core vhost_net usb_debug pcspkr tun macvtap macvlan soundcore kvm_amd r8169 kvm mii radeon backlight drm_kms_helper ttm
[ 131.838316] Pid: 742, comm: trinity-child2 Not tainted 3.9.0-rc1+ #82
[ 131.848590] Call Trace:
[ 131.848969] [<ffffffff81045115>] warn_slowpath_common+0x75/0xa0
[ 131.849742] [<ffffffff8104515a>] warn_slowpath_null+0x1a/0x20
[ 131.850495] [<ffffffff811cbb35>] do_last+0xdb5/0xec0
[ 131.851150] [<ffffffff811c7d78>] ? inode_permission+0x18/0x50
[ 131.851900] [<ffffffff811c7ff5>] ? link_path_walk+0x245/0x880
[ 131.852651] [<ffffffff811cbcfa>] path_openat+0xba/0x500
[ 131.853340] [<ffffffff810b27f8>] ? trace_hardirqs_off_caller+0x28/0xc0
[ 131.854186] [<ffffffff810b2722>] ? get_lock_stats+0x22/0x70
[ 131.854915] [<ffffffff810b2b8e>] ? put_lock_stats.isra.23+0xe/0x40
[ 131.855718] [<ffffffff811cc401>] do_filp_open+0x41/0xa0
[ 131.856407] [<ffffffff811dbc19>] ? __alloc_fd+0x179/0x230
[ 131.857116] [<ffffffff811bb414>] do_sys_open+0xf4/0x1e0
[ 131.857804] [<ffffffff811bb521>] sys_open+0x21/0x30
[ 131.858517] [<ffffffff816d1082>] system_call_fastpath+0x16/0x1b
[ 131.859303] [<ffffffffa0001001>] ? ttm_dma_tt_fini+0x71/0xa0 [ttm]
[ 131.937423] ---[ end trace cfbe25dc62f850d2 ]---
[ 131.938049] ->
[ 131.938274] general protection fault: 0000 [#1]
[ 131.938896] PREEMPT SMP
[ 131.939097] Modules linked in: netrom ax25 caif_socket caif irda crc_ccitt ipx af_802154 p8023 p8022 decnet appletalk psnap x25 llc af_rxrpc rds atm pppoe pppox ppp_generic slhc phonet nfc can_raw can lockd sunrpc ip6t_REJECT nf_conntrack_ipv6 nf_defrag_ipv6 xt_conntrack nf_conntrack ip6table_filter ip6_tables snd_hda_codec_realtek snd_hda_intel snd_hda_codec btusb bluetooth snd_pcm microcode snd_page_alloc rfkill snd_timer snd serio_raw edac_core vhost_net usb_debug pcspkr tun macvtap macvlan soundcore kvm_amd r8169 kvm mii radeon backlight drm_kms_helper ttm
[ 131.947457] CPU 2
[ 131.947733] Pid: 742, comm: trinity-child2 Tainted: G W 3.9.0-rc1+ #82 Gigabyte Technology Co., Ltd. GA-MA78GM-S2H/GA-MA78GM-S2H
[ 131.949341] RIP: 0010:[<ffffffff81345fdd>] [<ffffffff81345fdd>] strnlen+0xd/0x40
[ 131.950362] RSP: 0018:ffff88011084bae8 EFLAGS: 00010086
[ 131.951062] RAX: ffffffff819e980c RBX: ffffffff82074da0 RCX: fffffffffffffffe
[ 131.951985] RDX: af0f48ef7bdef7bd RSI: ffffffffffffffff RDI: af0f48ef7bdef7bd
[ 131.952907] RBP: ffff88011084bae8 R08: 000000000000ffff R09: 000000000000ffff
[ 131.953829] R10: 0000000000000001 R11: 0000000000000000 R12: af0f48ef7bdef7bd
[ 131.954751] R13: ffffffff82075180 R14: 000000000000ffff R15: 0000000000000000
[ 131.955674] FS: 00007f376da9b740(0000) GS:ffff88012b200000(0000) knlGS:0000000000000000
[ 131.956714] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 131.957466] CR2: 00007f772904d000 CR3: 000000011082e000 CR4: 00000000000007e0
[ 131.958388] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 131.959310] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[ 131.960234] Process trinity-child2 (pid: 742, threadinfo ffff88011084a000, task ffff880113ccc920)
[ 131.961370] Stack:
[ 131.961629] ffff88011084bb28 ffffffff813479ce ffffffff81c2c600 ffffffff82074da0
[ 131.962730] ffffffff82075180 ffff88011084bc70 ffffffff819e7b02 ffffffff819e7b02
[ 131.963848] ffff88011084bba8 ffffffff81348ba9 ffffffff81c2c5a0 ffffffff810b27f8
[ 131.966843] Call Trace:
[ 131.969052] [<ffffffff813479ce>] string.isra.3+0x3e/0xc0
[ 131.971642] [<ffffffff81348ba9>] vsnprintf+0x1f9/0x610
[ 131.974208] [<ffffffff810b27f8>] ? trace_hardirqs_off_caller+0x28/0xc0
[ 131.976927] [<ffffffff81349081>] vscnprintf+0x11/0x30
[ 131.979441] [<ffffffff810478f1>] vprintk_emit+0x111/0x590
[ 131.981987] [<ffffffff811cbb35>] ? do_last+0xdb5/0xec0
[ 131.984503] [<ffffffff816bb79b>] printk+0x61/0x63
[ 131.986960] [<ffffffff811cbb6b>] do_last+0xdeb/0xec0
[ 131.989446] [<ffffffff811c7d78>] ? inode_permission+0x18/0x50
[ 131.992041] [<ffffffff811c7ff5>] ? link_path_walk+0x245/0x880
[ 131.994631] [<ffffffff811cbcfa>] path_openat+0xba/0x500
[ 131.997141] [<ffffffff810b27f8>] ? trace_hardirqs_off_caller+0x28/0xc0
[ 131.999804] [<ffffffff810b2722>] ? get_lock_stats+0x22/0x70
[ 132.002334] [<ffffffff810b2b8e>] ? put_lock_stats.isra.23+0xe/0x40
[ 132.004941] [<ffffffff811cc401>] do_filp_open+0x41/0xa0
[ 132.007428] [<ffffffff811dbc19>] ? __alloc_fd+0x179/0x230
[ 132.009899] [<ffffffff811bb414>] do_sys_open+0xf4/0x1e0
[ 132.012297] [<ffffffff811bb521>] sys_open+0x21/0x30
[ 132.014603] [<ffffffff816d1082>] system_call_fastpath+0x16/0x1b
[ 132.016993] [<ffffffffa0001001>] ? ttm_dma_tt_fini+0x71/0xa0 [ttm]
[ 132.019385] Code: c0 80 38 00 75 f8 48 29 f8 5d c3 31 c0 5d c3 66 66 66 66 66 66 2e 0f 1f 84 00 00 00 00 00 55 48 85 f6 48 8d 4e ff 48 89 e5 74 28 <80> 3f 00 74 23 48 89 f8 31 d2 eb 0f 0f 1f 80 00 00 00 00 48 ff
[ 132.026917] RIP [<ffffffff81345fdd>] strnlen+0xd/0x40
[ 132.029301] RSP <ffff88011084bae8>
It then goes into a death spiral recursing over the same trace.
Dave
next prev parent reply other threads:[~2013-03-08 21:04 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 2:16 BUG_ON(nd->inode != parent->d_inode); Dave Jones
2013-03-07 15:30 ` BUG_ON(nd->inode->i_op->follow_link); Dave Jones
2013-03-07 17:30 ` BUG_ON(nd->inode->i_op->follow_link); Linus Torvalds
2013-03-07 19:35 ` BUG_ON(nd->inode->i_op->follow_link); Dave Jones
2013-03-07 20:33 ` BUG_ON(nd->inode->i_op->follow_link); Linus Torvalds
2013-03-07 21:38 ` ipc/testmsg GPF Dave Jones
2013-03-07 21:45 ` Linus Torvalds
2013-03-07 21:49 ` David Miller
2013-03-07 21:51 ` Linus Torvalds
2013-03-07 22:03 ` Dave Jones
2013-03-07 22:36 ` pipe_release oops Dave Jones
2013-03-07 23:14 ` fasync_remove_entry oops Dave Jones
2013-03-07 23:46 ` Linus Torvalds
2013-03-07 23:54 ` Dave Jones
2013-03-08 0:20 ` Dave Jones
2013-03-08 0:21 ` pipe_release oops Linus Torvalds
2013-03-08 14:53 ` Dave Jones
2013-03-08 18:30 ` Linus Torvalds
2013-03-08 18:26 ` Jörn Engel
2013-03-10 23:33 ` Al Viro
2013-03-12 19:09 ` Jörn Engel
2013-03-10 22:10 ` Al Viro
2013-03-11 0:35 ` Al Viro
2013-03-11 15:10 ` Linus Torvalds
2013-03-11 18:05 ` Al Viro
2013-03-12 13:06 ` Al Viro
2013-03-12 15:31 ` Linus Torvalds
2013-03-12 19:43 ` Al Viro
2013-03-12 19:56 ` Dave Jones
2013-03-12 20:09 ` Linus Torvalds
2013-03-12 20:51 ` Al Viro
2013-03-27 13:51 ` Yet another pipe related oops Dave Jones
2013-03-27 15:20 ` Al Viro
2013-03-27 16:33 ` Linus Torvalds
2013-03-27 16:53 ` Raymond Jennings
2013-03-27 17:45 ` Al Viro
2013-04-01 20:34 ` Al Viro
2013-04-01 21:00 ` Greg Kroah-Hartman
2013-04-01 21:21 ` Al Viro
2013-04-01 21:44 ` Greg Kroah-Hartman
2013-04-01 23:27 ` Al Viro
2013-04-02 0:22 ` Al Viro
2013-04-02 1:55 ` Greg Kroah-Hartman
2013-03-12 1:27 ` pipe_release oops Dave Jones
2013-03-09 0:27 ` ipc/testmsg GPF Peter Hurley
2013-03-09 0:32 ` Dave Jones
2013-03-11 18:26 ` Dave Jones
2013-03-11 19:03 ` Peter Hurley
2013-03-12 22:02 ` Andrew Morton
2013-03-12 22:33 ` Dave Jones
2013-03-15 21:21 ` Dave Jones
2013-03-25 16:37 ` Dave Jones
2013-03-25 18:28 ` Peter Hurley
2013-03-25 18:39 ` Dave Jones
2013-03-07 22:18 ` BUG_ON(nd->inode->i_op->follow_link); Dave Jones
2013-03-07 22:50 ` BUG_ON(nd->inode->i_op->follow_link); Linus Torvalds
2013-03-07 23:03 ` BUG_ON(nd->inode->i_op->follow_link); Dave Jones
2013-03-07 23:55 ` BUG_ON(nd->inode->i_op->follow_link); Linus Torvalds
2013-03-11 0:02 ` BUG_ON(nd->inode->i_op->follow_link); Al Viro
2013-03-10 23:04 ` BUG_ON(nd->inode->i_op->follow_link); Al Viro
2013-03-12 18:31 ` BUG_ON(nd->inode->i_op->follow_link); Linus Torvalds
2013-03-08 15:04 ` BUG_ON(nd->inode != parent->d_inode); Dave Jones
2013-03-08 18:51 ` Linus Torvalds
2013-03-08 19:18 ` Dave Jones
2013-03-08 19:20 ` Dave Jones
2013-03-08 19:36 ` Dave Jones
2013-03-08 19:47 ` Linus Torvalds
2013-03-08 21:04 ` Dave Jones [this message]
2013-03-08 22:41 ` Linus Torvalds
2013-03-08 23:07 ` Dave Jones
2013-03-08 23:14 ` Dave Jones
2013-03-08 23:20 ` Linus Torvalds
2013-03-08 23:28 ` Linus Torvalds
2013-03-08 23:34 ` Dave Jones
2013-03-08 23:47 ` Dave Jones
2013-03-08 23:51 ` Linus Torvalds
2013-03-08 23:30 ` Dave Jones
2013-03-08 23:45 ` Linus Torvalds
2013-03-08 23:55 ` Dave Jones
2013-03-09 0:02 ` Linus Torvalds
2013-03-09 0:19 ` Dave Jones
2013-03-09 0:29 ` Raymond Jennings
2013-03-09 0:36 ` Dave Jones
2013-03-09 1:18 ` Linus Torvalds
2013-03-09 2:03 ` Dave Jones
2013-03-09 2:08 ` Linus Torvalds
2013-03-09 2:26 ` Dave Jones
2013-03-09 2:56 ` Dave Jones
2013-03-09 2:57 ` Dave Jones
[not found] ` <CA+55aFxyOYXnzDoWr7Utr1QLjjMUCON5EGH3FMvGBHxnxMJmQQ@mail.gmail.com>
2013-03-09 3:25 ` Dave Jones
2013-03-09 3:38 ` Eric W. Biederman
2013-03-09 4:26 ` Dave Jones
2013-03-09 8:28 ` Eric W. Biederman
[not found] ` <CA+55aFweyfew3VU79ZQV4otJcWiF0=xKXxDtADXcccNxGaqMwA@mail.gmail.com>
2013-03-09 3:50 ` Dave Jones
2013-03-09 4:31 ` Linus Torvalds
2013-03-09 4:39 ` Dave Jones
2013-03-09 5:13 ` Sasha Levin
2013-03-09 5:16 ` Dave Jones
2013-03-09 3:27 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130308210432.GA21500@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.