All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Dave Jones <davej-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Linux Kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Alexander Viro
	<viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH 0/1] do not abuse ->cred_guard_mutex in threadgroup_lock()
Date: Sat, 9 Mar 2013 21:00:46 +0100	[thread overview]
Message-ID: <20130309200046.GA8149@redhat.com> (raw)
In-Reply-To: <513AE918.7020704-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

On 03/09, Li Zefan wrote:
>
> We don't need both patches for 3.9, so we'll queue Oleg's fix for 3.9 and
> yours for 3.10?

Well. OK, please see 1/1 (compile tested only).

But I still like the patch from Tejun more... Except _perhaps_ my
patch is better for 3.9 just because it is simpler.

And. I still think that probably we can avoid thread_group_leader()
recheck-and-restart logic in attach_task_by_pid(). But even if this
is true (and thus we can revert the changes in de_thread), we should
do this on top of Tejun's patch.

Oleg.

WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: Li Zefan <lizefan@huawei.com>
Cc: Tejun Heo <tj@kernel.org>, Dave Jones <davej@redhat.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	cgroups@vger.kernel.org
Subject: [PATCH 0/1] do not abuse ->cred_guard_mutex in threadgroup_lock()
Date: Sat, 9 Mar 2013 21:00:46 +0100	[thread overview]
Message-ID: <20130309200046.GA8149@redhat.com> (raw)
In-Reply-To: <513AE918.7020704@huawei.com>

On 03/09, Li Zefan wrote:
>
> We don't need both patches for 3.9, so we'll queue Oleg's fix for 3.9 and
> yours for 3.10?

Well. OK, please see 1/1 (compile tested only).

But I still like the patch from Tejun more... Except _perhaps_ my
patch is better for 3.9 just because it is simpler.

And. I still think that probably we can avoid thread_group_leader()
recheck-and-restart logic in attach_task_by_pid(). But even if this
is true (and thus we can revert the changes in de_thread), we should
do this on top of Tejun's patch.

Oleg.


  parent reply	other threads:[~2013-03-09 20:00 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-06 22:36 lockdep trace from prepare_bprm_creds Dave Jones
     [not found] ` <20130306223657.GA7392-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-03-07 17:25   ` Oleg Nesterov
2013-03-07 17:25     ` Oleg Nesterov
2013-03-07 18:01     ` Tejun Heo
     [not found]       ` <20130307180139.GD29601-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-03-07 18:03         ` Tejun Heo
2013-03-07 18:03           ` Tejun Heo
     [not found]           ` <20130307180332.GE29601-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-03-07 19:12             ` Oleg Nesterov
2013-03-07 19:12               ` Oleg Nesterov
     [not found]               ` <20130307191242.GA18265-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-03-07 19:38                 ` Tejun Heo
2013-03-07 19:38                   ` Tejun Heo
     [not found]                   ` <20130307193820.GB3209-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-03-09  2:11                     ` Li Zefan
2013-03-09  2:11                       ` Li Zefan
     [not found]                       ` <513A9A67.60909-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-03-09  3:29                         ` Tejun Heo
2013-03-09  3:29                           ` Tejun Heo
     [not found]                           ` <20130309032936.GT14556-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-03-09  7:47                             ` Li Zefan
2013-03-09  7:47                               ` Li Zefan
     [not found]                               ` <513AE918.7020704-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-03-09 20:00                                 ` Oleg Nesterov [this message]
2013-03-09 20:00                                   ` [PATCH 0/1] do not abuse ->cred_guard_mutex in threadgroup_lock() Oleg Nesterov
2013-03-09 20:01                                   ` [PATCH 1/1] " Oleg Nesterov
     [not found]                                     ` <20130309200106.GB8149-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-03-09 20:15                                       ` Tejun Heo
2013-03-09 20:15                                         ` Tejun Heo
2013-03-11  1:50                                       ` Li Zefan
2013-03-11  1:50                                         ` Li Zefan
     [not found]                                   ` <20130309200046.GA8149-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-03-21 16:21                                     ` [PATCH] " Oleg Nesterov
2013-03-21 16:21                                       ` Oleg Nesterov
     [not found]                                       ` <20130321162138.GA21859-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-03-21 22:06                                         ` Andrew Morton
2013-03-21 22:06                                           ` Andrew Morton
     [not found]                                           ` <20130321150626.a7934d989fb80d835fa92255-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2013-03-22 13:20                                             ` Oleg Nesterov
2013-03-22 13:20                                               ` Oleg Nesterov
2013-03-19 22:02                               ` [PATCH cgroup/for-3.10] cgroup: make cgroup_mutex outer to threadgroup_lock Tejun Heo
     [not found]                                 ` <20130319220246.GR3042-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-03-20  0:58                                   ` Li Zefan
2013-03-20  0:58                                     ` Li Zefan
2013-03-20 15:03                                     ` Tejun Heo
     [not found]                                       ` <20130320150351.GW3042-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-03-20 18:35                                         ` Oleg Nesterov
2013-03-20 18:35                                           ` Oleg Nesterov
     [not found]                                           ` <20130320183523.GA29365-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-03-20 18:42                                             ` Tejun Heo
2013-03-20 18:42                                               ` Tejun Heo
     [not found]                                               ` <CAOS58YPxGXt+iq1GZ4hryqm1Z_p+r7eRRC7ruUDDd=LQrWtAxg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-03-21 16:17                                                 ` Oleg Nesterov
2013-03-21 16:17                                                   ` Oleg Nesterov
2013-03-07 18:21         ` lockdep trace from prepare_bprm_creds Tejun Heo
2013-03-07 18:21           ` Tejun Heo
     [not found]           ` <20130307182140.GF29601-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-03-07 18:32             ` Oleg Nesterov
2013-03-07 18:32               ` Oleg Nesterov
     [not found]               ` <20130307183213.GA18022-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-03-07 19:33                 ` Tejun Heo
2013-03-07 19:33                   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130309200046.GA8149@redhat.com \
    --to=oleg-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=davej-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.