[GIT PULL] ARM: CSR: minor fixes for 3.9-rc1

[GIT PULL] ARM: CSR: minor fixes for 3.9-rc1

[Barry Song]

Hi Olof, Arnd,

The following changes since commit 6dbe51c251a327e012439c4772097a13df43c5b8:

  Linux 3.9-rc1 (2013-03-03 15:11:05 -0800)

are available in the git repository at:
  git://gitorious.org/sirfprima2-kernel/sirfprima2-kernel.git sirf/fixes

Barry Song (1):
      ARM: prima2: fix a checkpatch issue

Syam Sidhardhan (1):
      ARM: prima2: Replace include linux/module.h with linux/export.h

 arch/arm/mach-prima2/common.c |    4 ++--
 arch/arm/mach-prima2/pm.c     |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

-----

diff --git a/arch/arm/mach-prima2/common.c b/arch/arm/mach-prima2/common.c
index 2d57aa4..2ed5007 100644
--- a/arch/arm/mach-prima2/common.c
+++ b/arch/arm/mach-prima2/common.c
@@ -39,8 +39,8 @@ static __init void sirfsoc_map_io(void)

 #ifdef CONFIG_ARCH_PRIMA2
 static const char *prima2_dt_match[] __initdata = {
-       "sirf,prima2",
-       NULL
+	"sirf,prima2",
+	NULL
 };

 DT_MACHINE_START(PRIMA2_DT, "Generic PRIMA2 (Flattened Device Tree)")
diff --git a/arch/arm/mach-prima2/pm.c b/arch/arm/mach-prima2/pm.c
index 9936c18..f7e347e 100644
--- a/arch/arm/mach-prima2/pm.c
+++ b/arch/arm/mach-prima2/pm.c
@@ -9,7 +9,7 @@
 #include <linux/kernel.h>
 #include <linux/suspend.h>
 #include <linux/slab.h>
-#include <linux/module.h>
+#include <linux/export.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
 #include <linux/of_device.h>


Thanks
barry

[GIT PULL] ARM: CSR: minor fixes for 3.9-rc1

[Arnd Bergmann]

On Wednesday 06 March 2013, Barry Song wrote:
> Hi Olof, Arnd,
> 
> The following changes since commit 6dbe51c251a327e012439c4772097a13df43c5b8:
> 
>   Linux 3.9-rc1 (2013-03-03 15:11:05 -0800)
> 
> are available in the git repository at:
>   git://gitorious.org/sirfprima2-kernel/sirfprima2-kernel.git sirf/fixes
> 
> Barry Song (1):
>       ARM: prima2: fix a checkpatch issue
> 
> Syam Sidhardhan (1):
>       ARM: prima2: Replace include linux/module.h with linux/export.h
> 
>  arch/arm/mach-prima2/common.c |    4 ++--
>  arch/arm/mach-prima2/pm.c     |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

Hi Barry,

Sorry for taking a little longer to look at these patches. I decided
not to apply them because they are only cosmetic changes and can wait
for 3.10.

There are a few things that I'd like you to improve in the future:

* Do not include "Change-Id:" tags in the changelog, those are meaningless
  to the upstream kernel.

* Use a signed tag for pull requests, rather than a branch, and try to
  get your gpg key signed by other maintainers when you meet them at
  a conference.

* In the tag description, give an overview of the patches you are
  asking to be pulled. Most people get it right these days, so there
  are lots of examples for you to look at.

	Arnd

[GIT PULL] ARM: CSR: minor fixes for 3.9-rc1

[Barry Song]

2013/3/12 Arnd Bergmann <arnd@arndb.de>:
> On Wednesday 06 March 2013, Barry Song wrote:
>> Hi Olof, Arnd,
>>
>> The following changes since commit 6dbe51c251a327e012439c4772097a13df43c5b8:
>>
>>   Linux 3.9-rc1 (2013-03-03 15:11:05 -0800)
>>
>> are available in the git repository at:
>>   git://gitorious.org/sirfprima2-kernel/sirfprima2-kernel.git sirf/fixes
>>
>> Barry Song (1):
>>       ARM: prima2: fix a checkpatch issue
>>
>> Syam Sidhardhan (1):
>>       ARM: prima2: Replace include linux/module.h with linux/export.h
>>
>>  arch/arm/mach-prima2/common.c |    4 ++--
>>  arch/arm/mach-prima2/pm.c     |    2 +-
>>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> Hi Barry,
>
> Sorry for taking a little longer to look at these patches. I decided
> not to apply them because they are only cosmetic changes and can wait
> for 3.10.

yes. those can wait.

>
> There are a few things that I'd like you to improve in the future:
>
> * Do not include "Change-Id:" tags in the changelog, those are meaningless
>   to the upstream kernel.
>
ok. we are using the gerrit for internal review. so the change-id is
added automatically by the commit-msg hook.
i will seperately handle the commits for upstream and commits for internal repo.

> * Use a signed tag for pull requests, rather than a branch, and try to
>   get your gpg key signed by other maintainers when you meet them at
>   a conference.

ok. hope i will get a guy in shanghai to sign recently.

>
> * In the tag description, give an overview of the patches you are
>   asking to be pulled. Most people get it right these days, so there
>   are lots of examples for you to look at.

ok.

thanks for all of your good suggestions.

>
>         Arnd

-barry