All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Li Zefan <lizefan@huawei.com>,
	LKML <linux-kernel@vger.kernel.org>,
	cgroups <cgroups@vger.kernel.org>,
	linux-mm@kvack.org,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jiri Kosina <jkosina@suse.cz>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [PATCH] device: separate all subsys mutexes (was: Re: [BUG] potential deadlock led by cpu_hotplug lock (memcg involved))
Date: Tue, 12 Mar 2013 06:34:46 -0700	[thread overview]
Message-ID: <20130312133446.GA3514@kroah.com> (raw)
In-Reply-To: <20130312130504.GD30758@dhcp22.suse.cz>

On Tue, Mar 12, 2013 at 02:05:04PM +0100, Michal Hocko wrote:
> The fix is quite simple. We can pull the key inside bus_type structure
> because they are defined per device so the pointer will be unique as
> well. bus_register doesn't need to be a macro anymore so change it
> to the inline. We could get rid of __bus_register as there is no other
> caller but maybe somebody will want to use a different key so keep it
> around for now.

Nice work, but just drop __bus_register(), no one should need to use a
new key for this type of thing, now that you have added a per-bus_type
variable.

thanks,

greg k-h

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Li Zefan <lizefan@huawei.com>,
	LKML <linux-kernel@vger.kernel.org>,
	cgroups <cgroups@vger.kernel.org>,
	linux-mm@kvack.org,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jiri Kosina <jkosina@suse.cz>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [PATCH] device: separate all subsys mutexes (was: Re: [BUG] potential deadlock led by cpu_hotplug lock (memcg involved))
Date: Tue, 12 Mar 2013 06:34:46 -0700	[thread overview]
Message-ID: <20130312133446.GA3514@kroah.com> (raw)
In-Reply-To: <20130312130504.GD30758@dhcp22.suse.cz>

On Tue, Mar 12, 2013 at 02:05:04PM +0100, Michal Hocko wrote:
> The fix is quite simple. We can pull the key inside bus_type structure
> because they are defined per device so the pointer will be unique as
> well. bus_register doesn't need to be a macro anymore so change it
> to the inline. We could get rid of __bus_register as there is no other
> caller but maybe somebody will want to use a different key so keep it
> around for now.

Nice work, but just drop __bus_register(), no one should need to use a
new key for this type of thing, now that you have added a per-bus_type
variable.

thanks,

greg k-h

  reply	other threads:[~2013-03-12 13:34 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-12  6:36 [BUG] potential deadlock led by cpu_hotplug lock (memcg involved) Li Zefan
2013-03-12  6:36 ` Li Zefan
2013-03-12  8:32 ` Hillf Danton
2013-03-12  8:32   ` Hillf Danton
     [not found]   ` <CAJd=RBB7GVp_Ry30SuZVa-FgOogEZ43UnXOGvVKesV=Qk96UDA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-03-12  9:35     ` Li Zefan
2013-03-12  9:35       ` Li Zefan
2013-03-12  9:35       ` Li Zefan
2013-03-12 10:15 ` Michal Hocko
2013-03-12 10:15   ` Michal Hocko
     [not found]   ` <20130312101555.GB30758-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-03-12 11:07     ` Michal Hocko
2013-03-12 11:07       ` Michal Hocko
2013-03-12 11:07       ` Michal Hocko
     [not found]       ` <20130312110750.GC30758-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-03-12 13:05         ` [PATCH] device: separate all subsys mutexes (was: Re: [BUG] potential deadlock led by cpu_hotplug lock (memcg involved)) Michal Hocko
2013-03-12 13:05           ` Michal Hocko
2013-03-12 13:05           ` Michal Hocko
2013-03-12 13:34           ` Greg Kroah-Hartman [this message]
2013-03-12 13:34             ` Greg Kroah-Hartman
     [not found]             ` <20130312133446.GA3514-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2013-03-12 16:21               ` [PATCH -v2] " Michal Hocko
2013-03-12 16:21                 ` Michal Hocko
2013-03-12 16:21                 ` Michal Hocko
     [not found]                 ` <20130312162119.GB5963-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-03-12 18:47                   ` Greg Kroah-Hartman
2013-03-12 18:47                     ` Greg Kroah-Hartman
2013-03-12 18:47                     ` Greg Kroah-Hartman
     [not found]           ` <20130312130504.GD30758-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-03-12 15:28             ` [PATCH] " Peter Zijlstra
2013-03-12 15:28               ` Peter Zijlstra
2013-03-12 15:28               ` Peter Zijlstra
2013-03-12 15:43               ` Greg Kroah-Hartman
2013-03-12 15:43                 ` Greg Kroah-Hartman
2013-03-12 15:43                 ` Greg Kroah-Hartman
     [not found]                 ` <20130312154341.GB18852-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2013-03-12 16:09                   ` Peter Zijlstra
2013-03-12 16:09                     ` Peter Zijlstra
2013-03-12 16:09                     ` Peter Zijlstra
2013-03-12 16:17                     ` Greg Kroah-Hartman
2013-03-12 16:17                       ` Greg Kroah-Hartman
2013-03-12 16:13               ` Michal Hocko
2013-03-12 16:13                 ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130312133446.GA3514@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=jkosina@suse.cz \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizefan@huawei.com \
    --cc=mhocko@suse.cz \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.