From: jhovold@gmail.com (Johan Hovold)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: w1-gpio: fix erroneous gpio requests
Date: Tue, 12 Mar 2013 22:17:02 +0100 [thread overview]
Message-ID: <20130312211702.GG8797@localhost> (raw)
In-Reply-To: <FE853F2C-A85A-4D0E-BF0E-80698F3E6567@jcrosoft.com>
On Wed, Mar 13, 2013 at 04:24:20AM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On Mar 13, 2013, at 4:20 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > On Tue, Mar 12, 2013 at 08:21:34PM +0100, Johan Hovold wrote:
> >> Fix regression introduced by commit d2323cf773 ("onewire: w1-gpio: add
> >> ext_pullup_enable pin in platform data") which added a gpio entry to the
> >> platform data, but did not add the required initialisers to the board
> >> files using it. Consequently, the driver would request gpio 0 at probe,
> >> which could break other uses of the corresponding pin.
> >>
> >> On AT91 requesting gpio 0 changes the pin muxing for PIOA0, which, for
> >> instance, breaks SPI0 on at91sam9g20.
>
> not only on AT91, 0 is a valid gpio
AT91 (and 9g20) was just an example of what the implications could be
like.
I discovered the change after having debugged broken MMC on a custom
at91sam9g45 board.
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <jhovold@gmail.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Johan Hovold" <jhovold@gmail.com>,
"Evgeniy Polyakov" <zbr@ioremap.net>,
"Nicolas Ferre" <nicolas.ferre@atmel.com>,
"Imre Kaloz" <kaloz@openwrt.org>,
"Krzysztof Halasa" <khc@pm.waw.pl>,
"Eric Miao" <eric.y.miao@gmail.com>,
"Haojian Zhuang" <haojian.zhuang@gmail.com>,
"Daniel Mack" <zonque@gmail.com>,
"Ville Syrjälä" <syrjala@sci.fi>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable <stable@vger.kernel.org>
Subject: Re: [PATCH] ARM: w1-gpio: fix erroneous gpio requests
Date: Tue, 12 Mar 2013 22:17:02 +0100 [thread overview]
Message-ID: <20130312211702.GG8797@localhost> (raw)
In-Reply-To: <FE853F2C-A85A-4D0E-BF0E-80698F3E6567@jcrosoft.com>
On Wed, Mar 13, 2013 at 04:24:20AM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On Mar 13, 2013, at 4:20 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > On Tue, Mar 12, 2013 at 08:21:34PM +0100, Johan Hovold wrote:
> >> Fix regression introduced by commit d2323cf773 ("onewire: w1-gpio: add
> >> ext_pullup_enable pin in platform data") which added a gpio entry to the
> >> platform data, but did not add the required initialisers to the board
> >> files using it. Consequently, the driver would request gpio 0 at probe,
> >> which could break other uses of the corresponding pin.
> >>
> >> On AT91 requesting gpio 0 changes the pin muxing for PIOA0, which, for
> >> instance, breaks SPI0 on at91sam9g20.
>
> not only on AT91, 0 is a valid gpio
AT91 (and 9g20) was just an example of what the implications could be
like.
I discovered the change after having debugged broken MMC on a custom
at91sam9g45 board.
Johan
next prev parent reply other threads:[~2013-03-12 21:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 19:21 [PATCH] ARM: w1-gpio: fix erroneous gpio requests Johan Hovold
2013-03-12 19:21 ` Johan Hovold
2013-03-12 20:20 ` Greg Kroah-Hartman
2013-03-12 20:20 ` Greg Kroah-Hartman
2013-03-12 20:24 ` Jean-Christophe PLAGNIOL-VILLARD
2013-03-12 20:24 ` Jean-Christophe PLAGNIOL-VILLARD
2013-03-12 21:17 ` Johan Hovold [this message]
2013-03-12 21:17 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130312211702.GG8797@localhost \
--to=jhovold@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.