From: Dan Carpenter <dan.carpenter@oracle.com>
To: Liam Girdwood <lgirdwood@gmail.com>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
devicetree-discuss@lists.ozlabs.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
kernel-janitors@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
Daniel Mack <zonque@gmail.com>,
Grant Likely <grant.likely@secretlab.ca>,
kbuild@01.org
Subject: [patch] ALSA: ASoC: tas5086: signedness bug in tas5086_hw_params()
Date: Wed, 13 Mar 2013 08:32:53 +0300 [thread overview]
Message-ID: <20130313053253.GA17674@longonot.mountain> (raw)
"val" has to be signed for the error handling to work.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/codecs/tas5086.c b/sound/soc/codecs/tas5086.c
index 008bea4..41d03ae 100644
--- a/sound/soc/codecs/tas5086.c
+++ b/sound/soc/codecs/tas5086.c
@@ -251,7 +251,7 @@ static int tas5086_hw_params(struct snd_pcm_substream *substream,
{
struct snd_soc_codec *codec = dai->codec;
struct tas5086_private *priv = snd_soc_codec_get_drvdata(codec);
- unsigned int val;
+ int val;
int ret;
priv->rate = params_rate(params);
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Liam Girdwood <lgirdwood@gmail.com>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
devicetree-discuss@lists.ozlabs.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
kernel-janitors@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
Daniel Mack <zonque@gmail.com>,
Grant Likely <grant.likely@secretlab.ca>,
kbuild@01.org
Subject: [patch] ALSA: ASoC: tas5086: signedness bug in tas5086_hw_params()
Date: Wed, 13 Mar 2013 05:32:53 +0000 [thread overview]
Message-ID: <20130313053253.GA17674@longonot.mountain> (raw)
"val" has to be signed for the error handling to work.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/codecs/tas5086.c b/sound/soc/codecs/tas5086.c
index 008bea4..41d03ae 100644
--- a/sound/soc/codecs/tas5086.c
+++ b/sound/soc/codecs/tas5086.c
@@ -251,7 +251,7 @@ static int tas5086_hw_params(struct snd_pcm_substream *substream,
{
struct snd_soc_codec *codec = dai->codec;
struct tas5086_private *priv = snd_soc_codec_get_drvdata(codec);
- unsigned int val;
+ int val;
int ret;
priv->rate = params_rate(params);
next reply other threads:[~2013-03-13 5:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 5:32 Dan Carpenter [this message]
2013-03-13 5:32 ` [patch] ALSA: ASoC: tas5086: signedness bug in tas5086_hw_params() Dan Carpenter
2013-03-13 10:29 ` Daniel Mack
2013-03-13 10:29 ` Daniel Mack
2013-03-13 11:09 ` Mark Brown
2013-03-13 11:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130313053253.GA17674@longonot.mountain \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=kbuild@01.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=rob.herring@calxeda.com \
--cc=tiwai@suse.de \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.