All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Doug Anderson <dianders@chromium.org>
Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	lm-sensors@lm-sensors.org, devicetree-discuss@lists.ozlabs.org,
	Jean Delvare <khali@linux-fr.org>,
	Naveen Krishna <naveenkrishna.ch@gmail.com>
Subject: Re: [lm-sensors] [PATCH v4] hwmon: ntc: Add DT with IIO support to NTC thermistor driver
Date: Wed, 13 Mar 2013 21:15:15 +0000	[thread overview]
Message-ID: <20130313211515.GA14632@roeck-us.net> (raw)
In-Reply-To: <CAD=FV=Wj6=3M+j5jF5xVFJLJS39on48_4gb6XO2uvyVG1pXVbQ@mail.gmail.com>

On Wed, Mar 13, 2013 at 01:52:35PM -0700, Doug Anderson wrote:
> Hi,
> 
> On Tue, Mar 12, 2013 at 9:08 PM, Naveen Krishna Chatradhi
> <ch.naveen@samsung.com> wrote:
> > This patch adds DT support to NTC driver to parse the
> > platform data.
> >
> > Also adds the support to work as an iio device.
> >
> > During the probe ntc driver gets the respective channels of ADC
> > and uses iio_raw_read calls to get the ADC converted value.
> >
> > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> > ---
> > Changes since v3:
> > 1. Added a NULL check before iio_channel_release
> > 2. Modified a return statement
> >
> > Guenter Roeck, Its wonderful working with you. Thanks.
> >
> >  .../devicetree/bindings/hwmon/ntc_thermistor.txt   |   29 ++++
> >  drivers/hwmon/Kconfig                              |    1 +
> >  drivers/hwmon/ntc_thermistor.c                     |  145 +++++++++++++++++---
> >  include/linux/platform_data/ntc_thermistor.h       |    8 +-
> >  4 files changed, 163 insertions(+), 20 deletions(-)
> 
> I haven't done a full review of this code, but it I built it in (along
> with other CLs to enable it on exynos5250-snow) and the thermistors
> are accessible and report reasonable values.
> 
> localhost hwmon # grep "" /sys/class/hwmon/*/device/temp1_input
> /sys/class/hwmon/hwmon0/device/temp1_input:37890
> /sys/class/hwmon/hwmon1/device/temp1_input:38393
> /sys/class/hwmon/hwmon2/device/temp1_input:37148
> /sys/class/hwmon/hwmon3/device/temp1_input:38059
> 
> Tested-by: Doug Anderson <dianders@chromium.org>
> 
Thanks!

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Doug Anderson <dianders@chromium.org>
Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	lm-sensors@lm-sensors.org, devicetree-discuss@lists.ozlabs.org,
	Jean Delvare <khali@linux-fr.org>,
	Naveen Krishna <naveenkrishna.ch@gmail.com>
Subject: Re: [PATCH v4] hwmon: ntc: Add DT with IIO support to NTC thermistor driver
Date: Wed, 13 Mar 2013 14:15:15 -0700	[thread overview]
Message-ID: <20130313211515.GA14632@roeck-us.net> (raw)
In-Reply-To: <CAD=FV=Wj6=3M+j5jF5xVFJLJS39on48_4gb6XO2uvyVG1pXVbQ@mail.gmail.com>

On Wed, Mar 13, 2013 at 01:52:35PM -0700, Doug Anderson wrote:
> Hi,
> 
> On Tue, Mar 12, 2013 at 9:08 PM, Naveen Krishna Chatradhi
> <ch.naveen@samsung.com> wrote:
> > This patch adds DT support to NTC driver to parse the
> > platform data.
> >
> > Also adds the support to work as an iio device.
> >
> > During the probe ntc driver gets the respective channels of ADC
> > and uses iio_raw_read calls to get the ADC converted value.
> >
> > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> > ---
> > Changes since v3:
> > 1. Added a NULL check before iio_channel_release
> > 2. Modified a return statement
> >
> > Guenter Roeck, Its wonderful working with you. Thanks.
> >
> >  .../devicetree/bindings/hwmon/ntc_thermistor.txt   |   29 ++++
> >  drivers/hwmon/Kconfig                              |    1 +
> >  drivers/hwmon/ntc_thermistor.c                     |  145 +++++++++++++++++---
> >  include/linux/platform_data/ntc_thermistor.h       |    8 +-
> >  4 files changed, 163 insertions(+), 20 deletions(-)
> 
> I haven't done a full review of this code, but it I built it in (along
> with other CLs to enable it on exynos5250-snow) and the thermistors
> are accessible and report reasonable values.
> 
> localhost hwmon # grep "" /sys/class/hwmon/*/device/temp1_input
> /sys/class/hwmon/hwmon0/device/temp1_input:37890
> /sys/class/hwmon/hwmon1/device/temp1_input:38393
> /sys/class/hwmon/hwmon2/device/temp1_input:37148
> /sys/class/hwmon/hwmon3/device/temp1_input:38059
> 
> Tested-by: Doug Anderson <dianders@chromium.org>
> 
Thanks!

Guenter

  reply	other threads:[~2013-03-13 21:15 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-12  8:39 [PATCH v2] hwmon: ntc: Add DT with IIO support to NTC thermistor driver Naveen Krishna Chatradhi
2013-03-12  8:51 ` [lm-sensors] " Naveen Krishna Chatradhi
2013-03-12 13:45 ` Guenter Roeck
2013-03-12 13:45   ` Guenter Roeck
2013-03-12 23:26   ` [lm-sensors] " Doug Anderson
2013-03-12 23:26     ` Doug Anderson
2013-03-13  2:55 ` [PATCH v3] " Naveen Krishna Chatradhi
2013-03-13  3:07   ` [lm-sensors] " Naveen Krishna Chatradhi
2013-03-13  3:09   ` Guenter Roeck
2013-03-13  3:09     ` Guenter Roeck
     [not found] ` <1363077566-6254-1-git-send-email-ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-03-13  4:08   ` [PATCH v4] " Naveen Krishna Chatradhi
2013-03-13  4:20     ` [lm-sensors] " Naveen Krishna Chatradhi
2013-03-13  4:08     ` Naveen Krishna Chatradhi
2013-03-13  4:46     ` [lm-sensors] " Guenter Roeck
2013-03-13  4:46       ` Guenter Roeck
2013-03-13  4:52     ` [lm-sensors] " Guenter Roeck
2013-03-13  4:52       ` Guenter Roeck
2013-03-13  4:56       ` [lm-sensors] " Guenter Roeck
2013-03-13  4:56         ` Guenter Roeck
2013-03-13 20:52     ` Doug Anderson
2013-03-13 20:52       ` Doug Anderson
2013-03-13 21:15       ` Guenter Roeck [this message]
2013-03-13 21:15         ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130313211515.GA14632@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=ch.naveen@samsung.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=dianders@chromium.org \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=naveenkrishna.ch@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.