From: Ben Widawsky <ben@bwidawsk.net>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/4] drm/i915: Remove unused file arg from execbuf
Date: Thu, 14 Mar 2013 09:06:48 -0700 [thread overview]
Message-ID: <20130314160646.GA10890@bwidawsk.net> (raw)
In-Reply-To: <20130314085641.GC20960@cantiga.alporthouse.com>
On Thu, Mar 14, 2013 at 08:56:41AM +0000, Chris Wilson wrote:
> I was hoping for something a little more magical. I couldn't spot any
> mistakes - the only thing missing is a hint as to why these are useful.
>
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris
I'm pretty sure you asked for magic the last time sent this patch.
Anyway, I can probably talk a little bit without disclosing the secretz.
Primarily the goal is to be able to easily queue up the work. Packing
more into the eb struct gives a nice compact /thing/ which I can put
into a list for later execution.
Now, the deferred execution has it's own pitfalls, and I'd prefer not to
get too far into that since I think these cleanups are decent on their
own.
>
> --
> Chris Wilson, Intel Open Source Technology Centre
--
Ben Widawsky, Intel Open Source Technology Center
prev parent reply other threads:[~2013-03-14 16:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 0:21 [PATCH 1/4] drm/i915: Remove unused file arg from execbuf Ben Widawsky
2013-03-14 0:21 ` [PATCH 2/4] drm/i915: Remove unneeded dev argument Ben Widawsky
2013-03-18 2:07 ` Daniel Vetter
2013-03-14 0:21 ` [PATCH 3/4] drm/i915: Make eb do more Ben Widawsky
2013-03-19 19:41 ` Jesse Barnes
2013-03-19 19:49 ` Ben Widawsky
2013-03-14 0:21 ` [PATCH 4/4] drm/i915: Extract object reserver/reloc/bind Ben Widawsky
2013-03-14 8:56 ` [PATCH 1/4] drm/i915: Remove unused file arg from execbuf Chris Wilson
2013-03-14 16:06 ` Ben Widawsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130314160646.GA10890@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.