From: Tony Lindgren <tony@atomide.com>
To: Rajendra Nayak <rnayak@ti.com>
Cc: paul@pwsan.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, phaber@broadcom.com
Subject: Re: [PATCH 2/2] ARM: OMAP2+: clocks: Pass static parent pointers to common clock core
Date: Thu, 14 Mar 2013 10:06:01 -0700 [thread overview]
Message-ID: <20130314170601.GH26093@atomide.com> (raw)
In-Reply-To: <1363264618-5071-3-git-send-email-rnayak@ti.com>
* Rajendra Nayak <rnayak@ti.com> [130314 05:44]:
> OMAP clock inits happen quite early, even before the slab is available.
> As part of the clock init, the common clock core tries to cache parent
> pointers (if not passed by the caller registering the clock) which
> fails in case of OMAP since the slab isn't initied.
> Without CONFIG_DEBUG_SLAB enabled, this just results in the common clock core
> retrying the caching attempt at some point later.
> However with CONFIG_DEBUG_SLAB enabled this results in a BUG() as reported
> in the link below by Tony..
> http://www.mail-archive.com/linux-omap@vger.kernel.org/msg85932.html
>
> Fix this by passing static parent pointers to the common clock core
> while registering clocks.
I wonder if we could easily fix this by initializing only some of the
clocks that early?
If we had a two stage initialization we could dynamically allocate the
rest of the parent clocks without having to add all the static data.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: OMAP2+: clocks: Pass static parent pointers to common clock core
Date: Thu, 14 Mar 2013 10:06:01 -0700 [thread overview]
Message-ID: <20130314170601.GH26093@atomide.com> (raw)
In-Reply-To: <1363264618-5071-3-git-send-email-rnayak@ti.com>
* Rajendra Nayak <rnayak@ti.com> [130314 05:44]:
> OMAP clock inits happen quite early, even before the slab is available.
> As part of the clock init, the common clock core tries to cache parent
> pointers (if not passed by the caller registering the clock) which
> fails in case of OMAP since the slab isn't initied.
> Without CONFIG_DEBUG_SLAB enabled, this just results in the common clock core
> retrying the caching attempt at some point later.
> However with CONFIG_DEBUG_SLAB enabled this results in a BUG() as reported
> in the link below by Tony..
> http://www.mail-archive.com/linux-omap at vger.kernel.org/msg85932.html
>
> Fix this by passing static parent pointers to the common clock core
> while registering clocks.
I wonder if we could easily fix this by initializing only some of the
clocks that early?
If we had a two stage initialization we could dynamically allocate the
rest of the parent clocks without having to add all the static data.
Regards,
Tony
next prev parent reply other threads:[~2013-03-14 17:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 12:36 [PATCH 0/2] Fix crash on OMAP with CONFIG_DEBUG_SLAB Rajendra Nayak
2013-03-14 12:36 ` Rajendra Nayak
2013-03-14 12:36 ` [PATCH 2/2] ARM: OMAP2+: clocks: Pass static parent pointers to common clock core Rajendra Nayak
2013-03-14 12:36 ` Rajendra Nayak
2013-03-14 17:06 ` Tony Lindgren [this message]
2013-03-14 17:06 ` Tony Lindgren
2013-03-15 12:27 ` Rajendra Nayak
2013-03-15 12:27 ` Rajendra Nayak
2013-03-15 16:20 ` Tony Lindgren
2013-03-15 16:20 ` Tony Lindgren
2013-03-18 8:20 ` Rajendra Nayak
2013-03-18 8:20 ` Rajendra Nayak
2013-03-18 16:37 ` Tony Lindgren
2013-03-18 16:37 ` Tony Lindgren
2013-03-19 1:23 ` Mike Turquette
2013-03-19 1:23 ` Mike Turquette
2013-03-19 5:16 ` Rajendra Nayak
2013-03-19 5:16 ` Rajendra Nayak
2013-03-14 12:45 ` [PATCH 0/2] Fix crash on OMAP with CONFIG_DEBUG_SLAB Rajendra Nayak
2013-03-14 12:45 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130314170601.GH26093@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=phaber@broadcom.com \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.