All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Vlad Yasevich <vyasevic@redhat.com>,
	netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [Bridge] [RFC PATCH v2 net-next 0/3] Allow bridge to function in non-promisc mode
Date: Thu, 14 Mar 2013 21:18:07 +0200	[thread overview]
Message-ID: <20130314191807.GA30381@redhat.com> (raw)
In-Reply-To: <20130307214304.25e7784e@nehalam.linuxnetplumber.net>

On Thu, Mar 07, 2013 at 09:43:04PM -0800, Stephen Hemminger wrote:
> On Thu,  7 Mar 2013 16:28:45 -0500
> Vlad Yasevich <vyasevic@redhat.com> wrote:
> 
> > The series adds an ability to configure the bridge into a non-primiscuous
> > mode.   Instead, it provides the ability to identitfy some set of bridge
> > ports as uplinks and allows for MAC addresses to be programmed onto
> > those ports.  In case the port hardware does not support mac filter,
> > that port will be placed in promiscuous mode.
> > 
> > Default bridge operation continues to remain as "promiscuous".  The new
> > functionality has to be enabled via sysfs (similar to other bridge extensions).
> > 
> > The uplink mode is implemented as a flag on a bridge port.  The api to
> > change that flag follows the existing api to enable/disable other existing
> > flags.
> > 
> > All comments are welcome.
> > 
> 
> Can we make this a one step process and less visible to the user.
> If user defines an uplink device, and the uplink device is capable of filtering
> (and what ever other pre-conditions people can think of), then the bridge will
> transparently switch to uplink/non-promisc mode.  This can also be used to trigger
> edge only mode in RSTP in the future.
> 
> Less knobs.
> 

Rephrasing what I suggested using 'uplink' term:
- add ability to specify wanted addresses on a port
- wheneever we don't specify addresses we call an uplink
  (either automatically so by default all
  ports are uplink, or add a separate flag - any preference?)
- if there are 0 uplinks, no ports are promisc
- if there is 1 uplink, it is not promisc but all others are promisc
- if there are >1 uplinks, everyone is promisc


> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Vlad Yasevich <vyasevic@redhat.com>,
	netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [RFC PATCH v2 net-next 0/3] Allow bridge to function in non-promisc mode
Date: Thu, 14 Mar 2013 21:18:07 +0200	[thread overview]
Message-ID: <20130314191807.GA30381@redhat.com> (raw)
In-Reply-To: <20130307214304.25e7784e@nehalam.linuxnetplumber.net>

On Thu, Mar 07, 2013 at 09:43:04PM -0800, Stephen Hemminger wrote:
> On Thu,  7 Mar 2013 16:28:45 -0500
> Vlad Yasevich <vyasevic@redhat.com> wrote:
> 
> > The series adds an ability to configure the bridge into a non-primiscuous
> > mode.   Instead, it provides the ability to identitfy some set of bridge
> > ports as uplinks and allows for MAC addresses to be programmed onto
> > those ports.  In case the port hardware does not support mac filter,
> > that port will be placed in promiscuous mode.
> > 
> > Default bridge operation continues to remain as "promiscuous".  The new
> > functionality has to be enabled via sysfs (similar to other bridge extensions).
> > 
> > The uplink mode is implemented as a flag on a bridge port.  The api to
> > change that flag follows the existing api to enable/disable other existing
> > flags.
> > 
> > All comments are welcome.
> > 
> 
> Can we make this a one step process and less visible to the user.
> If user defines an uplink device, and the uplink device is capable of filtering
> (and what ever other pre-conditions people can think of), then the bridge will
> transparently switch to uplink/non-promisc mode.  This can also be used to trigger
> edge only mode in RSTP in the future.
> 
> Less knobs.
> 

Rephrasing what I suggested using 'uplink' term:
- add ability to specify wanted addresses on a port
- wheneever we don't specify addresses we call an uplink
  (either automatically so by default all
  ports are uplink, or add a separate flag - any preference?)
- if there are 0 uplinks, no ports are promisc
- if there is 1 uplink, it is not promisc but all others are promisc
- if there are >1 uplinks, everyone is promisc


> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2013-03-14 19:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-07 21:28 [Bridge] [RFC PATCH v2 net-next 0/3] Allow bridge to function in non-promisc mode Vlad Yasevich
2013-03-07 21:28 ` Vlad Yasevich
2013-03-07 21:28 ` [Bridge] [RFC PATCH v2 net-next 1/3] bridge: Add sysfs interface to control promisc mode Vlad Yasevich
2013-03-07 21:28   ` Vlad Yasevich
2013-03-07 21:28 ` [Bridge] [RFC PATCH v2 net-next 2/3] bridge: Allow an ability to designate an uplink port Vlad Yasevich
2013-03-07 21:28   ` Vlad Yasevich
2013-03-07 21:28 ` [Bridge] [RFC PATCH v2 net-next 3/3] bridge: Implement IFF_UNICAST_FLT Vlad Yasevich
2013-03-07 21:28   ` Vlad Yasevich
2013-03-08  5:43 ` [Bridge] [RFC PATCH v2 net-next 0/3] Allow bridge to function in non-promisc mode Stephen Hemminger
2013-03-08  5:43   ` Stephen Hemminger
2013-03-08 15:17   ` [Bridge] " Vlad Yasevich
2013-03-08 15:17     ` Vlad Yasevich
2013-03-08 21:23     ` [Bridge] " Vlad Yasevich
2013-03-08 21:23       ` Vlad Yasevich
2013-03-08 21:43       ` [Bridge] " Stephen Hemminger
2013-03-08 21:43         ` Stephen Hemminger
2013-03-14 19:18   ` Michael S. Tsirkin [this message]
2013-03-14 19:18     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130314191807.GA30381@redhat.com \
    --to=mst@redhat.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=vyasevic@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.