All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] isdn: hisax: netjet requires VIRT_TO_BUS
Date: Fri, 15 Mar 2013 10:15:00 +0000	[thread overview]
Message-ID: <201303151015.00746.arnd@arndb.de> (raw)
In-Reply-To: <CAMuHMdVhjnX_hag5Y5VvDWVcjPK8tMM-qx-TQ2x=M88yTZQwYg@mail.gmail.com>

On Friday 15 March 2013, Geert Uytterhoeven wrote:
> On Thu, Mar 14, 2013 at 10:56 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > Disabling CONFIG_VIRT_TO_BUS on ARM showed that the hisax netjet
> > driver depends on this deprecated functionality but is not
> > marked so in Kconfig.
> >
> > Rather than adding ARM to the already long list of architectures
> > that this driver is broken on, this patch adds 'depends on
> > VIRT_TO_BUS' and removes the dependency on !SPARC, which is
> > also implied by that.
> 
> IIRC, the real "arch" dependency for this driver is !BIG_ENDIAN, but
> unfortunately
> we don't have a generic Kconfig symbol for that.
> Perhaps we may want to introduce that?
> Of course we prefer to make drivers work on all endianness instead...

CONFIG_VIRT_TO_BUS is certainly also a dependency, since it fails
to build without that. I think we can address the two problems separately.

David Howells brought up the topic of endian checks recently, noting
that the way we define __BIG_ENDIAN and __LITTLE_ENDIAN in the kernel
is incompatible to how do it in user space, and not much better either.

A few architectures that are bi-endian (arc, arm, c6x, mips, sh) already
have CONFIG_CPU_IS_LITTLE_ENDIAN and CONFIG_CPU_IS_BIG_ENDIAN. I guess
it would be a good idea to provide these on all architectures.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Karsten Keil <isdn@linux-pingi.de>,
	netdev@vger.kernel.org, David Howells <dhowells@redhat.com>
Subject: Re: [PATCH] isdn: hisax: netjet requires VIRT_TO_BUS
Date: Fri, 15 Mar 2013 10:15:00 +0000	[thread overview]
Message-ID: <201303151015.00746.arnd@arndb.de> (raw)
In-Reply-To: <CAMuHMdVhjnX_hag5Y5VvDWVcjPK8tMM-qx-TQ2x=M88yTZQwYg@mail.gmail.com>

On Friday 15 March 2013, Geert Uytterhoeven wrote:
> On Thu, Mar 14, 2013 at 10:56 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > Disabling CONFIG_VIRT_TO_BUS on ARM showed that the hisax netjet
> > driver depends on this deprecated functionality but is not
> > marked so in Kconfig.
> >
> > Rather than adding ARM to the already long list of architectures
> > that this driver is broken on, this patch adds 'depends on
> > VIRT_TO_BUS' and removes the dependency on !SPARC, which is
> > also implied by that.
> 
> IIRC, the real "arch" dependency for this driver is !BIG_ENDIAN, but
> unfortunately
> we don't have a generic Kconfig symbol for that.
> Perhaps we may want to introduce that?
> Of course we prefer to make drivers work on all endianness instead...

CONFIG_VIRT_TO_BUS is certainly also a dependency, since it fails
to build without that. I think we can address the two problems separately.

David Howells brought up the topic of endian checks recently, noting
that the way we define __BIG_ENDIAN and __LITTLE_ENDIAN in the kernel
is incompatible to how do it in user space, and not much better either.

A few architectures that are bi-endian (arc, arm, c6x, mips, sh) already
have CONFIG_CPU_IS_LITTLE_ENDIAN and CONFIG_CPU_IS_BIG_ENDIAN. I guess
it would be a good idea to provide these on all architectures.

	Arnd

  reply	other threads:[~2013-03-15 10:15 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-14 21:56 [PATCH 1/3] mfd: remove __exit_p annotation for twl4030_madc_remove Arnd Bergmann
2013-03-14 21:56 ` Arnd Bergmann
2013-03-14 21:56 ` [PATCH 2/3] mfd: Make AB8500_CORE select POWER_SUPPLY to fix build error Arnd Bergmann
2013-03-14 21:56   ` Arnd Bergmann
2013-03-15  6:44   ` Samuel Ortiz
2013-03-15  6:44     ` Samuel Ortiz
2013-03-15 10:18     ` Arnd Bergmann
2013-03-15 10:18       ` Arnd Bergmann
2013-03-15 16:46       ` Samuel Ortiz
2013-03-15 16:46         ` Samuel Ortiz
2013-03-14 21:56 ` [PATCH 3/3] mfd: ab8500: kill "reg" property from binding Arnd Bergmann
2013-03-14 21:56   ` Arnd Bergmann
2013-03-15  6:45   ` Samuel Ortiz
2013-03-15  6:45     ` Samuel Ortiz
2013-03-14 21:56 ` [PATCH] isdn: hisax: netjet requires VIRT_TO_BUS Arnd Bergmann
2013-03-14 21:56   ` Arnd Bergmann
2013-03-15  6:26   ` Geert Uytterhoeven
2013-03-15  6:26     ` Geert Uytterhoeven
2013-03-15 10:15     ` Arnd Bergmann [this message]
2013-03-15 10:15       ` Arnd Bergmann
2013-03-15 12:16       ` David Miller
2013-03-15 12:16         ` David Miller
2013-03-15 12:29         ` Arnd Bergmann
2013-03-15 12:29           ` Arnd Bergmann
2013-03-15 12:33           ` David Miller
2013-03-15 12:33             ` David Miller
2013-03-15 13:41             ` Arnd Bergmann
2013-03-15 13:41               ` Arnd Bergmann
2013-03-17 16:01   ` David Miller
2013-03-17 16:01     ` David Miller
2013-03-14 21:56 ` [PATCH] ethernet/tulip: DE4x5 needs VIRT_TO_BUS Arnd Bergmann
2013-03-14 21:56   ` Arnd Bergmann
2013-03-17 16:01   ` David Miller
2013-03-17 16:01     ` David Miller
2013-03-14 21:56 ` [PATCH] vfio: include <linux/slab.h> for kmalloc Arnd Bergmann
2013-03-14 21:56   ` Arnd Bergmann
2013-03-14 21:56   ` Arnd Bergmann
2013-03-15 20:15   ` Alex Williamson
2013-03-15 20:15     ` Alex Williamson
2013-03-14 21:56 ` [PATCH] [media] ir: IR_RX51 only works on OMAP2 Arnd Bergmann
2013-03-14 21:56   ` Arnd Bergmann
2013-03-15  6:39   ` Timo Kokkonen
2013-03-15  6:39     ` Timo Kokkonen
2013-03-15 16:28     ` Tony Lindgren
2013-03-15 16:28       ` Tony Lindgren
2013-03-18 23:54   ` Mauro Carvalho Chehab
2013-03-18 23:54     ` Mauro Carvalho Chehab
2013-03-15  6:43 ` [PATCH 1/3] mfd: remove __exit_p annotation for twl4030_madc_remove Samuel Ortiz
2013-03-15  6:43   ` Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201303151015.00746.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.