From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Xu Zhang <xzhang@cs.uic.edu>
Cc: samuel.thibault@ens-lyon.org, jeremy@goop.org,
stefano.stabellini@eu.citrix.com, gm281@cam.ac.uk,
xen-devel@lists.xen.org
Subject: Re: [PATCH 4/6] mini-os/x86-64 entry: remove unnecessary event blocking
Date: Fri, 15 Mar 2013 16:16:24 -0400 [thread overview]
Message-ID: <20130315201624.GA30676@phenom.dumpdata.com> (raw)
In-Reply-To: <1362778219-8576-5-git-send-email-xzhang@cs.uic.edu>
On Fri, Mar 08, 2013 at 03:30:17PM -0600, Xu Zhang wrote:
> We don't need to block events here because:
> - if we came from "hypervisor_callback", events are disabled at this point,
> no need to block again;
Hm, I think I am not following it. It does a bit of %gs manipulation which
looks to point to the cpu0_pda.irqcount.
?
> - if we came from "error_entry", we shouldn't touch event mask, for
> exception hanlding are meant to be interrupted by Xen events (virtual
handling
> irq).
>
> Signed-off-by: Xu Zhang <xzhang@cs.uic.edu>
> ---
> extras/mini-os/arch/x86/x86_64.S | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/extras/mini-os/arch/x86/x86_64.S b/extras/mini-os/arch/x86/x86_64.S
> index 79e893f..5e0021b 100644
> --- a/extras/mini-os/arch/x86/x86_64.S
> +++ b/extras/mini-os/arch/x86/x86_64.S
> @@ -185,7 +185,6 @@ ENTRY(hypervisor_callback2)
>
> error_exit:
> RESTORE_REST
> - XEN_BLOCK_EVENTS(%rsi)
>
> retint_kernel:
> retint_restore_args:
> --
> 1.7.7.6
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>
next prev parent reply other threads:[~2013-03-15 20:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 21:30 [PATCH 0/6] mini-os: check and fix up against nested events in x86-64 kernel entry Xu Zhang
2013-03-08 21:30 ` [PATCH 1/6] mini-os/x86-64 entry: code clean-ups Xu Zhang
2013-03-09 20:57 ` Samuel Thibault
2013-03-08 21:30 ` [PATCH 2/6] mini-os/x86-64 entry: define macros for registers partial save and restore Xu Zhang
2013-03-09 20:55 ` Samuel Thibault
2013-03-08 21:30 ` [PATCH 3/6] mini-os/x86-64 entry: code refactoring; no functional changes Xu Zhang
2013-03-09 21:03 ` Samuel Thibault
2013-04-11 4:40 ` Xu Zhang
2013-03-08 21:30 ` [PATCH 4/6] mini-os/x86-64 entry: remove unnecessary event blocking Xu Zhang
2013-03-09 21:07 ` Samuel Thibault
2013-03-15 20:16 ` Konrad Rzeszutek Wilk [this message]
2013-04-11 4:40 ` Xu Zhang
2013-03-08 21:30 ` [PATCH 5/6] mini-os/x86-64 entry: defer RESTORE_REST until return Xu Zhang
2013-03-09 21:15 ` Samuel Thibault
2013-03-08 21:30 ` [PATCH 6/6] mini-os/x86-64 entry: check against nested events and try to fix up Xu Zhang
2013-03-09 21:19 ` Samuel Thibault
2013-03-13 2:42 ` Xu Zhang
2013-03-09 22:44 ` Jeremy Fitzhardinge
2013-03-13 2:42 ` Xu Zhang
2013-03-13 5:53 ` Xu Zhang
2013-03-14 1:09 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130315201624.GA30676@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=gm281@cam.ac.uk \
--cc=jeremy@goop.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=xzhang@cs.uic.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.