From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
Minchan Kim <minchan@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/5] zero-filled pages awareness
Date: Mon, 18 Mar 2013 17:50:23 -0700 [thread overview]
Message-ID: <20130319005023.GA19891@kroah.com> (raw)
In-Reply-To: <1363314860-22731-3-git-send-email-liwanp@linux.vnet.ibm.com>
On Fri, Mar 15, 2013 at 10:34:17AM +0800, Wanpeng Li wrote:
> Compression of zero-filled pages can unneccessarily cause internal
> fragmentation, and thus waste memory. This special case can be
> optimized.
>
> This patch captures zero-filled pages, and marks their corresponding
> zcache backing page entry as zero-filled. Whenever such zero-filled
> page is retrieved, we fill the page frame with zero.
>
> Acked-by: Dan Magenheimer <dan.magenheimer@oracle.com>
> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
This patch applies with a bunch of fuzz, meaning it wasn't made against
the latest tree, which worries me. Care to redo it, and the rest of the
series, and resend it?
thanks,
greg k-h
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
Minchan Kim <minchan@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/5] zero-filled pages awareness
Date: Mon, 18 Mar 2013 17:50:23 -0700 [thread overview]
Message-ID: <20130319005023.GA19891@kroah.com> (raw)
In-Reply-To: <1363314860-22731-3-git-send-email-liwanp@linux.vnet.ibm.com>
On Fri, Mar 15, 2013 at 10:34:17AM +0800, Wanpeng Li wrote:
> Compression of zero-filled pages can unneccessarily cause internal
> fragmentation, and thus waste memory. This special case can be
> optimized.
>
> This patch captures zero-filled pages, and marks their corresponding
> zcache backing page entry as zero-filled. Whenever such zero-filled
> page is retrieved, we fill the page frame with zero.
>
> Acked-by: Dan Magenheimer <dan.magenheimer@oracle.com>
> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
This patch applies with a bunch of fuzz, meaning it wasn't made against
the latest tree, which worries me. Care to redo it, and the rest of the
series, and resend it?
thanks,
greg k-h
next prev parent reply other threads:[~2013-03-19 0:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 2:34 [PATCH v3 0/5] zcache: Support zero-filled pages more efficiently Wanpeng Li
2013-03-15 2:34 ` Wanpeng Li
2013-03-15 2:34 ` [PATCH v3 1/5] introduce zero filled pages handler Wanpeng Li
2013-03-15 2:34 ` Wanpeng Li
2013-03-15 2:34 ` [PATCH v3 2/5] zero-filled pages awareness Wanpeng Li
2013-03-15 2:34 ` Wanpeng Li
2013-03-16 14:12 ` Bob Liu
2013-03-16 14:12 ` Bob Liu
2013-03-17 0:04 ` Wanpeng Li
2013-03-17 0:04 ` Wanpeng Li
2013-03-19 0:50 ` Greg Kroah-Hartman [this message]
2013-03-19 0:50 ` Greg Kroah-Hartman
2013-03-19 1:23 ` Wanpeng Li
2013-03-19 1:23 ` Wanpeng Li
2013-03-15 2:34 ` [PATCH v3 3/5] handle zcache_[eph|pers]_zpages for zero-filled page Wanpeng Li
2013-03-15 2:34 ` Wanpeng Li
2013-03-16 13:11 ` Konrad Rzeszutek Wilk
2013-03-16 13:11 ` Konrad Rzeszutek Wilk
2013-03-17 0:05 ` Wanpeng Li
2013-03-17 0:05 ` Wanpeng Li
2013-03-15 2:34 ` [PATCH v3 4/5] introduce zero-filled page stat count Wanpeng Li
2013-03-15 2:34 ` Wanpeng Li
2013-03-15 2:34 ` [PATCH v3 5/5] clean TODO list Wanpeng Li
2013-03-15 2:34 ` Wanpeng Li
2013-03-19 0:23 ` [PATCH v3 0/5] zcache: Support zero-filled pages more efficiently Greg Kroah-Hartman
2013-03-19 0:23 ` Greg Kroah-Hartman
2013-03-19 1:13 ` Wanpeng Li
2013-03-19 1:13 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130319005023.GA19891@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=dan.magenheimer@oracle.com \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=minchan@kernel.org \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.