From: Mike Turquette <mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Peter De Schrijver
<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>Peter De
Schrijver <pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Prashant Gaikwad
<pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] clk: add table lookup to mux
Date: Tue, 19 Mar 2013 16:51:10 -0700 [thread overview]
Message-ID: <20130319235110.8663.67548@quantum> (raw)
In-Reply-To: <1363113747-6572-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Quoting Peter De Schrijver (2013-03-12 11:42:23)
> diff --git a/include/linux/clk-private.h b/include/linux/clk-private.h
> index 9c7f580..53d39c2 100644
> --- a/include/linux/clk-private.h
> +++ b/include/linux/clk-private.h
> @@ -144,12 +144,13 @@ struct clk {
>
> #define DEFINE_CLK_MUX(_name, _parent_names, _parents, _flags, \
> _reg, _shift, _width, \
> - _mux_flags, _lock) \
> + _mux_flags, _table, _lock) \
> static struct clk _name; \
> static struct clk_mux _name##_hw = { \
> .hw = { \
> .clk = &_name, \
> }, \
> + .table = _table, \
> .reg = _reg, \
> .shift = _shift, \
> .width = _width, \
This breaks OMAP horribly since OMAP already uses this macro. There are
two options:
1) stop using statically initialized data and no longer use
clk-private.h macros. I was under the impression that the tegra clock
data no longer required this?
2) if you must continue to use the clk-private.h macros (temporarily!)
then create a new one, DEFINE_CLK_MUX_TABLE.
Regards,
Mike
WARNING: multiple messages have this Message-ID (diff)
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: add table lookup to mux
Date: Tue, 19 Mar 2013 16:51:10 -0700 [thread overview]
Message-ID: <20130319235110.8663.67548@quantum> (raw)
In-Reply-To: <1363113747-6572-1-git-send-email-pdeschrijver@nvidia.com>
Quoting Peter De Schrijver (2013-03-12 11:42:23)
> diff --git a/include/linux/clk-private.h b/include/linux/clk-private.h
> index 9c7f580..53d39c2 100644
> --- a/include/linux/clk-private.h
> +++ b/include/linux/clk-private.h
> @@ -144,12 +144,13 @@ struct clk {
>
> #define DEFINE_CLK_MUX(_name, _parent_names, _parents, _flags, \
> _reg, _shift, _width, \
> - _mux_flags, _lock) \
> + _mux_flags, _table, _lock) \
> static struct clk _name; \
> static struct clk_mux _name##_hw = { \
> .hw = { \
> .clk = &_name, \
> }, \
> + .table = _table, \
> .reg = _reg, \
> .shift = _shift, \
> .width = _width, \
This breaks OMAP horribly since OMAP already uses this macro. There are
two options:
1) stop using statically initialized data and no longer use
clk-private.h macros. I was under the impression that the tegra clock
data no longer required this?
2) if you must continue to use the clk-private.h macros (temporarily!)
then create a new one, DEFINE_CLK_MUX_TABLE.
Regards,
Mike
WARNING: multiple messages have this Message-ID (diff)
From: Mike Turquette <mturquette@linaro.org>
To: Peter De Schrijver <pdeschrijver@nvidia.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: <linux-tegra@vger.kernel.org>,
Stephen Warren <swarren@nvidia.com>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: add table lookup to mux
Date: Tue, 19 Mar 2013 16:51:10 -0700 [thread overview]
Message-ID: <20130319235110.8663.67548@quantum> (raw)
In-Reply-To: <1363113747-6572-1-git-send-email-pdeschrijver@nvidia.com>
Quoting Peter De Schrijver (2013-03-12 11:42:23)
> diff --git a/include/linux/clk-private.h b/include/linux/clk-private.h
> index 9c7f580..53d39c2 100644
> --- a/include/linux/clk-private.h
> +++ b/include/linux/clk-private.h
> @@ -144,12 +144,13 @@ struct clk {
>
> #define DEFINE_CLK_MUX(_name, _parent_names, _parents, _flags, \
> _reg, _shift, _width, \
> - _mux_flags, _lock) \
> + _mux_flags, _table, _lock) \
> static struct clk _name; \
> static struct clk_mux _name##_hw = { \
> .hw = { \
> .clk = &_name, \
> }, \
> + .table = _table, \
> .reg = _reg, \
> .shift = _shift, \
> .width = _width, \
This breaks OMAP horribly since OMAP already uses this macro. There are
two options:
1) stop using statically initialized data and no longer use
clk-private.h macros. I was under the impression that the tegra clock
data no longer required this?
2) if you must continue to use the clk-private.h macros (temporarily!)
then create a new one, DEFINE_CLK_MUX_TABLE.
Regards,
Mike
next prev parent reply other threads:[~2013-03-19 23:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 18:42 [PATCH] clk: add table lookup to mux Peter De Schrijver
2013-03-12 18:42 ` Peter De Schrijver
2013-03-12 18:42 ` Peter De Schrijver
[not found] ` <1363113747-6572-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-12 18:53 ` Stephen Warren
2013-03-12 18:53 ` Stephen Warren
2013-03-12 18:53 ` Stephen Warren
2013-03-19 21:37 ` Mike Turquette
2013-03-19 21:37 ` Mike Turquette
2013-03-19 21:43 ` Stephen Warren
2013-03-19 21:43 ` Stephen Warren
2013-03-19 21:43 ` Stephen Warren
2013-03-19 21:33 ` Mike Turquette
2013-03-19 21:33 ` Mike Turquette
2013-03-19 21:33 ` Mike Turquette
2013-03-19 21:42 ` Stephen Warren
2013-03-19 21:42 ` Stephen Warren
2013-03-19 21:42 ` Stephen Warren
2013-03-20 9:40 ` Peter De Schrijver
2013-03-20 9:40 ` Peter De Schrijver
2013-03-20 9:40 ` Peter De Schrijver
2013-03-19 23:51 ` Mike Turquette [this message]
2013-03-19 23:51 ` Mike Turquette
2013-03-19 23:51 ` Mike Turquette
2013-03-20 9:49 ` Peter De Schrijver
2013-03-20 9:49 ` Peter De Schrijver
2013-03-20 9:49 ` Peter De Schrijver
2013-03-20 15:51 ` Mike Turquette
2013-03-20 15:51 ` Mike Turquette
2013-03-21 9:45 ` Peter De Schrijver
2013-03-21 9:45 ` Peter De Schrijver
2013-03-21 9:45 ` Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130319235110.8663.67548@quantum \
--to=mturquette-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.