From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org,
Ismael Luceno <ismael.luceno@corp.bluecherry.net>,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [REVIEW PATCH 01/19] solo6x10: sync to latest code from Bluecherry's git repo.
Date: Sun, 24 Mar 2013 11:27:23 -0300 [thread overview]
Message-ID: <20130324112723.445693ea@redhat.com> (raw)
In-Reply-To: <1363609938-21735-2-git-send-email-hverkuil@xs4all.nl>
Em Mon, 18 Mar 2013 13:32:00 +0100
Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> Synced to commit e9815ac5503ae60cfbf6ff8037035de8f62e2846 from
> branch next in git repository https://github.com/bluecherrydvr/solo6x10.git
>
> Only removed some code under #if LINUX_VERSION_CODE < some-kernel-version,
> renamed the driver back to solo6x10 from solo6x10-edge and removed the
> unnecessary compat.h header.
>
> Otherwise the code is identical.
>
...
> @@ -21,29 +26,78 @@
> #include <linux/module.h>
> #include <linux/pci.h>
> #include <linux/interrupt.h>
> -#include <linux/slab.h>
You can't remove slab.h if any k*alloc function is used, or it will
break compilation, depending on the Kconfig options selected.
The same type of removal are on other files inside this patch.
Please fix.
Regards,
Mauro
next prev parent reply other threads:[~2013-03-24 14:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 12:31 [REVIEW PATCH 00/19] solo6x10: driver overhaul Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 01/19] solo6x10: sync to latest code from Bluecherry's git repo Hans Verkuil
2013-03-24 14:27 ` Mauro Carvalho Chehab [this message]
2013-03-25 8:51 ` Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 02/19] solo6x10: fix querycap and update driver version Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 03/19] solo6x10: add v4l2_device Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 04/19] solo6x10: add control framework Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 05/19] solo6x10: fix various format-related compliancy issues Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 06/19] solo6x10: add support for prio and control event handling Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 07/19] solo6x10: move global fields in solo_dev_fh to solo_dev Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 08/19] solo6x10: move global fields in solo_enc_fh to solo_enc_dev Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 09/19] solo6x10: convert encoder nodes to vb2 Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 10/19] solo6x10: convert the display node " Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 11/19] solo6x10: fix 'BUG: key ffff88081a2a9b58 not in .data!' Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 12/19] solo6x10: add call to pci_dma_mapping_error Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 13/19] solo6x10: drop video_type and add proper s_std support Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 14/19] solo6x10: also stop DMA if the SOLO_PCI_ERR_P2M_DESC is raised Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 15/19] solo6x10: small big-endian fix Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 16/19] solo6x10: use V4L2_PIX_FMT_MPEG4, not _FMT_MPEG Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 17/19] solo6x10: fix sequence handling Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 18/19] solo6x10: disable the 'priv' abuse Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 19/19] solo6x10: clean up motion detection handling Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130324112723.445693ea@redhat.com \
--to=mchehab@redhat.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=ismael.luceno@corp.bluecherry.net \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.