All of lore.kernel.org
 help / color / mirror / Atom feed
* [REVIEW PATCH 00/19] solo6x10: driver overhaul
@ 2013-03-18 12:31 Hans Verkuil
  2013-03-18 12:32 ` [REVIEW PATCH 01/19] solo6x10: sync to latest code from Bluecherry's git repo Hans Verkuil
                   ` (18 more replies)
  0 siblings, 19 replies; 22+ messages in thread
From: Hans Verkuil @ 2013-03-18 12:31 UTC (permalink / raw)
  To: linux-media; +Cc: Ismael Luceno

Hi all,

This is my second attempt. This time I sync to the latest code from Bluecherry
first before applying my patches.

Remaining open issues:

1) Most importantly, the video from video0 is broken: it is supposed to be
   either one of the four inputs or a 2x2 image of all four inputs, instead I
   always get the first video line of the input repeated for the whole image.

   I have no idea why and it would be very nice if someone from Bluecherry
   can look at this. I do not see anything wrong in the DMA code, so it is
   a mystery to me.

2) I couldn't get it to work on a big-endian system. Perhaps it is because
   the PCI card is sitting in a PCIe slot using a PCIe-to-PCI adapter.

3) The 'extended streams' have been disabled. Basically you can get two
   encoded streams out of the box: each with different encoder settings
   (e.g. high and low bitrates). This should probably be implemented as
   an extra video node.

4) There is a custom extension for motion detection. Besides adding two
   private ioctls to support regional motion thresholds I left that part
   otherwise unchanged as it doesn't look too bad, but I am unable to test
   it properly. I've ordered a suitable CCTV camera from dealextreme, but that
   will take a few weeks before I have it (dx.com is cheap, but delivery is
   quite slow). I'd like to experiment a bit with this.

5) The tw28* 'drivers' should really be split off as subdevice drivers.

6) Capture of video0 is now using dma-contig. It used to be dma-sg, but due
   to locking issues Bluecherry changed it to dma-contig. So I've kept it
   that way, but it can probably be converted back to dma-sg. But issue 1 should
   be fixed first before we mess with this.

So there is still work to be done, but at least the driver is in a much better
state.

If there are no more comments, then I'll add a final patch that prefixes the
sources with 'solo6x10-' and post a pull request on Friday.

The idea is that Bluecherry will develop from this code base and keep the
kernel driver in sync.

Regards,

	Hans



^ permalink raw reply	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2013-03-25  8:51 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-18 12:31 [REVIEW PATCH 00/19] solo6x10: driver overhaul Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 01/19] solo6x10: sync to latest code from Bluecherry's git repo Hans Verkuil
2013-03-24 14:27   ` Mauro Carvalho Chehab
2013-03-25  8:51     ` Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 02/19] solo6x10: fix querycap and update driver version Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 03/19] solo6x10: add v4l2_device Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 04/19] solo6x10: add control framework Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 05/19] solo6x10: fix various format-related compliancy issues Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 06/19] solo6x10: add support for prio and control event handling Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 07/19] solo6x10: move global fields in solo_dev_fh to solo_dev Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 08/19] solo6x10: move global fields in solo_enc_fh to solo_enc_dev Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 09/19] solo6x10: convert encoder nodes to vb2 Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 10/19] solo6x10: convert the display node " Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 11/19] solo6x10: fix 'BUG: key ffff88081a2a9b58 not in .data!' Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 12/19] solo6x10: add call to pci_dma_mapping_error Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 13/19] solo6x10: drop video_type and add proper s_std support Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 14/19] solo6x10: also stop DMA if the SOLO_PCI_ERR_P2M_DESC is raised Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 15/19] solo6x10: small big-endian fix Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 16/19] solo6x10: use V4L2_PIX_FMT_MPEG4, not _FMT_MPEG Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 17/19] solo6x10: fix sequence handling Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 18/19] solo6x10: disable the 'priv' abuse Hans Verkuil
2013-03-18 12:32 ` [REVIEW PATCH 19/19] solo6x10: clean up motion detection handling Hans Verkuil

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.