From: Florian Fainelli <florian@openwrt.org>
To: Simon Baatz <gmbnomis@gmail.com>
Cc: thomas.petazzoni@free-electrons.com, andrew@lunn.ch,
jason@lakedaemon.net, netdev@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/2] Fix for mv643xx_eth built as module
Date: Sun, 24 Mar 2013 21:48:33 +0100 [thread overview]
Message-ID: <201303242148.33842.florian@openwrt.org> (raw)
In-Reply-To: <1364157240-28883-1-git-send-email-gmbnomis@gmail.com>
Hello Simon,
Le dimanche 24 mars 2013 21:33:58, Simon Baatz a =C3=A9crit :
> Recently [1], mv643xx_eth was changed to make use of mvmdio. However,
> this change introduces two problems when mvmdio and mv643xx_eth are
> built as modules:
>=20
> - mvmdio is not loaded automatically by udev
> - mv643xx_eth oopses when it can't find its PHY, i.e. when mvmdio is
> not yet loaded
>=20
> The first problem can be fixed easily by adding a module alias for the
> respective platform device. The proposed fix for the second problem
> uses EPROBE_DEFER as suggested by Thomas Petazzoni when the driver
> can't find its PHY.
>=20
> These patches apply on top of Florian Fainelli's patchset. They have
> been tested on Marvel Kirkwood non-DT.
Both fixes look good to me, thanks for fixing this!
Acked-by: Florian Fainelli <florian@openwrt.org>
=2D-=20
=46lorian
WARNING: multiple messages have this Message-ID (diff)
From: florian@openwrt.org (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] Fix for mv643xx_eth built as module
Date: Sun, 24 Mar 2013 21:48:33 +0100 [thread overview]
Message-ID: <201303242148.33842.florian@openwrt.org> (raw)
In-Reply-To: <1364157240-28883-1-git-send-email-gmbnomis@gmail.com>
Hello Simon,
Le dimanche 24 mars 2013 21:33:58, Simon Baatz a ?crit :
> Recently [1], mv643xx_eth was changed to make use of mvmdio. However,
> this change introduces two problems when mvmdio and mv643xx_eth are
> built as modules:
>
> - mvmdio is not loaded automatically by udev
> - mv643xx_eth oopses when it can't find its PHY, i.e. when mvmdio is
> not yet loaded
>
> The first problem can be fixed easily by adding a module alias for the
> respective platform device. The proposed fix for the second problem
> uses EPROBE_DEFER as suggested by Thomas Petazzoni when the driver
> can't find its PHY.
>
> These patches apply on top of Florian Fainelli's patchset. They have
> been tested on Marvel Kirkwood non-DT.
Both fixes look good to me, thanks for fixing this!
Acked-by: Florian Fainelli <florian@openwrt.org>
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <florian@openwrt.org>
To: Simon Baatz <gmbnomis@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
thomas.petazzoni@free-electrons.com, jason@lakedaemon.net,
andrew@lunn.ch, davem@davemloft.net
Subject: Re: [PATCH 0/2] Fix for mv643xx_eth built as module
Date: Sun, 24 Mar 2013 21:48:33 +0100 [thread overview]
Message-ID: <201303242148.33842.florian@openwrt.org> (raw)
In-Reply-To: <1364157240-28883-1-git-send-email-gmbnomis@gmail.com>
Hello Simon,
Le dimanche 24 mars 2013 21:33:58, Simon Baatz a écrit :
> Recently [1], mv643xx_eth was changed to make use of mvmdio. However,
> this change introduces two problems when mvmdio and mv643xx_eth are
> built as modules:
>
> - mvmdio is not loaded automatically by udev
> - mv643xx_eth oopses when it can't find its PHY, i.e. when mvmdio is
> not yet loaded
>
> The first problem can be fixed easily by adding a module alias for the
> respective platform device. The proposed fix for the second problem
> uses EPROBE_DEFER as suggested by Thomas Petazzoni when the driver
> can't find its PHY.
>
> These patches apply on top of Florian Fainelli's patchset. They have
> been tested on Marvel Kirkwood non-DT.
Both fixes look good to me, thanks for fixing this!
Acked-by: Florian Fainelli <florian@openwrt.org>
--
Florian
next prev parent reply other threads:[~2013-03-24 20:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-24 20:33 [PATCH 0/2] Fix for mv643xx_eth built as module Simon Baatz
2013-03-24 20:33 ` Simon Baatz
2013-03-24 20:33 ` Simon Baatz
2013-03-24 20:33 ` [PATCH 1/2] net: mvmdio: define module alias for platform device Simon Baatz
2013-03-24 20:33 ` Simon Baatz
2013-03-24 20:33 ` Simon Baatz
2013-03-24 20:34 ` [PATCH 2/2] mv643xx_eth: defer probing if Marvell Orion MDIO driver not loaded Simon Baatz
2013-03-24 20:34 ` Simon Baatz
2013-03-24 20:34 ` Simon Baatz
2013-03-24 20:48 ` Florian Fainelli [this message]
2013-03-24 20:48 ` [PATCH 0/2] Fix for mv643xx_eth built as module Florian Fainelli
2013-03-24 20:48 ` Florian Fainelli
2013-03-24 21:07 ` David Miller
2013-03-24 21:07 ` David Miller
2013-03-24 21:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303242148.33842.florian@openwrt.org \
--to=florian@openwrt.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=gmbnomis@gmail.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.