All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 1/4] arm: orion5x: fix orion5x.dtsi gpio parameters
Date: Mon, 25 Mar 2013 09:43:12 +0100	[thread overview]
Message-ID: <20130325084312.GE5627@lunn.ch> (raw)
In-Reply-To: <1364077797-21206-2-git-send-email-alex@digriz.org.uk>

On Sat, Mar 23, 2013 at 10:29:54PM +0000, Alexander Clouter wrote:
> orion5x.dtsi is missing the gpio alias as well as including a typo
> ('ngpio' instead of 'ngpios') that prevented the orion-gpio driver
> from loading.  This patches resolves this.
> 
> Signed-off-by: Alexander Clouter <alex@digriz.org.uk>
> ---
>  arch/arm/boot/dts/orion5x.dtsi |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/orion5x.dtsi b/arch/arm/boot/dts/orion5x.dtsi
> index 8aad00f..9bde027 100644
> --- a/arch/arm/boot/dts/orion5x.dtsi
> +++ b/arch/arm/boot/dts/orion5x.dtsi
> @@ -13,6 +13,9 @@
>  	compatible = "marvell,orion5x";
>  	interrupt-parent = <&intc>;
>  
> +	aliases {
> +		gpio0 = &gpio0;
> +	};
>  	intc: interrupt-controller {
>  		compatible = "marvell,orion-intc", "marvell,intc";
>  		interrupt-controller;
> @@ -32,7 +35,7 @@
>  			#gpio-cells = <2>;
>  			gpio-controller;
>  			reg = <0x10100 0x40>;
> -			ngpio = <32>;
> +			ngpios = <32>;
>  			interrupts = <6>, <7>, <8>, <9>;
>  		};

Hi Alex

If you look at Dove, Kirkwood, etc, you see:

                gpio0: gpio at d0400 {
                        compatible = "marvell,orion-gpio";
                        #gpio-cells = <2>;
                        gpio-controller;
                        reg = <0xd0400 0x20>;
                        ngpios = <32>;
                        interrupt-controller;
                        #interrupt-cells = <2>;
                        interrupts = <12>, <13>, <14>, <60>;
                };

I think you also need to add

                        interrupt-controller;
                        #interrupt-cells = <2>;


	Andrew

  reply	other threads:[~2013-03-25  8:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-23 22:29 [PATCHv2 0/4] arm: orion5x: devicetree fixups and additions Alexander Clouter
2013-03-23 22:29 ` [PATCHv2 1/4] arm: orion5x: fix orion5x.dtsi gpio parameters Alexander Clouter
2013-03-25  8:43   ` Andrew Lunn [this message]
2013-03-26 21:02     ` Alexander Clouter
2013-03-23 22:29 ` [PATCHv2 2/4] arm: orion5x: add ehci bindings to dtsi Alexander Clouter
2013-03-23 22:29 ` [PATCHv2 3/4] arm: orion5x: enable xor for orion5x platform Alexander Clouter
2013-03-23 22:29 ` [PATCHv2 4/4] arm: orion5x: correct IRQ used in dtsi for mv_cesa Alexander Clouter
2013-03-25  8:47   ` Andrew Lunn
2013-03-26 21:02     ` Alexander Clouter
2013-03-24  9:48 ` [PATCHv2 0/4] arm: orion5x: devicetree fixups and additions Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130325084312.GE5627@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.