All of lore.kernel.org
 help / color / mirror / Atom feed
From: alex@digriz.org.uk (Alexander Clouter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 1/4] arm: orion5x: fix orion5x.dtsi gpio parameters
Date: Tue, 26 Mar 2013 21:02:56 +0000	[thread overview]
Message-ID: <20130326210256.GO7123@edkhil> (raw)
In-Reply-To: <20130325084312.GE5627@lunn.ch>

Hi,

On Mon, Mar 25, 2013 at 09:43:12AM +0100, Andrew Lunn wrote:
>If you look at Dove, Kirkwood, etc, you see:
>
>                gpio0: gpio at d0400 {
>                        compatible = "marvell,orion-gpio";
>                        #gpio-cells = <2>;
>                        gpio-controller;
>                        reg = <0xd0400 0x20>;
>                        ngpios = <32>;
>                        interrupt-controller;
>                        #interrupt-cells = <2>;
>                        interrupts = <12>, <13>, <14>, <60>;
>                };
>
>I think you also need to add
>
>                        interrupt-controller;
>                        #interrupt-cells = <2>;
>
Darn, I had noticed this and pondered, then thought to wait for someone brighter to point it out 
authoritively :)

Wanging out an update to this patch too.

Cheers

-- 
Alexander Clouter
.sigmonster says: I'd like some JUNK FOOD ... and then I want to be ALONE --

  reply	other threads:[~2013-03-26 21:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-23 22:29 [PATCHv2 0/4] arm: orion5x: devicetree fixups and additions Alexander Clouter
2013-03-23 22:29 ` [PATCHv2 1/4] arm: orion5x: fix orion5x.dtsi gpio parameters Alexander Clouter
2013-03-25  8:43   ` Andrew Lunn
2013-03-26 21:02     ` Alexander Clouter [this message]
2013-03-23 22:29 ` [PATCHv2 2/4] arm: orion5x: add ehci bindings to dtsi Alexander Clouter
2013-03-23 22:29 ` [PATCHv2 3/4] arm: orion5x: enable xor for orion5x platform Alexander Clouter
2013-03-23 22:29 ` [PATCHv2 4/4] arm: orion5x: correct IRQ used in dtsi for mv_cesa Alexander Clouter
2013-03-25  8:47   ` Andrew Lunn
2013-03-26 21:02     ` Alexander Clouter
2013-03-24  9:48 ` [PATCHv2 0/4] arm: orion5x: devicetree fixups and additions Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130326210256.GO7123@edkhil \
    --to=alex@digriz.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.