* [PATCH bluez] sdptool: fix recursive search
@ 2013-03-18 17:41 David Herrmann
2013-03-25 10:46 ` Johan Hedberg
0 siblings, 1 reply; 2+ messages in thread
From: David Herrmann @ 2013-03-18 17:41 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Johan Hedberg, Marcel Holtmann, David Herrmann
When doing recursive SDP searches, we must not overwrite our own values
after we retrieved them from SDP. Otherwise, the UUID test will always we
false.
---
tools/sdptool.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/sdptool.c b/tools/sdptool.c
index 458d005..0a949f2 100644
--- a/tools/sdptool.c
+++ b/tools/sdptool.c
@@ -3812,9 +3812,10 @@ static int do_search(bdaddr_t *bdaddr, struct search_context *context)
break;
}
+ /* Set the subcontext for browsing the sub tree */
+ memcpy(&sub_context, context, sizeof(struct search_context));
+
if (sdp_get_group_id(rec, &sub_context.group) != -1) {
- /* Set the subcontext for browsing the sub tree */
- memcpy(&sub_context, context, sizeof(struct search_context));
/* Browse the next level down if not done */
if (sub_context.group.value.uuid16 != context->group.value.uuid16)
do_search(bdaddr, &sub_context);
--
1.8.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bluez] sdptool: fix recursive search
2013-03-18 17:41 [PATCH bluez] sdptool: fix recursive search David Herrmann
@ 2013-03-25 10:46 ` Johan Hedberg
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2013-03-25 10:46 UTC (permalink / raw)
To: David Herrmann; +Cc: linux-bluetooth, Marcel Holtmann
Hi David,
On Mon, Mar 18, 2013, David Herrmann wrote:
> When doing recursive SDP searches, we must not overwrite our own values
> after we retrieved them from SDP. Otherwise, the UUID test will always we
> false.
> ---
> tools/sdptool.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Applied. Thanks.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-25 10:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-18 17:41 [PATCH bluez] sdptool: fix recursive search David Herrmann
2013-03-25 10:46 ` Johan Hedberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.