From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Ian Lartey <ian@slimlogic.co.uk>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-leds@vger.kernel.org,
linux-watchdog@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, grant.likely@secretlab.ca,
rob.herring@calxeda.com, rob@landley.net, mturquette@linaro.org,
linus.walleij@linaro.org, cooloney@gmail.com,
sfr@canb.auug.org.au, rpurdie@rpsys.net,
akpm@linux-foundation.org, sameo@linux.intel.com, wim@iguana.be,
lgirdwood@gmail.com, gg@slimlogic.co.uk, j-keerthy@ti.com,
ldewangan@nvidia.com, t-kristo@ti.com
Subject: Re: [PATCH v10 01/12] mfd: DT bindings for the palmas family MFD
Date: Mon, 25 Mar 2013 19:47:21 +0000 [thread overview]
Message-ID: <20130325194711.GT18316@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <5150906F.9040202@wwwdotorg.org>
[-- Attachment #1: Type: text/plain, Size: 1485 bytes --]
On Mon, Mar 25, 2013 at 11:59:11AM -0600, Stephen Warren wrote:
> On 03/22/2013 08:55 AM, Ian Lartey wrote:
> > From: Graeme Gregory <gg@slimlogic.co.uk>
> > +Optional nodes:
> > +- regulators : should contain the constrains and init information for the
> > + regulators. It should contain a subnode per regulator from the
> > + list.
> > + For ti,palmas-pmic - smps12, smps123, smps3 depending on OTP,
> > + smps45, smps457, smps7 depending on varient, smps6, smps[8-10],
> > + ldo[1-9], ldoln, ldousb
> > + For ti,palmas-charger-pmic - smps12, smps123, smps3 depending on OTP,
> > + smps[6-9], boost, ldo[1-14], ldoln, ldousb
> The list of legal compatible values for this node above doesn't include
> both ti,palmas-pmic and ti,palmas-charger-pmic. Should it? This node
> should describe this PMIC block in a completely standalone fashion,
> without the need to go look at the top-level node to see if it's a
> "charger" variant or not.
The latter was removed from the code in this series, only palmas-pmic is
present now.
Just as a general thing there seems to be an awful lot of stuff here
about the boilerplate for the generic properties like the interrupt
and GPIO controller stuff - we probably need to spin round and look at
factoring this out to make life easier. There seems to be a lot of
boiler plate in the bindings that is factored out well by the frameworks
in the code so people don't even need to think about it.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10 01/12] mfd: DT bindings for the palmas family MFD
Date: Mon, 25 Mar 2013 19:47:21 +0000 [thread overview]
Message-ID: <20130325194711.GT18316@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <5150906F.9040202@wwwdotorg.org>
On Mon, Mar 25, 2013 at 11:59:11AM -0600, Stephen Warren wrote:
> On 03/22/2013 08:55 AM, Ian Lartey wrote:
> > From: Graeme Gregory <gg@slimlogic.co.uk>
> > +Optional nodes:
> > +- regulators : should contain the constrains and init information for the
> > + regulators. It should contain a subnode per regulator from the
> > + list.
> > + For ti,palmas-pmic - smps12, smps123, smps3 depending on OTP,
> > + smps45, smps457, smps7 depending on varient, smps6, smps[8-10],
> > + ldo[1-9], ldoln, ldousb
> > + For ti,palmas-charger-pmic - smps12, smps123, smps3 depending on OTP,
> > + smps[6-9], boost, ldo[1-14], ldoln, ldousb
> The list of legal compatible values for this node above doesn't include
> both ti,palmas-pmic and ti,palmas-charger-pmic. Should it? This node
> should describe this PMIC block in a completely standalone fashion,
> without the need to go look at the top-level node to see if it's a
> "charger" variant or not.
The latter was removed from the code in this series, only palmas-pmic is
present now.
Just as a general thing there seems to be an awful lot of stuff here
about the boilerplate for the generic properties like the interrupt
and GPIO controller stuff - we probably need to spin round and look at
factoring this out to make life easier. There seems to be a lot of
boiler plate in the bindings that is factored out well by the frameworks
in the code so people don't even need to think about it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130325/8d8b256f/attachment.sig>
next prev parent reply other threads:[~2013-03-25 19:47 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 14:55 [PATCH v10 0/12] Palmas updates Ian Lartey
2013-03-22 14:55 ` Ian Lartey
2013-03-22 14:55 ` Ian Lartey
2013-03-22 14:55 ` [PATCH v10 01/12] mfd: DT bindings for the palmas family MFD Ian Lartey
2013-03-22 14:55 ` Ian Lartey
2013-03-22 14:55 ` Ian Lartey
2013-03-25 17:59 ` Stephen Warren
2013-03-25 17:59 ` Stephen Warren
2013-03-25 19:47 ` Mark Brown [this message]
2013-03-25 19:47 ` Mark Brown
2013-05-30 11:33 ` keerthy
2013-05-30 11:33 ` keerthy
2013-05-30 11:33 ` keerthy
2013-05-30 23:03 ` Stephen Warren
2013-05-30 23:03 ` Stephen Warren
2013-05-30 23:03 ` Stephen Warren
2013-06-03 6:55 ` J, KEERTHY
2013-06-03 6:55 ` J, KEERTHY
2013-06-04 6:24 ` gg
2013-06-04 6:24 ` gg
2013-06-04 6:24 ` gg at slimlogic.co.uk
2013-03-22 14:55 ` [PATCH v10 02/12] mfd: palmas: is_palmas_charger needed by multiple drivers Ian Lartey
2013-03-22 14:55 ` Ian Lartey
2013-04-08 15:51 ` Samuel Ortiz
2013-04-08 15:51 ` Samuel Ortiz
2013-04-08 15:51 ` Samuel Ortiz
2013-03-22 14:55 ` [PATCH v10 03/12] mfd: palmas add variant and OTP detection Ian Lartey
2013-03-22 14:55 ` Ian Lartey
2013-03-22 14:55 ` Ian Lartey
2013-04-05 16:32 ` Samuel Ortiz
2013-04-05 16:32 ` Samuel Ortiz
2013-04-05 16:32 ` Samuel Ortiz
2013-03-22 14:55 ` [PATCH v10 04/12] watchdog: add Palmas Watchdog support Ian Lartey
2013-03-22 14:55 ` Ian Lartey
2013-03-22 14:55 ` Ian Lartey
2013-03-24 3:19 ` Guenter Roeck
2013-08-20 20:31 ` Wim Van Sebroeck
2013-03-22 14:55 ` [PATCH v10 05/12] watchdog: Kconfig for Palmas watchdog Ian Lartey
2013-03-22 14:55 ` Ian Lartey
2013-03-22 14:55 ` Ian Lartey
2013-03-24 4:09 ` Guenter Roeck
2013-03-24 4:09 ` Guenter Roeck
2013-03-22 14:55 ` [PATCH v10 06/12] gpio: palmas: add in GPIO support for palmas charger Ian Lartey
2013-03-22 14:55 ` Ian Lartey
2013-03-22 14:55 ` [PATCH v10 07/12] gpio: palmas: Enable DT support for palmas gpio Ian Lartey
2013-03-22 14:55 ` Ian Lartey
2013-03-22 14:55 ` [PATCH v10 08/12] gpio: Palmas palmas_gpio_(read|write|update) factoring Ian Lartey
2013-03-22 14:55 ` Ian Lartey
2013-03-22 14:55 ` [PATCH v10 09/12] leds: Add support for Palmas LEDs Ian Lartey
2013-03-22 14:55 ` Ian Lartey
2013-03-26 2:55 ` Kim, Milo
2013-03-26 2:55 ` Kim, Milo
2013-03-22 14:55 ` [PATCH v10 10/12] clk: add a clock driver for palmas Ian Lartey
2013-03-22 14:55 ` Ian Lartey
2013-03-22 14:55 ` [PATCH v10 11/12] clk: Kconfig for Palmas clock driver Ian Lartey
2013-03-22 14:55 ` Ian Lartey
2013-03-22 14:55 ` [PATCH v10 12/12] regulator: palmas remove palmas-charger option from DT bindings Ian Lartey
2013-03-22 14:55 ` Ian Lartey
2013-03-25 1:07 ` Mark Brown
2013-03-25 1:07 ` Mark Brown
2013-03-22 19:04 ` [PATCH v10 0/12] Palmas updates Stephen Rothwell
2013-03-22 19:04 ` Stephen Rothwell
2013-03-24 21:13 ` Mark Brown
2013-03-24 21:13 ` Mark Brown
2013-03-25 7:30 ` Laxman Dewangan
2013-03-25 7:30 ` Laxman Dewangan
2013-04-05 16:30 ` Samuel Ortiz
2013-04-05 16:30 ` Samuel Ortiz
2013-04-05 16:30 ` Samuel Ortiz
2013-04-08 15:55 ` Graeme Gregory
2013-04-08 15:55 ` Graeme Gregory
2013-04-08 16:11 ` Samuel Ortiz
2013-04-08 16:11 ` Samuel Ortiz
2013-04-08 16:11 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130325194711.GT18316@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=akpm@linux-foundation.org \
--cc=cooloney@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@secretlab.ca \
--cc=ian@slimlogic.co.uk \
--cc=j-keerthy@ti.com \
--cc=ldewangan@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=rpurdie@rpsys.net \
--cc=sameo@linux.intel.com \
--cc=sfr@canb.auug.org.au \
--cc=swarren@wwwdotorg.org \
--cc=t-kristo@ti.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.