Re: [PATCH v4 09/21] modetest: Allow specifying plane position

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Mar 19, 2013 at 03:55:50PM +0100, Laurent Pinchart wrote:
> Extend the -P option to allow specifying the plane x and y offsets. The
> position is optional, if not specified the plane will be positioned at
> the center of the screen as before.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  tests/modetest/modetest.c | 72 +++++++++++++++++++++++++++++++++++++----------
>  1 file changed, 57 insertions(+), 15 deletions(-)
> 
> diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c
> index 7153a40..f95efe6 100644
> --- a/tests/modetest/modetest.c
> +++ b/tests/modetest/modetest.c
> @@ -645,6 +645,7 @@ struct connector_arg {
>  
>  struct plane_arg {
>  	uint32_t con_id;  /* the id of connector to bind to */
> +	uint32_t x, y;

I'd like the coordinates to allow negative values too. I just posted my
latest version of the plane clipping patches. The main feature there is
to allow coordinates to be partially/fully offscreen and the driver will
clip then the plane to the screen dimensions. Hence negative coordinates
become somewhat useful.

And if you're looking into plane stuff in general, maybe you can review
my patches? The drm_rect utility functions should be useful for all
drivers that have to deal with movable or scalable planes.

Now I'll see about trying this stuff out with my latest patches.

<snip>

-- 
Ville Syrjälä
Intel OTC