From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Rob Clark <robdclark@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v4 17/21] modetest: Give the CRTC ID to the -P option
Date: Wed, 20 Mar 2013 16:01:30 +0100 [thread overview]
Message-ID: <1663586.hpolvtbntI@avalon> (raw)
In-Reply-To: <CAF6AEGvS8sRk7zWLDrYPT9eDB2Rpraeo9+h9UjBzVmANYicTZA@mail.gmail.com>
Hi Rob,
On Tuesday 19 March 2013 14:21:32 Rob Clark wrote:
> On Tue, Mar 19, 2013 at 10:55 AM, Laurent Pinchart wrote:
> > Planes are associated with CRTCs, not connectors. Don't try to be too
> > clever, use the CRTC ID in the -P option. This prepares for splitting
> > CRTC and planes setup.
>
> hmm, I was thinking that it would be nice to someday make modetest clever
> enough to deal w/ connector names instead of connector-id..
That's a good idea (and it shouldn't be too difficult to implement).
> this kinda goes in the opposite direction.
Please note that I use the CRTC ID instead of the connector ID for planes
setup only. Planes are associated with a CRTC, not a connector. I thus thought
it made sense to use the CRTC ID in the argument.
If you think that's a bad idea I can drop the patch. Should modetest then
associate the planes with the CRTC currently associated with the given
connector ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-03-20 15:00 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 14:55 [PATCH v4 00/21] modetest enhancements Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 01/21] modetest: Fix warnings Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 02/21] modetest: Remove extern declarations of opt(arg|ind|err|opt) Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 03/21] modetest: Sort command line arguments Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 04/21] modetest: Add a command line parameter to select the driver Laurent Pinchart
2013-04-03 10:06 ` Ville Syrjälä
2013-04-04 13:22 ` Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 05/21] modetest: Add a command line parameter to drop master after mode set Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 06/21] modetest: Retrieve all resources in one go Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 07/21] modetest: Don't limit mode set and planes to two instances Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 08/21] modetest: Add a command line parameter to set properties Laurent Pinchart
2013-03-28 12:23 ` Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 09/21] modetest: Allow specifying plane position Laurent Pinchart
2013-03-25 6:14 ` Archit Taneja
2013-03-25 22:41 ` Laurent Pinchart
2013-03-26 8:44 ` Archit Taneja
2013-03-27 15:57 ` Ville Syrjälä
2013-03-27 17:15 ` Ville Syrjälä
2013-03-28 0:16 ` Laurent Pinchart
2013-03-28 10:44 ` Ville Syrjälä
2013-04-04 16:24 ` Laurent Pinchart
2013-04-05 15:15 ` Ville Syrjälä
2013-03-28 0:17 ` Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 10/21] modetest: Print the plane ID when setting up a plane Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 11/21] modetest: Remove the -m argument Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 12/21] modetest: Create a device structure Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 13/21] modetest: Compute CRTC pipe number as needed Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 14/21] modetest: Remove the struct connector_arg encoder field Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 15/21] modetest: Store the crtc in the connector_arg structure Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 16/21] modetest: Store the mode in the crtc structure Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 17/21] modetest: Give the CRTC ID to the -P option Laurent Pinchart
2013-03-19 18:21 ` Rob Clark
2013-03-20 15:01 ` Laurent Pinchart [this message]
2013-03-19 14:55 ` [PATCH v4 18/21] modetest: Split mode setting and plane setup Laurent Pinchart
2013-03-19 14:56 ` [PATCH v4 19/21] modetest: Rename struct connector_arg to struct pipe_arg Laurent Pinchart
2013-03-19 14:56 ` [PATCH v4 20/21] modetest: Support pipes with multiple connectors Laurent Pinchart
2013-03-19 14:56 ` [PATCH v4 21/21] modetest: Try all possible encoders for a connector Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1663586.hpolvtbntI@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.