All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: target-devel <target-devel@vger.kernel.org>,
	lf-virt <virtualization@lists.linux-foundation.org>,
	kvm-devel <kvm@vger.kernel.org>,
	qemu-devel <qemu-devel@nongnu.org>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Asias He <asias@redhat.com>,
	Anthony Liguori <aliguori@linux.vnet.ibm.com>
Subject: Re: [PATCH 0/3] Add support for vhost-scsi-pci
Date: Thu, 28 Mar 2013 00:16:49 +0200	[thread overview]
Message-ID: <20130327221649.GB12518@redhat.com> (raw)
In-Reply-To: <1364421586-29857-1-git-send-email-nab@linux-iscsi.org>

On Wed, Mar 27, 2013 at 09:59:43PM +0000, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@linux-iscsi.org>
> 
> Hi QEMU folks,
> 
> The following is the patch series to support vhost-scsi-pci within the
> upstream QEMU tree.
> 
> This includes the refactoring of existing virtio-scsi code from Paolo
> to allow a VirtIOSCSICommon structure that is shared amoungst existing
> virtio-scsi-pci device and new vhost-scsi-pci device code.
> 
> Currently this code requires Asias's seabios bugfixes (commit 5a7730db5
> and b44a7be17), and another tcm_vhost patch to reset vq->last_used_idx
> after seabios handoff that's currently in flight for v3.9.0 kernel code.
> 
> A big thanks to Paolo, Asias, MST, and Stefan for all of their efforts
> on this series.
> 
> Thank you,
> 
> --nab

Looks sane but 3/3 is a hack, needs to be debugged and fixed properly.

> Nicholas Bellinger (1):
>   vhost: Only call vhost_verify_ring_mappings when adding vhost memory
> 
> Paolo Bonzini (2):
>   virtio-scsi: create VirtIOSCSICommon
>   vhost-scsi: new device supporting the tcm_vhost Linux kernel module
> 
>  configure                  |   15 +++-
>  hw/Makefile.objs           |    5 +-
>  hw/s390x/s390-virtio-bus.c |   35 +++++++
>  hw/vhost-scsi.c            |  241 ++++++++++++++++++++++++++++++++++++++++++++
>  hw/vhost-scsi.h            |   66 ++++++++++++
>  hw/vhost.c                 |    2 +-
>  hw/virtio-pci.c            |   62 +++++++++++
>  hw/virtio-scsi.c           |  190 +++++++++--------------------------
>  hw/virtio-scsi.h           |  132 +++++++++++++++++++++++-
>  include/qemu/osdep.h       |    4 +
>  10 files changed, 602 insertions(+), 150 deletions(-)
>  create mode 100644 hw/vhost-scsi.c
>  create mode 100644 hw/vhost-scsi.h
> 
> -- 
> 1.7.2.5

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: kvm-devel <kvm@vger.kernel.org>,
	qemu-devel <qemu-devel@nongnu.org>,
	lf-virt <virtualization@lists.linux-foundation.org>,
	Anthony Liguori <aliguori@linux.vnet.ibm.com>,
	target-devel <target-devel@vger.kernel.org>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Asias He <asias@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] Add support for vhost-scsi-pci
Date: Thu, 28 Mar 2013 00:16:49 +0200	[thread overview]
Message-ID: <20130327221649.GB12518@redhat.com> (raw)
In-Reply-To: <1364421586-29857-1-git-send-email-nab@linux-iscsi.org>

On Wed, Mar 27, 2013 at 09:59:43PM +0000, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@linux-iscsi.org>
> 
> Hi QEMU folks,
> 
> The following is the patch series to support vhost-scsi-pci within the
> upstream QEMU tree.
> 
> This includes the refactoring of existing virtio-scsi code from Paolo
> to allow a VirtIOSCSICommon structure that is shared amoungst existing
> virtio-scsi-pci device and new vhost-scsi-pci device code.
> 
> Currently this code requires Asias's seabios bugfixes (commit 5a7730db5
> and b44a7be17), and another tcm_vhost patch to reset vq->last_used_idx
> after seabios handoff that's currently in flight for v3.9.0 kernel code.
> 
> A big thanks to Paolo, Asias, MST, and Stefan for all of their efforts
> on this series.
> 
> Thank you,
> 
> --nab

Looks sane but 3/3 is a hack, needs to be debugged and fixed properly.

> Nicholas Bellinger (1):
>   vhost: Only call vhost_verify_ring_mappings when adding vhost memory
> 
> Paolo Bonzini (2):
>   virtio-scsi: create VirtIOSCSICommon
>   vhost-scsi: new device supporting the tcm_vhost Linux kernel module
> 
>  configure                  |   15 +++-
>  hw/Makefile.objs           |    5 +-
>  hw/s390x/s390-virtio-bus.c |   35 +++++++
>  hw/vhost-scsi.c            |  241 ++++++++++++++++++++++++++++++++++++++++++++
>  hw/vhost-scsi.h            |   66 ++++++++++++
>  hw/vhost.c                 |    2 +-
>  hw/virtio-pci.c            |   62 +++++++++++
>  hw/virtio-scsi.c           |  190 +++++++++--------------------------
>  hw/virtio-scsi.h           |  132 +++++++++++++++++++++++-
>  include/qemu/osdep.h       |    4 +
>  10 files changed, 602 insertions(+), 150 deletions(-)
>  create mode 100644 hw/vhost-scsi.c
>  create mode 100644 hw/vhost-scsi.h
> 
> -- 
> 1.7.2.5

  parent reply	other threads:[~2013-03-27 22:16 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27 21:59 [PATCH 0/3] Add support for vhost-scsi-pci Nicholas A. Bellinger
2013-03-27 21:59 ` [Qemu-devel] " Nicholas A. Bellinger
2013-03-27 21:59 ` [PATCH 1/3] virtio-scsi: create VirtIOSCSICommon Nicholas A. Bellinger
2013-03-27 21:59   ` [Qemu-devel] " Nicholas A. Bellinger
2013-03-27 21:59 ` [PATCH 2/3] vhost-scsi: new device supporting the tcm_vhost Linux kernel module Nicholas A. Bellinger
2013-03-27 21:59 ` Nicholas A. Bellinger
2013-03-27 21:59   ` [Qemu-devel] " Nicholas A. Bellinger
2013-03-27 22:28   ` Michael S. Tsirkin
2013-03-27 22:28     ` [Qemu-devel] " Michael S. Tsirkin
2013-03-27 22:45     ` Nicholas A. Bellinger
2013-03-27 22:45       ` [Qemu-devel] " Nicholas A. Bellinger
2013-03-27 22:50       ` Michael S. Tsirkin
2013-03-27 22:50         ` [Qemu-devel] " Michael S. Tsirkin
2013-03-27 22:53         ` Michael S. Tsirkin
2013-03-27 22:53         ` Michael S. Tsirkin
2013-03-27 22:53           ` [Qemu-devel] " Michael S. Tsirkin
2013-03-27 23:24           ` Nicholas A. Bellinger
2013-03-27 23:24             ` [Qemu-devel] " Nicholas A. Bellinger
2013-03-28  0:21             ` Nicholas A. Bellinger
2013-03-28  0:21               ` [Qemu-devel] " Nicholas A. Bellinger
2013-03-28  6:19             ` Michael S. Tsirkin
2013-03-28  6:19               ` [Qemu-devel] " Michael S. Tsirkin
2013-03-28  6:28               ` Nicholas A. Bellinger
2013-03-28  6:28               ` Nicholas A. Bellinger
2013-03-28  6:28                 ` [Qemu-devel] " Nicholas A. Bellinger
2013-03-28 16:54                 ` Michael S. Tsirkin
2013-03-28 16:54                   ` [Qemu-devel] " Michael S. Tsirkin
2013-03-27 23:24           ` Nicholas A. Bellinger
2013-03-27 23:05         ` Nicholas A. Bellinger
2013-03-27 23:05           ` [Qemu-devel] " Nicholas A. Bellinger
2013-03-27 23:05         ` Nicholas A. Bellinger
2013-03-27 22:28   ` Michael S. Tsirkin
2013-03-27 21:59 ` [PATCH 3/3] vhost: Only call vhost_verify_ring_mappings when adding vhost memory Nicholas A. Bellinger
2013-03-27 21:59 ` Nicholas A. Bellinger
2013-03-27 21:59   ` [Qemu-devel] " Nicholas A. Bellinger
2013-03-27 22:15   ` Michael S. Tsirkin
2013-03-27 22:15     ` [Qemu-devel] " Michael S. Tsirkin
2013-03-27 22:16 ` [PATCH 0/3] Add support for vhost-scsi-pci Michael S. Tsirkin
2013-03-27 22:16 ` Michael S. Tsirkin [this message]
2013-03-27 22:16   ` [Qemu-devel] " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130327221649.GB12518@redhat.com \
    --to=mst@redhat.com \
    --cc=aliguori@linux.vnet.ibm.com \
    --cc=asias@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=target-devel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.