Re: [Qemu-devel] [PATCH v3 4/5] milkymist-softusb: Don't map RAM memory regions in the device itself

[Michael Walle <michael@walle.cc>]

Am Donnerstag 28 März 2013, 18:55:59 schrieb Anthony Liguori:
> Peter Maydell <peter.maydell@linaro.org> writes:
> > Don't map the pmem and dmem RAM memory regions in the milkymist-softusb
> > device itself. Instead just expose them as sysbus mmio regions which
> > the device creator can map appropriately. This allows us to drop the
> > pmem_base and dmem_base properties. Instead of going via
> > cpu_physical_memory_read/_write when the device wants to access the
> > RAMs, we just keep a host pointer to the memory and use that.
> > 
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > Reviewed-by: Andreas Färber <afaerber@suse.de>
> > Acked-by: Michael Walle <michael@walle.cc>
> 
> Breaks the build:
> 
> [aliguori@ccnode4 qemu]$ make
>   CC    lm32-softmmu/hw/lm32/../milkymist-softusb.o
> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c: In function
> ‘softusb_mouse_hid_datain’:
> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c:183:38: error: ‘m’
> may be used uninitialized in this function [-Werror=maybe-uninitialized]
> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c:179:13: note: ‘m’
> was declared here /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c:
> In function ‘softusb_kbd_hid_datain’:
> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c:197:38: error: ‘m’
> may be used uninitialized in this function [-Werror=maybe-uninitialized]
> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c:193:13: note: ‘m’
> was declared here cc1: all warnings being treated as errors
> make[1]: *** [hw/lm32/../milkymist-softusb.o] Error 1

are you sure, this patch breaks the build, or was is broken before?

i'll send a patch soon.

-- 
michael